From f0f5f084c883dc4f5b6e61603e82cd1c2092fd9d Mon Sep 17 00:00:00 2001 From: nsfisis Date: Sun, 21 Jun 2026 13:11:49 +0900 Subject: test(tests): expand stub macros into plain test functions The per-file stub!/encode_stub!/etc. macros generated #[ignore]d test functions but obscured the individual test bodies. Expanding them inline removes the macro indirection so future ports can fill in each function directly. Co-Authored-By: Claude Opus 4.8 (1M context) --- .../archiver/archivable_files_finder_test.rs | 26 +++++++------ .../tests/package/archiver/archive_manager_test.rs | 44 ++++++++++++++-------- 2 files changed, 44 insertions(+), 26 deletions(-) (limited to 'crates/shirabe/tests/package/archiver') diff --git a/crates/shirabe/tests/package/archiver/archivable_files_finder_test.rs b/crates/shirabe/tests/package/archiver/archivable_files_finder_test.rs index dcca80a..5454074 100644 --- a/crates/shirabe/tests/package/archiver/archivable_files_finder_test.rs +++ b/crates/shirabe/tests/package/archiver/archivable_files_finder_test.rs @@ -26,16 +26,20 @@ impl Drop for TearDown { // These set up a temp directory tree (including a git repo) and assert the files the finder // selects with manual/git/skip excludes; the git-backed fixture setup is not ported. -macro_rules! stub { - ($name:ident) => { - #[test] - #[ignore = "needs a temp directory tree and git-backed fixtures to drive ArchivableFilesFinder; not ported"] - fn $name() { - todo!() - } - }; +#[test] +#[ignore = "needs a temp directory tree and git-backed fixtures to drive ArchivableFilesFinder; not ported"] +fn test_manual_excludes() { + todo!() +} + +#[test] +#[ignore = "needs a temp directory tree and git-backed fixtures to drive ArchivableFilesFinder; not ported"] +fn test_git_excludes() { + todo!() } -stub!(test_manual_excludes); -stub!(test_git_excludes); -stub!(test_skip_excludes); +#[test] +#[ignore = "needs a temp directory tree and git-backed fixtures to drive ArchivableFilesFinder; not ported"] +fn test_skip_excludes() { + todo!() +} diff --git a/crates/shirabe/tests/package/archiver/archive_manager_test.rs b/crates/shirabe/tests/package/archiver/archive_manager_test.rs index 912512d..b3b61f8 100644 --- a/crates/shirabe/tests/package/archiver/archive_manager_test.rs +++ b/crates/shirabe/tests/package/archiver/archive_manager_test.rs @@ -28,18 +28,32 @@ impl Drop for TearDown { // These drive ArchiveManager end-to-end (building tar archives via PharData, todo!()) and // the filename-derivation helpers over packages; the archiving and fixture setup are not // ported. -macro_rules! stub { - ($name:ident) => { - #[test] - #[ignore = "ArchiveManager builds archives via PharData (todo!()) over fixtures; not ported"] - fn $name() { - todo!() - } - }; -} - -stub!(test_unknown_format); -stub!(test_archive_tar); -stub!(test_archive_custom_file_name); -stub!(test_get_package_filename_parts); -stub!(test_get_package_filename); +#[test] +#[ignore = "ArchiveManager builds archives via PharData (todo!()) over fixtures; not ported"] +fn test_unknown_format() { + todo!() +} + +#[test] +#[ignore = "ArchiveManager builds archives via PharData (todo!()) over fixtures; not ported"] +fn test_archive_tar() { + todo!() +} + +#[test] +#[ignore = "ArchiveManager builds archives via PharData (todo!()) over fixtures; not ported"] +fn test_archive_custom_file_name() { + todo!() +} + +#[test] +#[ignore = "ArchiveManager builds archives via PharData (todo!()) over fixtures; not ported"] +fn test_get_package_filename_parts() { + todo!() +} + +#[test] +#[ignore = "ArchiveManager builds archives via PharData (todo!()) over fixtures; not ported"] +fn test_get_package_filename() { + todo!() +} -- cgit v1.3.1