From 340164c64e90d44b1bdf620b514166db1f76cc98 Mon Sep 17 00:00:00 2001 From: nsfisis Date: Wed, 24 Jun 2026 00:47:20 +0900 Subject: test: port more unimplemented tests Co-Authored-By: Claude Opus 4.8 (1M context) --- crates/shirabe/tests/package/dumper/array_dumper_test.rs | 13 +++++++++---- 1 file changed, 9 insertions(+), 4 deletions(-) (limited to 'crates/shirabe/tests/package/dumper/array_dumper_test.rs') diff --git a/crates/shirabe/tests/package/dumper/array_dumper_test.rs b/crates/shirabe/tests/package/dumper/array_dumper_test.rs index 64880f1..1e5fd05 100644 --- a/crates/shirabe/tests/package/dumper/array_dumper_test.rs +++ b/crates/shirabe/tests/package/dumper/array_dumper_test.rs @@ -79,11 +79,16 @@ fn test_dump_abandoned_replacement() { ); } -// PHP drives ~25 heterogeneous setters dynamically (set{ucfirst(method)}) across strings, -// arrays, a DateTime and Link maps, then checks the corresponding dumped key. Reproducing -// that dynamic dispatch faithfully would require per-case wiring for every property type. +// PHP drives 26 heterogeneous setters dynamically (set{ucfirst(method)}) across strings, +// arrays, a DateTime and Link maps, then checks the corresponding dumped key. Three of the +// data sets cannot be expressed faithfully because the ported production types were narrowed +// from PHP's loose `array`: the `authors` set passes plain strings (Rust set_authors wants +// Vec>), `scripts` passes a bare string value (set_scripts wants +// IndexMap>), and `funding` passes a single map (set_funding wants +// Vec>); the dumper additionally re-wraps each of these. Porting the +// remaining 23 would drop those three cases, so testKeys stays unported (all-or-nothing). #[test] -#[ignore = "RootPackageHandle lacks set_type/set_release_date/set_binaries/set_php_ext setters required by the data provider's type/time/bin/php-ext cases"] +#[ignore = "authors/scripts/funding data sets pass loosely-typed PHP arrays the narrowed Rust set_authors/set_scripts/set_funding types cannot represent, and the dumper re-wraps them; faithful all-or-nothing port blocked without loosening those production types"] fn test_keys() { todo!() } -- cgit v1.3.1