From f0f5f084c883dc4f5b6e61603e82cd1c2092fd9d Mon Sep 17 00:00:00 2001
From: nsfisis <nsfisis@gmail.com>
Date: Sun, 21 Jun 2026 13:11:49 +0900
Subject: test(tests): expand stub macros into plain test functions

The per-file stub!/encode_stub!/etc. macros generated #[ignore]d test
functions but obscured the individual test bodies. Expanding them inline
removes the macro indirection so future ports can fill in each function
directly.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
---
 .../tests/package/version/version_selector_test.rs | 100 ++++++++++++++++-----
 1 file changed, 77 insertions(+), 23 deletions(-)

(limited to 'crates/shirabe/tests/package/version/version_selector_test.rs')

diff --git a/crates/shirabe/tests/package/version/version_selector_test.rs b/crates/shirabe/tests/package/version/version_selector_test.rs
index ccd64ad..fd426ce 100644
--- a/crates/shirabe/tests/package/version/version_selector_test.rs
+++ b/crates/shirabe/tests/package/version/version_selector_test.rs
@@ -2,26 +2,80 @@
 
 // VersionSelector ranks candidate packages whose versions/constraints are parsed through a
 // look-around regex the regex crate cannot compile; the setup also mocks a repository.
-macro_rules! stub {
-    ($name:ident) => {
-        #[test]
-        #[ignore = "not yet ported (VersionSelector over a mocked repository; constraint parsing uses a look-around regex)"]
-        fn $name() {
-            todo!()
-        }
-    };
-}
-
-stub!(test_latest_version_is_returned);
-stub!(test_latest_version_is_returned_that_matches_php_requirements);
-stub!(test_latest_version_is_returned_that_matches_ext_requirements);
-stub!(test_latest_version_is_returned_that_matches_platform_ext);
-stub!(test_latest_version_is_returned_that_matches_composer_requirements);
-stub!(test_most_stable_version_is_returned);
-stub!(test_most_stable_version_is_returned_regardless_of_order);
-stub!(test_highest_version_is_returned);
-stub!(test_highest_version_matching_stability_is_returned);
-stub!(test_most_stable_unstable_version_is_returned);
-stub!(test_default_branch_alias_is_never_returned);
-stub!(test_false_returned_on_no_packages);
-stub!(test_find_recommended_require_version);
+#[test]
+#[ignore = "not yet ported (VersionSelector over a mocked repository; constraint parsing uses a look-around regex)"]
+fn test_latest_version_is_returned() {
+    todo!()
+}
+
+#[test]
+#[ignore = "not yet ported (VersionSelector over a mocked repository; constraint parsing uses a look-around regex)"]
+fn test_latest_version_is_returned_that_matches_php_requirements() {
+    todo!()
+}
+
+#[test]
+#[ignore = "not yet ported (VersionSelector over a mocked repository; constraint parsing uses a look-around regex)"]
+fn test_latest_version_is_returned_that_matches_ext_requirements() {
+    todo!()
+}
+
+#[test]
+#[ignore = "not yet ported (VersionSelector over a mocked repository; constraint parsing uses a look-around regex)"]
+fn test_latest_version_is_returned_that_matches_platform_ext() {
+    todo!()
+}
+
+#[test]
+#[ignore = "not yet ported (VersionSelector over a mocked repository; constraint parsing uses a look-around regex)"]
+fn test_latest_version_is_returned_that_matches_composer_requirements() {
+    todo!()
+}
+
+#[test]
+#[ignore = "not yet ported (VersionSelector over a mocked repository; constraint parsing uses a look-around regex)"]
+fn test_most_stable_version_is_returned() {
+    todo!()
+}
+
+#[test]
+#[ignore = "not yet ported (VersionSelector over a mocked repository; constraint parsing uses a look-around regex)"]
+fn test_most_stable_version_is_returned_regardless_of_order() {
+    todo!()
+}
+
+#[test]
+#[ignore = "not yet ported (VersionSelector over a mocked repository; constraint parsing uses a look-around regex)"]
+fn test_highest_version_is_returned() {
+    todo!()
+}
+
+#[test]
+#[ignore = "not yet ported (VersionSelector over a mocked repository; constraint parsing uses a look-around regex)"]
+fn test_highest_version_matching_stability_is_returned() {
+    todo!()
+}
+
+#[test]
+#[ignore = "not yet ported (VersionSelector over a mocked repository; constraint parsing uses a look-around regex)"]
+fn test_most_stable_unstable_version_is_returned() {
+    todo!()
+}
+
+#[test]
+#[ignore = "not yet ported (VersionSelector over a mocked repository; constraint parsing uses a look-around regex)"]
+fn test_default_branch_alias_is_never_returned() {
+    todo!()
+}
+
+#[test]
+#[ignore = "not yet ported (VersionSelector over a mocked repository; constraint parsing uses a look-around regex)"]
+fn test_false_returned_on_no_packages() {
+    todo!()
+}
+
+#[test]
+#[ignore = "not yet ported (VersionSelector over a mocked repository; constraint parsing uses a look-around regex)"]
+fn test_find_recommended_require_version() {
+    todo!()
+}
-- 
cgit v1.3.1