From f5f429dbae0a3e2d8224c0b1e4edcef54805d286 Mon Sep 17 00:00:00 2001 From: nsfisis Date: Thu, 25 Jun 2026 16:44:29 +0900 Subject: feat(http): reimplement CurlDownloader on reqwest; port 15 more tests Replace the libcurl-shim CurlDownloader with a reqwest+tokio implementation per the .ken sketch, resolving the construction panic that blocked command tests (mock path via __new_mock is untouched). Port remote_filesystem (7), hg/svn driver (4), zip_archiver/git_exclude_filter (4) tests. Fix hg/svn/git_exclude regex-delimiter and svn result-propagation porting bugs. Co-Authored-By: Claude Opus 4.8 (1M context) --- crates/shirabe/tests/package/archiver/git_exclude_filter_test.rs | 1 - crates/shirabe/tests/package/archiver/zip_archiver_test.rs | 7 ++++--- 2 files changed, 4 insertions(+), 4 deletions(-) (limited to 'crates/shirabe/tests/package') diff --git a/crates/shirabe/tests/package/archiver/git_exclude_filter_test.rs b/crates/shirabe/tests/package/archiver/git_exclude_filter_test.rs index 80f9f31..ab1d609 100644 --- a/crates/shirabe/tests/package/archiver/git_exclude_filter_test.rs +++ b/crates/shirabe/tests/package/archiver/git_exclude_filter_test.rs @@ -3,7 +3,6 @@ use shirabe::package::archiver::git_exclude_filter::GitExcludeFilter; #[test] -#[ignore] fn test_pattern_escape() { for (ignore, expected) in provide_patterns() { let filter = GitExcludeFilter::new("/".to_string()); diff --git a/crates/shirabe/tests/package/archiver/zip_archiver_test.rs b/crates/shirabe/tests/package/archiver/zip_archiver_test.rs index 7785976..b94beb6 100644 --- a/crates/shirabe/tests/package/archiver/zip_archiver_test.rs +++ b/crates/shirabe/tests/package/archiver/zip_archiver_test.rs @@ -1,6 +1,7 @@ //! ref: composer/tests/Composer/Test/Package/Archiver/ZipArchiverTest.php use indexmap::IndexMap; +use serial_test::serial; use shirabe::package::archiver::{ArchiverInterface, ZipArchiver}; use shirabe::package::handle::CompletePackageHandle; use shirabe::util::Platform; @@ -116,8 +117,8 @@ impl ArchiverTestCase { } } -#[ignore = "ZipArchiver::archive and the ZipArchive reader (open/get_from_name/...) are todo!() in the php-shim"] #[test] +#[serial] fn test_simple_files() { let mut test_case = ArchiverTestCase::set_up(); @@ -137,8 +138,8 @@ fn test_simple_files() { test_case.assert_zip_archive(files); } -#[ignore = "ZipArchiver::archive and the ZipArchive reader (open/get_from_name/...) are todo!() in the php-shim"] #[test] +#[serial] fn test_gitignore_exclude_negation() { for include in ["!/docs", "!/docs/"] { let mut test_case = ArchiverTestCase::set_up(); @@ -154,8 +155,8 @@ fn test_gitignore_exclude_negation() { } } -#[ignore = "ZipArchiver::archive and the ZipArchive reader (open/get_from_name/...) are todo!() in the php-shim"] #[test] +#[serial] fn test_folder_with_backslashes() { if Platform::is_windows() { // markTestSkipped('Folder names cannot contain backslashes on Windows.') -- cgit v1.3.1