From 7f810b1bb288445ee5376fada752e84ecb1ce211 Mon Sep 17 00:00:00 2001 From: nsfisis Date: Wed, 24 Jun 2026 21:38:53 +0900 Subject: feat(process): wire execute output handling to a callback model Replace the Option<&mut PhpMixed> output plumbing with the IntoExecOutput trait modelling each PHP `$output` case (forward, capture-to-buffer, discard, callback). This lets do_execute pass a real output handler to Process::run, captures output back via get_output, and lets Svn pass its streaming filter handler through execute instead of skipping it. --- crates/shirabe/tests/platform/hhvm_detector_test.rs | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) (limited to 'crates/shirabe/tests/platform/hhvm_detector_test.rs') diff --git a/crates/shirabe/tests/platform/hhvm_detector_test.rs b/crates/shirabe/tests/platform/hhvm_detector_test.rs index 72fd68d..5bf96d2 100644 --- a/crates/shirabe/tests/platform/hhvm_detector_test.rs +++ b/crates/shirabe/tests/platform/hhvm_detector_test.rs @@ -57,9 +57,7 @@ fn test_hhvm_version_when_executing_in_php() { "{} --php -d hhvm.jit=0 -r \"echo HHVM_VERSION;\" 2>/dev/null", ProcessExecutor::escape(&hhvm) ); - let exit_code = process - .execute(cmd.as_str(), Some(&mut version), None) - .unwrap(); + let exit_code = process.execute(cmd.as_str(), &mut version, None).unwrap(); assert_eq!(0, exit_code); let version = version -- cgit v1.3.1