From 2b2ca914cc5f2f7fde3b6e75faabbe4913fd7264 Mon Sep 17 00:00:00 2001 From: nsfisis Date: Sun, 21 Jun 2026 12:40:10 +0900 Subject: test(tests): port setUp/tearDown as set_up/tear_down with TearDown Port PHP setUp/tearDown across the ported integration tests using same-named set_up()/tear_down() functions and a TearDown struct whose Drop runs tear_down(). Fixture-init setUp returns its fixtures; tmpdir-style setUp/tearDown carry state in TearDown fields. Parts that depend on unported infrastructure (PHPUnit mocks, Config::merge, the PHP error handler) stay todo!() and are only wired into ignored stubs to avoid breaking live tests. Also fix shirabe-php-shim putenv to handle the no-'=' form (PHP unsets the variable), which Platform::clear_env relies on for the env-clearing tearDowns. Co-Authored-By: Claude Opus 4.8 --- crates/shirabe/tests/platform/hhvm_detector_test.rs | 10 ++++++++++ 1 file changed, 10 insertions(+) (limited to 'crates/shirabe/tests/platform') diff --git a/crates/shirabe/tests/platform/hhvm_detector_test.rs b/crates/shirabe/tests/platform/hhvm_detector_test.rs index 8c420e5..1b35450 100644 --- a/crates/shirabe/tests/platform/hhvm_detector_test.rs +++ b/crates/shirabe/tests/platform/hhvm_detector_test.rs @@ -1,13 +1,23 @@ //! ref: composer/tests/Composer/Test/Platform/HhvmDetectorTest.php +use shirabe::platform::hhvm_detector::HhvmDetector; + +fn set_up() -> HhvmDetector { + let hhvm_detector = HhvmDetector::new(None, None); + hhvm_detector.reset(); + hhvm_detector +} + #[test] #[ignore = "skipped unless running under HHVM (HHVM_VERSION_ID defined), which never holds here"] fn test_hhvm_version_when_executing_in_hhvm() { + let _hhvm_detector = set_up(); todo!() } #[test] #[ignore = "needs an installed hhvm executable plus ExecutableFinder/ProcessExecutor; skipped in PHP when hhvm is absent"] fn test_hhvm_version_when_executing_in_php() { + let _hhvm_detector = set_up(); todo!() } -- cgit v1.3.1