From 0800c90a7ec0bc7a3d4c13063dfe6d2298a557bc Mon Sep 17 00:00:00 2001 From: nsfisis Date: Wed, 19 Aug 2026 23:45:37 +0900 Subject: fix(input): thread a typed InputValue through the input layer Options and arguments were stored and passed as PhpMixed even though Symfony only ever puts a string, a bool, a list of strings or null in one. get_option already narrowed to InputOptionValue at the boundary; this widens that enum into InputValue and pushes it through InputInterface, InputOption/InputArgument defaults, the Input storage, ArgvInput/ArrayInput/StringInput/CompletionInput, Command::add_option and add_argument, and the Composer-side wrappers. Two neighbouring string|int unions get types of their own: InputDefinition::{get_argument,has_argument} take an ArgumentName, and ArrayInput keys its parameters by ParameterName. has_parameter_option and get_parameter_option take the values they look for as &[&str], which is what PHP's `(array) $values` cast produced anyway. Two behaviours change along the way. Input::set_option on a negated option now negates with PHP's loose bool cast rather than treating a non-bool as false, matching `!$value`. ArrayInput::parse now resolves an integer key to an argument position instead of looking up an argument literally named "0". Co-Authored-By: Claude Opus 5 (1M context) --- crates/shirabe/tests/question/strict_confirmation_question_test.rs | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) (limited to 'crates/shirabe/tests/question') diff --git a/crates/shirabe/tests/question/strict_confirmation_question_test.rs b/crates/shirabe/tests/question/strict_confirmation_question_test.rs index 0c163c84..5d84f309 100644 --- a/crates/shirabe/tests/question/strict_confirmation_question_test.rs +++ b/crates/shirabe/tests/question/strict_confirmation_question_test.rs @@ -4,6 +4,8 @@ use shirabe::question::StrictConfirmationQuestion; use shirabe_php_shim::PhpMixed; use shirabe_symfony_console::helper::{QuestionHelper, QuestionHelperInterface}; use shirabe_symfony_console::input::ArrayInput; +use shirabe_symfony_console::input::InputValue; +use shirabe_symfony_console::input::ParameterName; use shirabe_symfony_console::input::StreamableInputInterface; use shirabe_symfony_console::output::OutputInterface; use shirabe_symfony_console::output::StreamOutput; @@ -117,8 +119,8 @@ fn create_output_interface() -> std::rc::Rc (ArrayInput, QuestionHelper) { let mut input = ArrayInput::new( vec![( - PhpMixed::Int(0), - PhpMixed::String("--no-interaction".to_string()), + ParameterName::Index(0), + InputValue::String("--no-interaction".to_string()), )], None, ) -- cgit v1.3.1-4-g156e