From 2b2ca914cc5f2f7fde3b6e75faabbe4913fd7264 Mon Sep 17 00:00:00 2001 From: nsfisis Date: Sun, 21 Jun 2026 12:40:10 +0900 Subject: test(tests): port setUp/tearDown as set_up/tear_down with TearDown Port PHP setUp/tearDown across the ported integration tests using same-named set_up()/tear_down() functions and a TearDown struct whose Drop runs tear_down(). Fixture-init setUp returns its fixtures; tmpdir-style setUp/tearDown carry state in TearDown fields. Parts that depend on unported infrastructure (PHPUnit mocks, Config::merge, the PHP error handler) stay todo!() and are only wired into ignored stubs to avoid breaking live tests. Also fix shirabe-php-shim putenv to handle the no-'=' form (PHP unsets the variable), which Platform::clear_env relies on for the env-clearing tearDowns. Co-Authored-By: Claude Opus 4.8 --- .../tests/repository/repository_manager_test.rs | 43 ++++++++++++++++++++++ 1 file changed, 43 insertions(+) (limited to 'crates/shirabe/tests/repository/repository_manager_test.rs') diff --git a/crates/shirabe/tests/repository/repository_manager_test.rs b/crates/shirabe/tests/repository/repository_manager_test.rs index 60deb7e..dec018a 100644 --- a/crates/shirabe/tests/repository/repository_manager_test.rs +++ b/crates/shirabe/tests/repository/repository_manager_test.rs @@ -4,26 +4,69 @@ // curl_multi_init, todo!()) with a mocked IO/Config/EventDispatcher and exercise repo // creation/prepending/wrapping. +use shirabe::util::filesystem::Filesystem; +use tempfile::TempDir; + +struct SetUp { + tmpdir: TempDir, +} + +fn set_up() -> SetUp { + let tmpdir = TempDir::new().unwrap(); + SetUp { tmpdir } +} + +fn tear_down(tmpdir: &std::path::Path) { + if tmpdir.is_dir() { + let mut fs = Filesystem::new(None); + fs.remove_directory(tmpdir).unwrap(); + } +} + +struct TearDown { + tmpdir: std::path::PathBuf, +} + +impl TearDown { + fn new(tmpdir: std::path::PathBuf) -> Self { + TearDown { tmpdir } + } +} + +impl Drop for TearDown { + fn drop(&mut self) { + tear_down(&self.tmpdir); + } +} + #[test] #[ignore = "RepositoryManager::new builds an HttpDownloader (curl_multi_init todo!()) and mocks IO/Config"] fn test_prepend() { + let SetUp { tmpdir } = set_up(); + let _tear_down = TearDown::new(tmpdir.path().to_path_buf()); todo!() } #[test] #[ignore = "RepositoryManager::new builds an HttpDownloader (curl_multi_init todo!()) and mocks IO/Config"] fn test_repo_creation() { + let SetUp { tmpdir } = set_up(); + let _tear_down = TearDown::new(tmpdir.path().to_path_buf()); todo!() } #[test] #[ignore = "RepositoryManager::new builds an HttpDownloader (curl_multi_init todo!()) and mocks IO/Config"] fn test_invalid_repo_creation_throws() { + let SetUp { tmpdir } = set_up(); + let _tear_down = TearDown::new(tmpdir.path().to_path_buf()); todo!() } #[test] #[ignore = "RepositoryManager::new builds an HttpDownloader (curl_multi_init todo!()) and mocks IO/Config"] fn test_filter_repo_wrapping() { + let SetUp { tmpdir } = set_up(); + let _tear_down = TearDown::new(tmpdir.path().to_path_buf()); todo!() } -- cgit v1.3.1