From 2b2ca914cc5f2f7fde3b6e75faabbe4913fd7264 Mon Sep 17 00:00:00 2001 From: nsfisis Date: Sun, 21 Jun 2026 12:40:10 +0900 Subject: test(tests): port setUp/tearDown as set_up/tear_down with TearDown Port PHP setUp/tearDown across the ported integration tests using same-named set_up()/tear_down() functions and a TearDown struct whose Drop runs tear_down(). Fixture-init setUp returns its fixtures; tmpdir-style setUp/tearDown carry state in TearDown fields. Parts that depend on unported infrastructure (PHPUnit mocks, Config::merge, the PHP error handler) stay todo!() and are only wired into ignored stubs to avoid breaking live tests. Also fix shirabe-php-shim putenv to handle the no-'=' form (PHP unsets the variable), which Platform::clear_env relies on for the env-clearing tearDowns. Co-Authored-By: Claude Opus 4.8 --- .../tests/repository/vcs/github_driver_test.rs | 66 ++++++++++++++++++++++ 1 file changed, 66 insertions(+) (limited to 'crates/shirabe/tests/repository/vcs/github_driver_test.rs') diff --git a/crates/shirabe/tests/repository/vcs/github_driver_test.rs b/crates/shirabe/tests/repository/vcs/github_driver_test.rs index d0067d5..3e97599 100644 --- a/crates/shirabe/tests/repository/vcs/github_driver_test.rs +++ b/crates/shirabe/tests/repository/vcs/github_driver_test.rs @@ -3,10 +3,55 @@ use std::cell::RefCell; use std::rc::Rc; +use indexmap::IndexMap; use shirabe::config::Config; use shirabe::io::IOInterface; use shirabe::io::null_io::NullIO; use shirabe::repository::vcs::GitHubDriver; +use shirabe::util::filesystem::Filesystem; +use shirabe_php_shim::PhpMixed; +use tempfile::TempDir; + +struct SetUp { + home: TempDir, + config: Config, +} + +fn set_up() -> SetUp { + let home = TempDir::new().unwrap(); + let mut config = Config::new(true, None); + let mut top: IndexMap = IndexMap::new(); + let mut config_section: IndexMap = IndexMap::new(); + config_section.insert( + "home".to_string(), + PhpMixed::String(home.path().to_string_lossy().into_owned()), + ); + top.insert("config".to_string(), PhpMixed::Array(config_section)); + config.merge(&top, Config::SOURCE_UNKNOWN); + + SetUp { home, config } +} + +fn tear_down(home: &std::path::Path) { + let mut fs = Filesystem::new(None); + fs.remove_directory(home).unwrap(); +} + +struct TearDown { + home: std::path::PathBuf, +} + +impl TearDown { + fn new(home: std::path::PathBuf) -> Self { + TearDown { home } + } +} + +impl Drop for TearDown { + fn drop(&mut self) { + tear_down(&self.home); + } +} fn supports_provider() -> Vec<(bool, &'static str)> { vec![ @@ -21,6 +66,9 @@ fn supports_provider() -> Vec<(bool, &'static str)> { #[test] #[ignore = "GitHubDriver::supports reaches non-strict in_array, which is todo!() in the php-shim"] fn test_supports() { + let SetUp { home, config: _ } = set_up(); + let _tear_down = TearDown::new(home.path().to_path_buf()); + for (expected, repo_url) in supports_provider() { let io: Rc> = Rc::new(RefCell::new(NullIO::new())); let config = Rc::new(RefCell::new(Config::new(true, None))); @@ -38,53 +86,71 @@ fn test_supports() { #[test] #[ignore = "constructs a GitHubDriver and mocks the HttpDownloader/IO (curl_multi_init todo!())"] fn test_private_repository() { + let SetUp { home, config: _ } = set_up(); + let _tear_down = TearDown::new(home.path().to_path_buf()); todo!() } #[test] #[ignore = "constructs a GitHubDriver and mocks the HttpDownloader/IO (curl_multi_init todo!())"] fn test_public_repository() { + let SetUp { home, config: _ } = set_up(); + let _tear_down = TearDown::new(home.path().to_path_buf()); todo!() } #[test] #[ignore = "constructs a GitHubDriver and mocks the HttpDownloader/IO (curl_multi_init todo!())"] fn test_public_repository2() { + let SetUp { home, config: _ } = set_up(); + let _tear_down = TearDown::new(home.path().to_path_buf()); todo!() } #[test] #[ignore = "constructs a GitHubDriver and mocks the HttpDownloader/IO (curl_multi_init todo!())"] fn test_invalid_support_data() { + let SetUp { home, config: _ } = set_up(); + let _tear_down = TearDown::new(home.path().to_path_buf()); todo!() } #[test] #[ignore = "constructs a GitHubDriver and mocks the HttpDownloader/IO (curl_multi_init todo!())"] fn test_funding_format() { + let SetUp { home, config: _ } = set_up(); + let _tear_down = TearDown::new(home.path().to_path_buf()); todo!() } #[test] #[ignore = "constructs a GitHubDriver and mocks the HttpDownloader/IO (curl_multi_init todo!())"] fn test_public_repository_archived() { + let SetUp { home, config: _ } = set_up(); + let _tear_down = TearDown::new(home.path().to_path_buf()); todo!() } #[test] #[ignore = "constructs a GitHubDriver and mocks the HttpDownloader/IO (curl_multi_init todo!())"] fn test_private_repository_no_interaction() { + let SetUp { home, config: _ } = set_up(); + let _tear_down = TearDown::new(home.path().to_path_buf()); todo!() } #[test] #[ignore = "constructs a GitHubDriver and mocks the HttpDownloader/IO (curl_multi_init todo!())"] fn test_initialize_invalid_repo_url() { + let SetUp { home, config: _ } = set_up(); + let _tear_down = TearDown::new(home.path().to_path_buf()); todo!() } #[test] #[ignore = "constructs a GitHubDriver and mocks the HttpDownloader/IO (curl_multi_init todo!())"] fn test_get_empty_file_content() { + let SetUp { home, config: _ } = set_up(); + let _tear_down = TearDown::new(home.path().to_path_buf()); todo!() } -- cgit v1.3.1