From 2b2ca914cc5f2f7fde3b6e75faabbe4913fd7264 Mon Sep 17 00:00:00 2001 From: nsfisis Date: Sun, 21 Jun 2026 12:40:10 +0900 Subject: test(tests): port setUp/tearDown as set_up/tear_down with TearDown Port PHP setUp/tearDown across the ported integration tests using same-named set_up()/tear_down() functions and a TearDown struct whose Drop runs tear_down(). Fixture-init setUp returns its fixtures; tmpdir-style setUp/tearDown carry state in TearDown fields. Parts that depend on unported infrastructure (PHPUnit mocks, Config::merge, the PHP error handler) stay todo!() and are only wired into ignored stubs to avoid breaking live tests. Also fix shirabe-php-shim putenv to handle the no-'=' form (PHP unsets the variable), which Platform::clear_env relies on for the env-clearing tearDowns. Co-Authored-By: Claude Opus 4.8 --- .../tests/repository/vcs_repository_test.rs | 45 ++++++++++++++++++++++ 1 file changed, 45 insertions(+) (limited to 'crates/shirabe/tests/repository/vcs_repository_test.rs') diff --git a/crates/shirabe/tests/repository/vcs_repository_test.rs b/crates/shirabe/tests/repository/vcs_repository_test.rs index b9486fc..c687b3d 100644 --- a/crates/shirabe/tests/repository/vcs_repository_test.rs +++ b/crates/shirabe/tests/repository/vcs_repository_test.rs @@ -1,10 +1,55 @@ //! ref: composer/tests/Composer/Test/Repository/VcsRepositoryTest.php +use shirabe::util::filesystem::Filesystem; + +struct SetUp { + composer_home: std::path::PathBuf, + git_repo: std::path::PathBuf, +} + +fn set_up() -> SetUp { + // setUp lazily runs initialize(), which shells out to git to build a fixture repository + // on disk; the ExecutableFinder/ProcessExecutor-driven setup and the markTestSkipped + // skip path are not ported. + todo!() +} + +fn tear_down(composer_home: &std::path::Path, git_repo: &std::path::Path) { + let mut fs = Filesystem::new(None); + fs.remove_directory(composer_home).unwrap(); + fs.remove_directory(git_repo).unwrap(); +} + +struct TearDown { + composer_home: std::path::PathBuf, + git_repo: std::path::PathBuf, +} + +impl TearDown { + fn new(composer_home: std::path::PathBuf, git_repo: std::path::PathBuf) -> Self { + TearDown { + composer_home, + git_repo, + } + } +} + +impl Drop for TearDown { + fn drop(&mut self) { + tear_down(&self.composer_home, &self.git_repo); + } +} + // testLoadVersions initialises a real git repository on disk and drives a VcsRepository over // it, then asserts the loaded package versions; the git fixture setup and constraint parsing // (look-around regex) are not ported. #[test] #[ignore = "not yet ported (initialises a git repo on disk and loads versions; constraint parsing uses a look-around regex)"] fn test_load_versions() { + let SetUp { + composer_home, + git_repo, + } = set_up(); + let _tear_down = TearDown::new(composer_home, git_repo); todo!() } -- cgit v1.3.1