From 37ed5b8c6d4cda30e668d0221eb281431dbc8c67 Mon Sep 17 00:00:00 2001 From: nsfisis Date: Mon, 20 Jul 2026 16:04:45 +0900 Subject: test(ignore): document root causes for unannotated #[ignore] tests 74 tests carried a bare #[ignore] with no explanation. Re-ran each: 25 now pass and had the attribute removed; the remaining 49 got a concise reason (todo!() stubs, regex-crate PCRE gaps, PhpMixed type mismatches, config bool-coercion bugs, missing skipped_load wiring in PoolBuilder, etc.) so future work can find and fix them by grep. No production code or test logic/assertions were changed. Co-Authored-By: Claude Sonnet 5 --- crates/shirabe/tests/repository/array_repository_test.rs | 1 - crates/shirabe/tests/repository/filesystem_repository_test.rs | 4 ++-- 2 files changed, 2 insertions(+), 3 deletions(-) (limited to 'crates/shirabe/tests/repository') diff --git a/crates/shirabe/tests/repository/array_repository_test.rs b/crates/shirabe/tests/repository/array_repository_test.rs index ae6725d0..069e9113 100644 --- a/crates/shirabe/tests/repository/array_repository_test.rs +++ b/crates/shirabe/tests/repository/array_repository_test.rs @@ -99,7 +99,6 @@ fn test_find_packages() { } #[test] -#[ignore] fn test_automatically_add_aliased_package_but_not_remove() { let repo = ArrayRepository::new(vec![]).unwrap(); diff --git a/crates/shirabe/tests/repository/filesystem_repository_test.rs b/crates/shirabe/tests/repository/filesystem_repository_test.rs index b0d18c68..f2cdb670 100644 --- a/crates/shirabe/tests/repository/filesystem_repository_test.rs +++ b/crates/shirabe/tests/repository/filesystem_repository_test.rs @@ -51,7 +51,7 @@ fn test_repository_read() { assert_eq!(packages[0].get_type(), "vendor"); } -#[ignore] +#[ignore = "InvalidRepositoryException message building calls shirabe_php_shim::var::get_class_err(), which is still todo!()"] #[test] fn test_corrupted_repository_file() { // PHP mocks read() to return the scalar string 'foo'; a real file containing the JSON string @@ -327,7 +327,7 @@ fn test_repository_writes_installed_php() { assert_eq!(expected, actual); } -#[ignore] +#[ignore = "safely_load_installed_versions's pattern uses a PCRE (?(DEFINE)...) recursive grammar the regex crate cannot compile"] #[test] fn test_safely_load_installed_versions() { let fixtures_dir = format!( -- cgit v1.3.1