From f691b864b687f251c3b266e8cff2774d730567ba Mon Sep 17 00:00:00 2001 From: nsfisis Date: Sun, 21 Jun 2026 21:25:15 +0900 Subject: test(php-shim): un-ignore tests now unblocked by implemented shims Remove #[ignore] from tests gated solely on a shim function that is now implemented, where the test passes: - metapackage_installer::test_update (version_compare) - platform_requirement_filter_factory::test_from_bool_throws... (get_debug_type) - runtime::test_parse_extension_info (html_entity_decode/strip_tags) - package_sorter::test_sorting_does_nothing... (strnatcasecmp) - no_proxy_pattern::test_host_name/test_port (unpack/substr_count) - version_parser::test_is_upgrade (version_compare) - pool::test_what_provides_package_with_constraint - proxy_item::test_throws_on_malformed_url Update the ignore reason where the cited shim is now implemented but the test still cannot pass for a different reason: - no_proxy_pattern::test_ip_address/test_ip_range (IPv4-mapped IPv6 gap) - package_sorter::test_sorting_orders... (look-around regex) - proxy_item::test_url_formatting (parse_url host discrepancy) - json_manipulator/json_config_source/filesystem_repository stubs (test bodies are still todo!(), not yet ported) Co-Authored-By: Claude Opus 4.8 (1M context) --- .../tests/repository/filesystem_repository_test.rs | 15 ++++++--------- 1 file changed, 6 insertions(+), 9 deletions(-) (limited to 'crates/shirabe/tests/repository') diff --git a/crates/shirabe/tests/repository/filesystem_repository_test.rs b/crates/shirabe/tests/repository/filesystem_repository_test.rs index d798fc9..a14804b 100644 --- a/crates/shirabe/tests/repository/filesystem_repository_test.rs +++ b/crates/shirabe/tests/repository/filesystem_repository_test.rs @@ -1,40 +1,37 @@ //! ref: composer/tests/Composer/Test/Repository/FilesystemRepositoryTest.php -// These read/write installed.json and installed.php fixtures via JsonFile and assert the -// generated output; the file IO/manipulation (JsonManipulator reaches addcslashes, todo!()) -// and fixtures are not ported. #[test] -#[ignore = "reads/writes installed.json/installed.php fixtures via JsonFile/JsonManipulator (addcslashes todo!())"] +#[ignore = "test body not yet ported (todo!() stub)"] fn test_repository_read() { todo!() } #[test] -#[ignore = "reads/writes installed.json/installed.php fixtures via JsonFile/JsonManipulator (addcslashes todo!())"] +#[ignore = "test body not yet ported (todo!() stub)"] fn test_corrupted_repository_file() { todo!() } #[test] -#[ignore = "reads/writes installed.json/installed.php fixtures via JsonFile/JsonManipulator (addcslashes todo!())"] +#[ignore = "test body not yet ported (todo!() stub)"] fn test_unexistent_repository_file() { todo!() } #[test] -#[ignore = "reads/writes installed.json/installed.php fixtures via JsonFile/JsonManipulator (addcslashes todo!())"] +#[ignore = "test body not yet ported (todo!() stub)"] fn test_repository_write() { todo!() } #[test] -#[ignore = "reads/writes installed.json/installed.php fixtures via JsonFile/JsonManipulator (addcslashes todo!())"] +#[ignore = "test body not yet ported (todo!() stub)"] fn test_repository_writes_installed_php() { todo!() } #[test] -#[ignore = "reads/writes installed.json/installed.php fixtures via JsonFile/JsonManipulator (addcslashes todo!())"] +#[ignore = "test body not yet ported (todo!() stub)"] fn test_safely_load_installed_versions() { todo!() } -- cgit v1.3.1