From 37ed5b8c6d4cda30e668d0221eb281431dbc8c67 Mon Sep 17 00:00:00 2001 From: nsfisis Date: Mon, 20 Jul 2026 16:04:45 +0900 Subject: test(ignore): document root causes for unannotated #[ignore] tests 74 tests carried a bare #[ignore] with no explanation. Re-ran each: 25 now pass and had the attribute removed; the remaining 49 got a concise reason (todo!() stubs, regex-crate PCRE gaps, PhpMixed type mismatches, config bool-coercion bugs, missing skipped_load wiring in PoolBuilder, etc.) so future work can find and fix them by grep. No production code or test logic/assertions were changed. Co-Authored-By: Claude Sonnet 5 --- crates/shirabe/tests/util/auth_helper_test.rs | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) (limited to 'crates/shirabe/tests/util/auth_helper_test.rs') diff --git a/crates/shirabe/tests/util/auth_helper_test.rs b/crates/shirabe/tests/util/auth_helper_test.rs index 95cd3a2d..91d9cb75 100644 --- a/crates/shirabe/tests/util/auth_helper_test.rs +++ b/crates/shirabe/tests/util/auth_helper_test.rs @@ -583,7 +583,10 @@ fn test_store_auth_with_prompt_invalid_answer() { // same username/password IOStub already returns. Since getAuthentication is a static stub, that // looks like "no auth change" and AuthHelper raises a TransportException. #[test] -#[ignore] +#[ignore = "AuthHelper::prompt_auth_if_needed's in_gitlab_domains/in_github_domains checks call \ +PhpMixed::as_array(), which returns None for PhpMixed::List; Config's default gitlab-domains/\ +github-domains values are PhpMixed::List, so the domain match never fires and no GitLab-specific \ +TransportException is raised"] fn test_prompt_auth_if_needed_git_lab_no_auth_change() { use crate::io_stub::IOStub; use shirabe::downloader::TransportException; -- cgit v1.3.1