From 5ab5f3b316798c1411ce8e6a7f5b091fda93589c Mon Sep 17 00:00:00 2001 From: nsfisis Date: Mon, 22 Jun 2026 23:42:07 +0900 Subject: test: port previously-ignored Composer tests via __ test hatches Re-evaluate the reason'd #[ignore] tests under the Phase D criterion: a test is unportable ONLY if the APIs/types needed to WRITE it do not exist. A test that compiles but panics at runtime (todo!() body, a regex the regex crate cannot compile) or fails at runtime (incomplete or incorrect impl behavior) is portable -- it is written in full and marked with a reason-less #[ignore]. About 120 test functions move from reason'd #[ignore] to reason-less #[ignore] (the ported-but-not-yet-passing signal). Impl crates gain only additive __ test hatches (init_command, pool, file_downloader, package handle link setters, artifact/path repository, repository manager, svn); no existing logic changes. Tests whose required APIs genuinely do not exist (mock/reflection harness, ApplicationTester, solve() discarding SolverProblemsException, a script::Event that cannot be passed as an originating event) keep their reason'd #[ignore]. cargo check -p shirabe --tests passes. Co-Authored-By: Claude Opus 4.8 (1M context) --- crates/shirabe/tests/util/config_validator_test.rs | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) (limited to 'crates/shirabe/tests/util/config_validator_test.rs') diff --git a/crates/shirabe/tests/util/config_validator_test.rs b/crates/shirabe/tests/util/config_validator_test.rs index da962e0..2e4aed0 100644 --- a/crates/shirabe/tests/util/config_validator_test.rs +++ b/crates/shirabe/tests/util/config_validator_test.rs @@ -29,7 +29,7 @@ fn validate(file: &str) -> Vec { /// Test ConfigValidator warns on commit reference #[test] -#[ignore = "ConfigValidator::validate reaches a todo!() in the php-shim"] +#[ignore] fn test_config_validator_commit_ref_warning() { let warnings = validate(&fixture("composer_commit-ref.json")); @@ -39,7 +39,7 @@ fn test_config_validator_commit_ref_warning() { } #[test] -#[ignore = "ConfigValidator::validate reaches a todo!() in the php-shim"] +#[ignore] fn test_config_validator_warns_on_script_description_for_nonexistent_script() { let warnings = validate(&fixture("composer_scripts-descriptions.json")); @@ -52,7 +52,7 @@ fn test_config_validator_warns_on_script_description_for_nonexistent_script() { } #[test] -#[ignore = "ConfigValidator::validate reaches a todo!() in the php-shim"] +#[ignore] fn test_config_validator_warns_on_script_alias_for_nonexistent_script() { let warnings = validate(&fixture("composer_scripts-aliases.json")); @@ -62,7 +62,7 @@ fn test_config_validator_warns_on_script_alias_for_nonexistent_script() { } #[test] -#[ignore = "ConfigValidator::validate reaches a todo!() in the php-shim"] +#[ignore] fn test_config_validator_warns_on_unnecessary_provide_replace() { let warnings = validate(&fixture("composer_provide-replace-requirements.json")); -- cgit v1.3.1