From dfd98ce4b227a3a14dc913c669bee4f077a65178 Mon Sep 17 00:00:00 2001 From: nsfisis Date: Sun, 9 Aug 2026 09:34:34 +0900 Subject: refactor(php-shim): make the fs mutators return Result mkdir, rmdir, unlink and symlink each had a bool version and a _result twin returning the io::Error, which left two names for one call. Keep only the Result form and let the callers that want a boolean spell out .is_ok(). Call sites that discard the outcome, as their PHP originals do, are unchanged. Co-Authored-By: Claude Opus 5 (1M context) --- crates/shirabe/tests/util/filesystem_test.rs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'crates/shirabe/tests/util/filesystem_test.rs') diff --git a/crates/shirabe/tests/util/filesystem_test.rs b/crates/shirabe/tests/util/filesystem_test.rs index 5bb44598..b217a342 100644 --- a/crates/shirabe/tests/util/filesystem_test.rs +++ b/crates/shirabe/tests/util/filesystem_test.rs @@ -512,7 +512,7 @@ fn test_unlink_symlinked_directory() { mkdir(format!("{basepath}/real"), 0o777, true); touch(format!("{basepath}/real/FILE")); - let result = symlink(format!("{basepath}/real"), &symlinked); + let result = symlink(format!("{basepath}/real"), &symlinked).is_ok(); if !result { // Symbolic links for directories not supported on this platform. @@ -539,7 +539,7 @@ fn test_remove_symlinked_directory_with_trailing_slash() { let symlinked = format!("{working_dir}/linked"); let symlinked_trailing_slash = format!("{symlinked}/"); - let result = symlink(format!("{working_dir}/real"), &symlinked); + let result = symlink(format!("{working_dir}/real"), &symlinked).is_ok(); if !result { // Symbolic links for directories not supported on this platform. -- cgit v1.3.1-4-g156e