From 37ed5b8c6d4cda30e668d0221eb281431dbc8c67 Mon Sep 17 00:00:00 2001 From: nsfisis Date: Mon, 20 Jul 2026 16:04:45 +0900 Subject: test(ignore): document root causes for unannotated #[ignore] tests 74 tests carried a bare #[ignore] with no explanation. Re-ran each: 25 now pass and had the attribute removed; the remaining 49 got a concise reason (todo!() stubs, regex-crate PCRE gaps, PhpMixed type mismatches, config bool-coercion bugs, missing skipped_load wiring in PoolBuilder, etc.) so future work can find and fix them by grep. No production code or test logic/assertions were changed. Co-Authored-By: Claude Sonnet 5 --- crates/shirabe/tests/util/http/proxy_manager_test.rs | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) (limited to 'crates/shirabe/tests/util/http/proxy_manager_test.rs') diff --git a/crates/shirabe/tests/util/http/proxy_manager_test.rs b/crates/shirabe/tests/util/http/proxy_manager_test.rs index d37a1fd8..4383978d 100644 --- a/crates/shirabe/tests/util/http/proxy_manager_test.rs +++ b/crates/shirabe/tests/util/http/proxy_manager_test.rs @@ -64,7 +64,7 @@ fn test_instantiation() { } #[test] -#[ignore] +#[ignore = "not #[serial_test::serial] like test_instantiation; races on the process-wide HTTP_PROXY/etc env vars and the ProxyManager::INSTANCE mutex when run in parallel with the other proxy_manager_test tests, causing spurious PoisonError panics"] fn test_get_proxy_for_request_throws_on_bad_proxy_url() { let _tear_down = TearDown; set_up(); @@ -82,7 +82,7 @@ fn test_get_proxy_for_request_throws_on_bad_proxy_url() { } #[test] -#[ignore] +#[ignore = "not #[serial_test::serial] like test_instantiation; races on the process-wide HTTP_PROXY/etc env vars and the ProxyManager::INSTANCE mutex when run in parallel with the other proxy_manager_test tests, causing spurious PoisonError panics"] fn test_lowercase_overrides_uppercase() { let _tear_down = TearDown; set_up(); @@ -129,7 +129,7 @@ fn test_lowercase_overrides_uppercase() { } #[test] -#[ignore] +#[ignore = "not #[serial_test::serial] like test_instantiation; races on the process-wide HTTP_PROXY/etc env vars and the ProxyManager::INSTANCE mutex when run in parallel with the other proxy_manager_test tests, causing spurious PoisonError panics"] fn test_cgi_proxy_is_only_used_when_no_http_proxy() { let _tear_down = TearDown; set_up(); @@ -167,7 +167,7 @@ fn test_cgi_proxy_is_only_used_when_no_http_proxy() { } #[test] -#[ignore] +#[ignore = "not #[serial_test::serial] like test_instantiation; races on the process-wide HTTP_PROXY/etc env vars and the ProxyManager::INSTANCE mutex when run in parallel with the other proxy_manager_test tests, causing spurious PoisonError panics"] fn test_no_http_proxy_does_not_use_https_proxy() { let _tear_down = TearDown; set_up(); @@ -184,7 +184,7 @@ fn test_no_http_proxy_does_not_use_https_proxy() { } #[test] -#[ignore] +#[ignore = "not #[serial_test::serial] like test_instantiation; races on the process-wide HTTP_PROXY/etc env vars and the ProxyManager::INSTANCE mutex when run in parallel with the other proxy_manager_test tests, causing spurious PoisonError panics"] fn test_no_https_proxy_does_not_use_http_proxy() { let _tear_down = TearDown; set_up(); @@ -201,7 +201,7 @@ fn test_no_https_proxy_does_not_use_http_proxy() { } #[test] -#[ignore] +#[ignore = "not #[serial_test::serial] like test_instantiation; races on the process-wide HTTP_PROXY/etc env vars and the ProxyManager::INSTANCE mutex when run in parallel with the other proxy_manager_test tests, causing spurious PoisonError panics"] fn test_get_proxy_for_request() { use indexmap::IndexMap; use shirabe_php_shim::PhpMixed; -- cgit v1.3.1