From f691b864b687f251c3b266e8cff2774d730567ba Mon Sep 17 00:00:00 2001 From: nsfisis Date: Sun, 21 Jun 2026 21:25:15 +0900 Subject: test(php-shim): un-ignore tests now unblocked by implemented shims Remove #[ignore] from tests gated solely on a shim function that is now implemented, where the test passes: - metapackage_installer::test_update (version_compare) - platform_requirement_filter_factory::test_from_bool_throws... (get_debug_type) - runtime::test_parse_extension_info (html_entity_decode/strip_tags) - package_sorter::test_sorting_does_nothing... (strnatcasecmp) - no_proxy_pattern::test_host_name/test_port (unpack/substr_count) - version_parser::test_is_upgrade (version_compare) - pool::test_what_provides_package_with_constraint - proxy_item::test_throws_on_malformed_url Update the ignore reason where the cited shim is now implemented but the test still cannot pass for a different reason: - no_proxy_pattern::test_ip_address/test_ip_range (IPv4-mapped IPv6 gap) - package_sorter::test_sorting_orders... (look-around regex) - proxy_item::test_url_formatting (parse_url host discrepancy) - json_manipulator/json_config_source/filesystem_repository stubs (test bodies are still todo!(), not yet ported) Co-Authored-By: Claude Opus 4.8 (1M context) --- crates/shirabe/tests/util/http/proxy_item_test.rs | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) (limited to 'crates/shirabe/tests/util/http') diff --git a/crates/shirabe/tests/util/http/proxy_item_test.rs b/crates/shirabe/tests/util/http/proxy_item_test.rs index 0607bd5..a8c0438 100644 --- a/crates/shirabe/tests/util/http/proxy_item_test.rs +++ b/crates/shirabe/tests/util/http/proxy_item_test.rs @@ -3,7 +3,6 @@ use shirabe::util::http::proxy_item::ProxyItem; #[test] -#[ignore = "ProxyItem::new reaches a todo!() in the php-shim"] fn test_throws_on_malformed_url() { for url in data_malformed() { assert!(ProxyItem::new(url.to_string(), "http_proxy".to_string()).is_err()); @@ -30,7 +29,7 @@ fn data_malformed() -> Vec<&'static str> { } #[test] -#[ignore = "ProxyItem::new reaches a todo!() in the php-shim"] +#[ignore = "URL parsing yields no host for these cases, so proxy formatting fails (parse_url/port discrepancy)"] fn test_url_formatting() { for (url, expected) in data_formatting() { let proxy_item = ProxyItem::new(url.to_string(), "http_proxy".to_string()).unwrap(); -- cgit v1.3.1