From 5ab5f3b316798c1411ce8e6a7f5b091fda93589c Mon Sep 17 00:00:00 2001
From: nsfisis <nsfisis@gmail.com>
Date: Mon, 22 Jun 2026 23:42:07 +0900
Subject: test: port previously-ignored Composer tests via __ test hatches

Re-evaluate the reason'd #[ignore] tests under the Phase D criterion:
a test is unportable ONLY if the APIs/types needed to WRITE it do not
exist. A test that compiles but panics at runtime (todo!() body, a
regex the regex crate cannot compile) or fails at runtime (incomplete
or incorrect impl behavior) is portable -- it is written in full and
marked with a reason-less #[ignore].

About 120 test functions move from reason'd #[ignore] to reason-less
#[ignore] (the ported-but-not-yet-passing signal). Impl crates gain
only additive __ test hatches (init_command, pool, file_downloader,
package handle link setters, artifact/path repository, repository
manager, svn); no existing logic changes. Tests whose required APIs
genuinely do not exist (mock/reflection harness, ApplicationTester,
solve() discarding SolverProblemsException, a script::Event that
cannot be passed as an originating event) keep their reason'd
#[ignore].

cargo check -p shirabe --tests passes.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
---
 crates/shirabe/tests/util/zip_test.rs | 16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)

(limited to 'crates/shirabe/tests/util/zip_test.rs')

diff --git a/crates/shirabe/tests/util/zip_test.rs b/crates/shirabe/tests/util/zip_test.rs
index b80dd17..4d883e0 100644
--- a/crates/shirabe/tests/util/zip_test.rs
+++ b/crates/shirabe/tests/util/zip_test.rs
@@ -18,7 +18,7 @@ fn test_throws_exception_if_zip_extension_is_not_loaded() {
 }
 
 #[test]
-#[ignore = "ZipArchive::new is todo!() in the php-shim"]
+#[ignore]
 fn test_returns_nullif_the_zip_is_not_found() {
     let result = Zip::get_composer_json(&fixture("invalid.zip")).unwrap();
 
@@ -26,7 +26,7 @@ fn test_returns_nullif_the_zip_is_not_found() {
 }
 
 #[test]
-#[ignore = "ZipArchive::new is todo!() in the php-shim"]
+#[ignore]
 fn test_returns_null_if_the_zip_is_empty() {
     let result = Zip::get_composer_json(&fixture("empty.zip")).unwrap();
 
@@ -34,19 +34,19 @@ fn test_returns_null_if_the_zip_is_empty() {
 }
 
 #[test]
-#[ignore = "ZipArchive::new is todo!() in the php-shim"]
+#[ignore]
 fn test_throws_exception_if_the_zip_has_no_composer_json() {
     assert!(Zip::get_composer_json(&fixture("nojson.zip")).is_err());
 }
 
 #[test]
-#[ignore = "ZipArchive::new is todo!() in the php-shim"]
+#[ignore]
 fn test_throws_exception_if_the_composer_json_is_in_a_sub_subfolder() {
     assert!(Zip::get_composer_json(&fixture("subfolders.zip")).is_err());
 }
 
 #[test]
-#[ignore = "ZipArchive::new is todo!() in the php-shim"]
+#[ignore]
 fn test_returns_composer_json_in_zip_root() {
     let result = Zip::get_composer_json(&fixture("root.zip")).unwrap();
 
@@ -57,7 +57,7 @@ fn test_returns_composer_json_in_zip_root() {
 }
 
 #[test]
-#[ignore = "ZipArchive::new is todo!() in the php-shim"]
+#[ignore]
 fn test_returns_composer_json_in_first_folder() {
     let result = Zip::get_composer_json(&fixture("folder.zip")).unwrap();
 
@@ -68,13 +68,13 @@ fn test_returns_composer_json_in_first_folder() {
 }
 
 #[test]
-#[ignore = "ZipArchive::new is todo!() in the php-shim"]
+#[ignore]
 fn test_multiple_top_level_dirs_is_invalid() {
     assert!(Zip::get_composer_json(&fixture("multiple.zip")).is_err());
 }
 
 #[test]
-#[ignore = "ZipArchive::new is todo!() in the php-shim"]
+#[ignore]
 fn test_returns_composer_json_from_first_subfolder() {
     let result = Zip::get_composer_json(&fixture("single-sub.zip")).unwrap();
 
-- 
cgit v1.3.1