From 494f79d0caf614325408d82d5c7a58f9e4396590 Mon Sep 17 00:00:00 2001 From: nsfisis Date: Sun, 16 Aug 2026 16:26:21 +0900 Subject: test: correct stale #[ignore] reasons Running the ignored tests shows several reasons naming a blocker the test never reaches. The plugin hooks in all_functional_test do run, and what stops both cases is the worker's Composer\InstalledVersions; class_loader_test stops at include_file, not class_exists; auth_helper_test's wrapper is ported and the blocker is trigger_error; composerRequire is ported as __shirabe_composer_require. Co-Authored-By: Claude Opus 5 (1M context) --- crates/shirabe/tests/util/auth_helper_test.rs | 17 +++++++++-------- 1 file changed, 9 insertions(+), 8 deletions(-) (limited to 'crates/shirabe/tests/util') diff --git a/crates/shirabe/tests/util/auth_helper_test.rs b/crates/shirabe/tests/util/auth_helper_test.rs index 102a798c..732c8881 100644 --- a/crates/shirabe/tests/util/auth_helper_test.rs +++ b/crates/shirabe/tests/util/auth_helper_test.rs @@ -803,20 +803,21 @@ fn test_add_authentication_header_with_custom_headers() { } #[test] -#[ignore = "exercises the deprecated addAuthenticationHeader wrapper (not ported) which relies on \ -trigger_error/E_USER_DEPRECATED; the PHP error-handler subsystem is not modeled"] +#[ignore = "exercises the deprecated addAuthenticationHeader wrapper, which opens with \ +trigger_error(E_USER_DEPRECATED); shirabe_php_shim::trigger_error is a todo!()"] fn test_add_authentication_header_is_working() { - // TODO(php-runtime): see test_add_authentication_header_with_custom_headers above — same - // unported addAuthenticationHeader deprecated wrapper. + // TODO(php-runtime): see test_add_authentication_header_with_custom_headers above — the same + // trigger_error(E_USER_DEPRECATED) that opens addAuthenticationHeader. todo!() } #[test] -#[ignore = "exercises the deprecated addAuthenticationHeader wrapper (not ported) which relies on \ -trigger_error/E_USER_DEPRECATED converted to a RuntimeException via set_error_handler; not modeled"] +#[ignore = "asserts that the deprecated addAuthenticationHeader wrapper raises a RuntimeException \ +through a set_error_handler converting E_USER_DEPRECATED; shirabe_php_shim::trigger_error is a \ +todo!() and set_error_handler is a no-op"] fn test_add_authentication_header_deprecation() { // TODO(php-runtime): asserts that calling addAuthenticationHeader itself raises a - // RuntimeException via a custom set_error_handler converting E_USER_DEPRECATED; same - // unported wrapper and unmodeled error-handler subsystem as the two tests above. + // RuntimeException via a custom set_error_handler converting E_USER_DEPRECATED; the same + // trigger_error todo!() and unmodeled error-handler subsystem as the two tests above. todo!() } -- cgit v1.3.1-4-g156e