From 3d4a0cadc950d4440251efa11b55b0bfb0afdef7 Mon Sep 17 00:00:00 2001 From: nsfisis Date: Thu, 6 Aug 2026 04:22:46 +0900 Subject: chore: drop @param/@return tags that only restate Rust types The ported docblocks copied @param and @return straight from the PHP source. When such a tag carries nothing but a type and an argument name, the Rust signature already states it, so the line is noise. Tags whose text adds prose beyond the type are kept. Co-Authored-By: Claude Opus 5 (1M context) --- crates/shirabe/tests/command/init_command_test.rs | 3 --- crates/shirabe/tests/question/strict_confirmation_question_test.rs | 4 ---- 2 files changed, 7 deletions(-) (limited to 'crates/shirabe/tests') diff --git a/crates/shirabe/tests/command/init_command_test.rs b/crates/shirabe/tests/command/init_command_test.rs index 914680fb..e82f2bd7 100644 --- a/crates/shirabe/tests/command/init_command_test.rs +++ b/crates/shirabe/tests/command/init_command_test.rs @@ -53,7 +53,6 @@ fn opt_list(name: &str, values: &[&str]) -> (PhpMixed, PhpMixed) { ) } -/// @return iterable fn valid_author_string_provider() -> Vec<(&'static str, Option<&'static str>, &'static str)> { vec![ // simple @@ -159,7 +158,6 @@ fn test_namespace_from_missing_package_name() { assert_eq!(None, namespace); } -/// @return iterable, 1: array}> fn run_data_provider() -> Vec<(serde_json::Value, Vec<(PhpMixed, PhpMixed)>)> { vec![ // name argument @@ -384,7 +382,6 @@ enum InvalidExpectation { StderrMatches(&'static str), } -/// @return iterable|null, 1: string|null, 2: array}> fn run_invalid_data_provider() -> Vec<(InvalidExpectation, Vec<(PhpMixed, PhpMixed)>)> { vec![ // invalid name argument diff --git a/crates/shirabe/tests/question/strict_confirmation_question_test.rs b/crates/shirabe/tests/question/strict_confirmation_question_test.rs index 916daad1..f7f79eb6 100644 --- a/crates/shirabe/tests/question/strict_confirmation_question_test.rs +++ b/crates/shirabe/tests/question/strict_confirmation_question_test.rs @@ -13,7 +13,6 @@ use shirabe_php_shim::PhpMixed; const TRUE_ANSWER_REGEX: &str = "/^y(?:es)?$/i"; const FALSE_ANSWER_REGEX: &str = "/^no?$/i"; -/// @return string[][] fn get_ask_confirmation_bad_data() -> Vec<&'static str> { vec!["not correct", "no more", "yes please", "yellow"] } @@ -61,7 +60,6 @@ fn test_ask_confirmation() { } } -/// @return mixed[][] fn get_ask_confirmation_data() -> Vec<(&'static str, bool, bool)> { vec![ ("", true, true), @@ -101,7 +99,6 @@ fn test_ask_confirmation_with_custom_true_and_false_answer() { ); } -/// @return resource fn get_input_stream(input: &str) -> shirabe_php_shim::PhpResource { let stream = shirabe_php_shim::php_fopen_resource("php://memory", "r+"); @@ -119,7 +116,6 @@ fn create_output_interface() -> std::rc::Rc (ArrayInput, QuestionHelper) { let mut input = ArrayInput::new( vec![( -- cgit v1.3.1