From 4fa973840f0a0e2cbb16f5e3341c0625793af2ed Mon Sep 17 00:00:00 2001 From: nsfisis Date: Sun, 2 Aug 2026 05:56:56 +0900 Subject: refactor(php-shim): drop pack/unpack in favor of direct byte handling The only callers were trivial fixed-format uses: reading the first four hash bytes as a native int, splitting in_addr byte strings, and building a constant ZIP EOCD record. Each site now does the byte manipulation directly, so the general-purpose shims are no longer needed. Co-Authored-By: Claude Fable 5 --- crates/shirabe/tests/dependency_resolver/rule_test.rs | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) (limited to 'crates/shirabe/tests') diff --git a/crates/shirabe/tests/dependency_resolver/rule_test.rs b/crates/shirabe/tests/dependency_resolver/rule_test.rs index 6bfb7bd1..9526bf39 100644 --- a/crates/shirabe/tests/dependency_resolver/rule_test.rs +++ b/crates/shirabe/tests/dependency_resolver/rule_test.rs @@ -7,7 +7,7 @@ use shirabe::dependency_resolver::{ }; use shirabe::package::Link; use shirabe::repository::RepositorySet; -use shirabe_php_shim::{PHP_VERSION_ID, hash_raw, unpack}; +use shirabe_php_shim::{PHP_VERSION_ID, hash_raw}; use shirabe_semver::constraint::MatchAllConstraint; fn root_require_reason() -> ReasonData { @@ -35,12 +35,9 @@ fn test_get_hash() { "sha1" }; let binary = hash_raw(algo, "123"); - let hash = unpack("ihash", &binary).unwrap(); + let hash = i32::from_ne_bytes(binary[..4].try_into().unwrap()) as i64; - assert_eq!( - hash.get("hash").unwrap().as_int(), - rule.get_hash().unwrap().as_int() - ); + assert_eq!(Some(hash), rule.get_hash().unwrap().as_int()); } #[test] -- cgit v1.3.1