From 63a77b1495944ad9707fe036a73f99eaec189897 Mon Sep 17 00:00:00 2001 From: nsfisis Date: Mon, 20 Jul 2026 07:00:08 +0900 Subject: test(zip): detail why the zip-extension test stays ignored PHP only runs this test when the zip extension is not loaded; the Rust port has unconditional zip support, so that precondition cannot exist. Co-Authored-By: Claude Fable 5 --- crates/shirabe/tests/util/zip_test.rs | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) (limited to 'crates/shirabe/tests') diff --git a/crates/shirabe/tests/util/zip_test.rs b/crates/shirabe/tests/util/zip_test.rs index 0c7d96a1..e3e976de 100644 --- a/crates/shirabe/tests/util/zip_test.rs +++ b/crates/shirabe/tests/util/zip_test.rs @@ -11,8 +11,12 @@ fn fixture(name: &str) -> String { ) } +// TODO(phase-d): PHP runs this test only when the zip extension is NOT loaded (it is +// markTestSkipped otherwise). The Rust port links zip support unconditionally, so the +// "extension not loaded" precondition cannot exist and the expected RuntimeException +// ("The Zip Util requires PHP's zip extension") is unreachable by design. #[test] -#[ignore = "skipped in PHP whenever the zip extension is loaded, which it always is here"] +#[ignore = "requires a PHP runtime without the zip extension; the Rust port has unconditional zip support, so this precondition is impossible to reproduce"] fn test_throws_exception_if_zip_extension_is_not_loaded() { assert!(Zip::get_composer_json("").is_err()); } -- cgit v1.3.1