From 72cbecaec29cecc723ce29c87d10048114aeef5b Mon Sep 17 00:00:00 2001 From: nsfisis Date: Sun, 9 Aug 2026 18:33:14 +0900 Subject: feat(symfony-filesystem): finish the Filesystem port and trim its API doRemove() renames a directory to a random hidden name before emptying it, and undoes that rename when the final rmdir fails, so a concurrent process cannot recreate the path mid-removal. It also walks one level at a time through FilesystemIterator instead of flattening the whole tree, and lets an inner rmdir failure pass, both as upstream does. copy() keeps the mode fopen($targetFile, 'w') would have left rather than the origin's, symlink() and mirror() call readlink() and getLinkTarget() where upstream does, and a directory iterator that cannot be opened propagates its UnexpectedValueException instead of being swallowed or flattened into an IOException. Error message text is out of scope per docs/known-incompatibilities.md, so the three TODO(phase-c) markers that only tracked wording are gone, along with linkException()'s Windows-only branch. So are the arguments no caller varies -- symlink()'s copyOnWindows, mirror()'s iterator and options, copy()'s overwriteNewerFiles -- which removes the last TODO(phase-c) in the file. New shim functions: readlink, filesystem_iterator, stream_is_local, strrev and SplFileInfo::getLinkTarget. base64_encode takes bytes so random_bytes() can feed it. Co-Authored-By: Claude Opus 5 (1M context) --- crates/shirabe/tests/util/auth_helper_test.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'crates/shirabe/tests') diff --git a/crates/shirabe/tests/util/auth_helper_test.rs b/crates/shirabe/tests/util/auth_helper_test.rs index 6b376f97..2f2feb23 100644 --- a/crates/shirabe/tests/util/auth_helper_test.rs +++ b/crates/shirabe/tests/util/auth_helper_test.rs @@ -340,7 +340,7 @@ fn add_authentication_header_with_basic_http_authentication( let expected = format!( "Authorization: Basic {}", - base64_encode(&format!("{}:{}", username, password)) + base64_encode(format!("{}:{}", username, password)) ); let options = f -- cgit v1.3.1-4-g156e