From 76c6d132fbc8341bdf14537bba7f00b073eddbc1 Mon Sep 17 00:00:00 2001 From: nsfisis Date: Fri, 24 Jul 2026 20:23:12 +0900 Subject: fix(package): rewrite dist-reference SHA regex without look-around Package::set_source_dist_references and LockTransaction's dist-url mirroring both used {(?<=/|sha=)[a-f0-9]{40}(?=/|$)}i, but the regex crate has no look-around support at all and panics compiling it. Per docs/dev/regex-porting.md, rewrote the boundary assertions into capturing groups and switched to Preg::replace_callback, which re-emits the captured delimiters around the replaced reference. --- crates/shirabe/tests/installer_test.rs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'crates/shirabe/tests') diff --git a/crates/shirabe/tests/installer_test.rs b/crates/shirabe/tests/installer_test.rs index 13e4fc28..2a0c4872 100644 --- a/crates/shirabe/tests/installer_test.rs +++ b/crates/shirabe/tests/installer_test.rs @@ -1502,7 +1502,7 @@ pool_optimizer_test! { pool_optimizer_update_allow_list_with_dependencies => "update-allow-list-with-dependencies.test"; pool_optimizer_update_allow_list_with_dependency_conflict => "update-allow-list-with-dependency-conflict.test"; pool_optimizer_update_allow_list => "update-allow-list.test"; - pool_optimizer_update_changes_url => "update-changes-url.test", ignore = "TODO(phase-d): known-failing fixture under COMPOSER_POOL_OPTIMIZER=1"; + pool_optimizer_update_changes_url => "update-changes-url.test"; pool_optimizer_update_dev_ignores_providers => "update-dev-ignores-providers.test"; pool_optimizer_update_dev_packages_updates_repo_url => "update-dev-packages-updates-repo-url.test"; pool_optimizer_update_dev_to_new_ref_picks_up_changes => "update-dev-to-new-ref-picks-up-changes.test"; @@ -1692,7 +1692,7 @@ raw_pool_test! { raw_pool_update_allow_list_with_dependencies => "update-allow-list-with-dependencies.test"; raw_pool_update_allow_list_with_dependency_conflict => "update-allow-list-with-dependency-conflict.test"; raw_pool_update_allow_list => "update-allow-list.test"; - raw_pool_update_changes_url => "update-changes-url.test", ignore = "TODO(phase-d): known-failing fixture under COMPOSER_POOL_OPTIMIZER=0"; + raw_pool_update_changes_url => "update-changes-url.test"; raw_pool_update_dev_ignores_providers => "update-dev-ignores-providers.test"; raw_pool_update_dev_packages_updates_repo_url => "update-dev-packages-updates-repo-url.test"; raw_pool_update_dev_to_new_ref_picks_up_changes => "update-dev-to-new-ref-picks-up-changes.test"; -- cgit v1.3.1