From 7e84d9ea31584e0dc04f04d14f6905ab9d978c72 Mon Sep 17 00:00:00 2001 From: nsfisis Date: Sun, 19 Jul 2026 17:15:50 +0900 Subject: fix(alias-package): stop delegating own-state accessors to aliasOf AliasPackage wrongly delegated several methods (id, names, unique name, pretty string, full pretty version, repository, __toString) to aliasOf, but PHP's AliasPackage inherits these from BasePackage unmodified, so they must use the alias's own state instead. This collapsed alias and aliasOf into the same SAT literal id, breaking the solver's alias-resolution rules; un-ignore the two solver tests that exposed it. --- crates/shirabe/tests/dependency_resolver/solver_test.rs | 2 -- 1 file changed, 2 deletions(-) (limited to 'crates/shirabe/tests') diff --git a/crates/shirabe/tests/dependency_resolver/solver_test.rs b/crates/shirabe/tests/dependency_resolver/solver_test.rs index b8be2287..7a507da3 100644 --- a/crates/shirabe/tests/dependency_resolver/solver_test.rs +++ b/crates/shirabe/tests/dependency_resolver/solver_test.rs @@ -2154,7 +2154,6 @@ fn test_learn_literals_with_sorted_rule_literals() { ); } -#[ignore = "solver emits fewer operations than PHP for recursive aliasOf deps: expects install b + install a + markAliasInstalled a, but only install a is produced; real solver alias-resolution discrepancy, not a stub"] #[test] fn test_install_recursive_alias_dependencies() { let fixtures = set_up(); @@ -2273,7 +2272,6 @@ fn test_install_dev_alias() { ); } -#[ignore = "solver omits the leading markAliasInstalled for an already-installed package's root alias (expects markAliasInstalled a after install a); real solver alias-resolution discrepancy, not a stub"] #[test] fn test_install_root_aliases_if_alias_of_is_installed() { let fixtures = set_up(); -- cgit v1.3.1