From 8c4dc6cd48457f154eb067f296d79ef911573c91 Mon Sep 17 00:00:00 2001 From: nsfisis Date: Fri, 26 Jun 2026 02:26:08 +0900 Subject: fix(check-platform-reqs-command): add PlatformRepository to existing composite execute nested the already-built InstalledRepository inside a second InstalledRepository, tripping the assertion that an InstalledRepository may not contain another. PHP adds a PlatformRepository to the existing composite via addRepository; do the same. Un-ignores CheckPlatformReqsCommandTest::test_failed_platform_requirement. Co-Authored-By: Claude Opus 4.8 (1M context) --- .../shirabe/tests/command/check_platform_reqs_command_test.rs | 11 +---------- 1 file changed, 1 insertion(+), 10 deletions(-) (limited to 'crates/shirabe/tests') diff --git a/crates/shirabe/tests/command/check_platform_reqs_command_test.rs b/crates/shirabe/tests/command/check_platform_reqs_command_test.rs index 1e19259..a9196b7 100644 --- a/crates/shirabe/tests/command/check_platform_reqs_command_test.rs +++ b/crates/shirabe/tests/command/check_platform_reqs_command_test.rs @@ -48,11 +48,7 @@ fn run_platform_reqs_are_satisfied_case( #[test] #[serial] -#[ignore = "src porting bug: check_platform_reqs_command.rs:288-294 wraps the existing \ - InstalledRepository inside a SECOND InstalledRepository (instead of PHP line 89 \ - `$installedRepo->addRepository(new PlatformRepository(...))`), tripping the \ - add_repository assertion at installed_repository.rs:367 (\"An InstalledRepository can \ - not contain a repository of type installed repo ...\"). Cannot fix from test files."] +#[ignore = "reaches a RefCell re-entrancy panic at crates/shirabe/src/downloader/file_downloader.rs:136 (\"RefCell already borrowed\") on the platform-package resolution path; src borrow bug, not fixable from the test"] fn test_platform_reqs_are_satisfied() { // 'Disables checking of require-dev packages requirements.' run_platform_reqs_are_satisfied_case( @@ -105,11 +101,6 @@ fn test_exception_thrown_if_no_lockfile_found() { #[test] #[serial] -#[ignore = "src porting bug: check_platform_reqs_command.rs:288-294 wraps the existing \ - InstalledRepository inside a SECOND InstalledRepository (instead of PHP line 89 \ - `$installedRepo->addRepository(new PlatformRepository(...))`), tripping the \ - add_repository assertion at installed_repository.rs:367 (\"An InstalledRepository can \ - not contain a repository of type installed repo ...\"). Cannot fix from test files."] fn test_failed_platform_requirement() { let tear_down = init_temp_composer( Some(&serde_json::json!({ -- cgit v1.3.1