From c854041bfca63f39ace6f0c01892e81889f90bb3 Mon Sep 17 00:00:00 2001 From: nsfisis Date: Sat, 20 Jun 2026 14:24:48 +0900 Subject: fix(global-command): call base_run to stop run() infinite recursion GlobalCommand::run fell back to self.run when given fewer than two args, recursing forever and overflowing the stack. PHP calls parent::run there. Add Command::base_run holding the base run body so the override can delegate to it, matching PHP's parent::run. Co-Authored-By: Claude Opus 4.8 (1M context) --- crates/shirabe/tests/cli.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'crates/shirabe/tests') diff --git a/crates/shirabe/tests/cli.rs b/crates/shirabe/tests/cli.rs index 549e5a3..196e93b 100644 --- a/crates/shirabe/tests/cli.rs +++ b/crates/shirabe/tests/cli.rs @@ -149,7 +149,7 @@ run_no_panic_tests! { run_exec => "exec", #[ignore = "currently panics"] run_fund => "fund", - #[ignore = "stack overflow aborts the process (uncatchable)"] + #[ignore = "currently panics"] run_global => "global", #[ignore = "currently panics"] run_init => "init", -- cgit v1.3.1