From cd7c3fce2472656b2a1247429751e43350976677 Mon Sep 17 00:00:00 2001 From: nsfisis Date: Wed, 19 Aug 2026 23:45:38 +0900 Subject: perf(package): hand out link maps behind Rc PackageInterface::getRequires() and friends return the array of Link objects; in PHP that is a copy-on-write array of object references, so a caller pays nothing to look at it. The port returned IndexMap by value, so every call deep-cloned the whole map, keys and constraints included. Pool building calls these accessors once per package per candidate, which put IndexMap::clone at 13.5% of `require laravel/laravel`. Store the maps as Rc> and return a handle. Callers that mutate the map clone it explicitly at the point of mutation, matching where PHP would separate the array. Co-Authored-By: Claude Opus 5 (1M context) --- crates/shirabe/tests/repository/platform_repository_test.rs | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) (limited to 'crates/shirabe/tests') diff --git a/crates/shirabe/tests/repository/platform_repository_test.rs b/crates/shirabe/tests/repository/platform_repository_test.rs index c16f3a3e..03c27750 100644 --- a/crates/shirabe/tests/repository/platform_repository_test.rs +++ b/crates/shirabe/tests/repository/platform_repository_test.rs @@ -1587,7 +1587,7 @@ fn assert_package_links( context: &str, expected_links: &[&str], source_package: &BasePackageHandle, - links: IndexMap, + links: &IndexMap, ) { assert_eq!( expected_links.len(), @@ -1707,13 +1707,13 @@ fn test_library_information() { "replaces", expected_replaces, &package, - package.get_replaces(), + &package.get_replaces(), ); assert_package_links( "provides", expected_provides, &package, - package.get_provides(), + &package.get_provides(), ); } } -- cgit v1.3.1-4-g156e