From dee7a8ad1ba80eafee746a6af2bfec578ca60d4e Mon Sep 17 00:00:00 2001 From: nsfisis Date: Sat, 18 Jul 2026 01:07:23 +0900 Subject: fix(require-command): avoid unsupported regex lookahead in dev-branch check The `regex` crate does not support negative lookahead, so the ported `^dev-(?!main$|master$|trunk$|latest$)` pattern panicked at runtime on any `require` invocation that reached version-selection. Replace it with equivalent hand-written string logic per docs/dev/regex-porting.md. --- crates/shirabe/tests/command/require_command_test.rs | 4 ---- 1 file changed, 4 deletions(-) (limited to 'crates/shirabe/tests') diff --git a/crates/shirabe/tests/command/require_command_test.rs b/crates/shirabe/tests/command/require_command_test.rs index e6186505..b132eb43 100644 --- a/crates/shirabe/tests/command/require_command_test.rs +++ b/crates/shirabe/tests/command/require_command_test.rs @@ -340,10 +340,6 @@ fn provide_inconsistent_require_keys() -> Vec<(bool, bool, &'static str)> { #[test] #[serial] -#[ignore = "the solver-pool root-package issue is fixed; now panics in shirabe_php_shim::preg \ - (\"look-around, including look-ahead and look-behind, is not supported\") because \ - the dev-branch pattern `^dev-(?!main$|master$|trunk$|latest$)` uses a lookahead the \ - `regex` crate cannot express (see docs/dev/regex-porting.md)"] fn test_inconsistent_require_keys() { for (is_dev, is_interactive, expected_warning) in provide_inconsistent_require_keys() { let current_key = if is_dev { "require" } else { "require-dev" }; -- cgit v1.3.1