From eab3a31c5750013c53c0eb02adc976d6757dc9f7 Mon Sep 17 00:00:00 2001 From: nsfisis Date: Thu, 2 Jul 2026 01:32:03 +0900 Subject: chore(lint): ban std::io::Read/Write, Any, Command use imports Extends no_banned_use to cover std::any::Any, std::io::Read/Write, and std::process::Command, and teaches the linter to allow `as _` imports so trait methods can still be brought into scope without binding the banned name. Fully qualifies all existing usages across the codebase. --- crates/shirabe/tests/all_functional_test.rs | 3 +-- crates/shirabe/tests/repository/vcs_repository_test.rs | 5 ++--- 2 files changed, 3 insertions(+), 5 deletions(-) (limited to 'crates/shirabe/tests') diff --git a/crates/shirabe/tests/all_functional_test.rs b/crates/shirabe/tests/all_functional_test.rs index 594f064..57788a3 100644 --- a/crates/shirabe/tests/all_functional_test.rs +++ b/crates/shirabe/tests/all_functional_test.rs @@ -12,7 +12,6 @@ use shirabe_external_packages::composer::pcre::preg::Preg; use shirabe_php_shim::{CaptureKey, PREG_SPLIT_DELIM_CAPTURE, PhpMixed, intval}; use std::cell::RefCell; use std::path::{Path, PathBuf}; -use std::process::Command; /// ref: AllFunctionalTest's `$oldcwd` / `$testDir` instance state plus its `setUp`/`tearDown`. /// @@ -213,7 +212,7 @@ fn run_integration(test_filename: &str) { let run = &test_data["RUN"]; let command_line = format!("'{}' --no-ansi {} 2>&1", bin, run); - let proc = Command::new("sh") + let proc = std::process::Command::new("sh") .arg("-c") .arg(&command_line) .current_dir(&test_dir) diff --git a/crates/shirabe/tests/repository/vcs_repository_test.rs b/crates/shirabe/tests/repository/vcs_repository_test.rs index ed705e8..1ee72cb 100644 --- a/crates/shirabe/tests/repository/vcs_repository_test.rs +++ b/crates/shirabe/tests/repository/vcs_repository_test.rs @@ -12,7 +12,6 @@ use shirabe::util::http_downloader::HttpDownloader; use shirabe::util::r#loop::Loop; use shirabe_php_shim::PhpMixed; use std::cell::RefCell; -use std::process::Command; use std::rc::Rc; use tempfile::TempDir; @@ -31,7 +30,7 @@ fn set_up() -> Option { let path = git_repo.path(); let exec = |args: &[&str]| { - let status = Command::new("git") + let status = std::process::Command::new("git") .args(args) .current_dir(path) .env("GIT_CONFIG_GLOBAL", "/dev/null") @@ -129,7 +128,7 @@ fn composer(version: Option<&str>) -> PhpMixed { } fn which_git() -> Option<()> { - Command::new("git") + std::process::Command::new("git") .arg("--version") .output() .ok() -- cgit v1.3.1