From 14138dde4a8c874bdc498edd25d1a2d7dc9022be Mon Sep 17 00:00:00 2001 From: nsfisis Date: Sun, 7 Jun 2026 12:16:09 +0900 Subject: feat(metadata-minifier): port expand for minified package metadata Implement MetadataMinifier::expand with the PHP list-of-arrays signature (Vec) and wire it into ComposerRepository so composer/2.0 minified package metadata is expanded, resolving the phase-b TODO. minify() is left unported as it is not used in Composer itself. Co-Authored-By: Claude Opus 4.8 (1M context) --- crates/shirabe/src/package/version/version_guesser.rs | 1 - crates/shirabe/src/repository/composer_repository.rs | 3 +-- 2 files changed, 1 insertion(+), 3 deletions(-) (limited to 'crates/shirabe') diff --git a/crates/shirabe/src/package/version/version_guesser.rs b/crates/shirabe/src/package/version/version_guesser.rs index 20d9974..d8559b7 100644 --- a/crates/shirabe/src/package/version/version_guesser.rs +++ b/crates/shirabe/src/package/version/version_guesser.rs @@ -539,7 +539,6 @@ impl VersionGuesser { let branch_clone = branch.clone(); let cmd_line: Vec = array_map( move |component: &String| -> String { - // TODO(phase-b): str_replace with array arguments — emulating let r1 = str_replace("%candidate%", &candidate_clone, component); str_replace("%branch%", &branch_clone, &r1) }, diff --git a/crates/shirabe/src/repository/composer_repository.rs b/crates/shirabe/src/repository/composer_repository.rs index f9fa551..644ece7 100644 --- a/crates/shirabe/src/repository/composer_repository.rs +++ b/crates/shirabe/src/repository/composer_repository.rs @@ -1794,8 +1794,7 @@ impl ComposerRepository { .and_then(|v| v.as_string()) .map_or(false, |s| s == "composer/2.0"); if minified { - // TODO(phase-b): MetadataMinifier::expand expects/returns IndexMap but versions is Vec - versions = todo!("MetadataMinifier::expand signature mismatch with Vec"); + versions = MetadataMinifier::expand(versions); } names_found.insert(real_name.clone(), true); -- cgit v1.3.1