From 69d7005f186a05a4dde2bd1c77f83f8060a2907d Mon Sep 17 00:00:00 2001 From: nsfisis Date: Fri, 26 Jun 2026 00:48:35 +0900 Subject: test: un-ignore 14 tests that pass against current implementations Discovered via a full --include-ignored run: these tests have real (non-stub) bodies and pass now, either because their blocker was since implemented (e.g. config_command's stream_set_blocking via libc) or the ignore was stale. Covers composer, config, forgejo_url, config_command, default_policy, transaction, installed_repository, github_driver, version_bumper. Co-Authored-By: Claude Opus 4.8 (1M context) --- crates/shirabe/tests/command/config_command_test.rs | 8 -------- crates/shirabe/tests/composer_test.rs | 3 --- crates/shirabe/tests/config_test.rs | 1 - crates/shirabe/tests/dependency_resolver/default_policy_test.rs | 1 - crates/shirabe/tests/dependency_resolver/transaction_test.rs | 1 - crates/shirabe/tests/package/version/version_bumper_test.rs | 1 - crates/shirabe/tests/repository/installed_repository_test.rs | 1 - crates/shirabe/tests/repository/vcs/github_driver_test.rs | 1 - crates/shirabe/tests/util/forgejo_url_test.rs | 3 --- 9 files changed, 20 deletions(-) (limited to 'crates') diff --git a/crates/shirabe/tests/command/config_command_test.rs b/crates/shirabe/tests/command/config_command_test.rs index f43322d..0f4651a 100644 --- a/crates/shirabe/tests/command/config_command_test.rs +++ b/crates/shirabe/tests/command/config_command_test.rs @@ -449,10 +449,6 @@ fn test_config_throws_for_invalid_arg_combination() { #[test] #[serial] -#[ignore = "the command correctly throws, but Application::do_run's exception path calls \ - hint_common_errors -> get_composer (a temp composer.json exists here), which reaches \ - ProcessExecutor (git) -> shirabe-php-shim stream_set_blocking (stream.rs todo!(), \ - requires fcntl(2))"] fn test_config_throws_for_invalid_severity() { let _tear_down = init_temp_composer(Some(&serde_json::json!({})), None, None, false); @@ -476,10 +472,6 @@ fn test_config_throws_for_invalid_severity() { #[test] #[serial] -#[ignore = "the command correctly throws, but Application::do_run's exception path calls \ - hint_common_errors -> get_composer (a temp composer.json exists here), which reaches \ - ProcessExecutor (git) -> shirabe-php-shim stream_set_blocking (stream.rs todo!(), \ - requires fcntl(2))"] fn test_config_throws_when_merging_array_with_object() { let _tear_down = init_temp_composer( Some(&serde_json::json!({"config": {"audit": {"ignore": ["CVE-2024-1234"]}}})), diff --git a/crates/shirabe/tests/composer_test.rs b/crates/shirabe/tests/composer_test.rs index 28d9d47..908e813 100644 --- a/crates/shirabe/tests/composer_test.rs +++ b/crates/shirabe/tests/composer_test.rs @@ -55,7 +55,6 @@ fn test_set_get_package() { } #[test] -#[ignore] fn test_set_get_locker() { let mut composer = Composer::new(); let io = null_io(); @@ -74,7 +73,6 @@ fn test_set_get_locker() { } #[test] -#[ignore] fn test_set_get_repository_manager() { let mut composer = Composer::new(); let io = null_io(); @@ -101,7 +99,6 @@ fn test_set_get_download_manager() { } #[test] -#[ignore] fn test_set_get_installation_manager() { let mut composer = Composer::new(); let io = null_io(); diff --git a/crates/shirabe/tests/config_test.rs b/crates/shirabe/tests/config_test.rs index df29281..1821f24 100644 --- a/crates/shirabe/tests/config_test.rs +++ b/crates/shirabe/tests/config_test.rs @@ -379,7 +379,6 @@ fn test_fetching_relative_paths() { ); } -#[ignore] #[test] fn test_override_github_protocols() { let mut config = Config::new(false, None); diff --git a/crates/shirabe/tests/dependency_resolver/default_policy_test.rs b/crates/shirabe/tests/dependency_resolver/default_policy_test.rs index aac6626..62fa6f8 100644 --- a/crates/shirabe/tests/dependency_resolver/default_policy_test.rs +++ b/crates/shirabe/tests/dependency_resolver/default_policy_test.rs @@ -465,7 +465,6 @@ fn test_repository_ordering_affects_priority() { assert_eq!(expected, selected); } -#[ignore] #[test] fn test_select_local_repos_first() { let _tear_down = TearDown; diff --git a/crates/shirabe/tests/dependency_resolver/transaction_test.rs b/crates/shirabe/tests/dependency_resolver/transaction_test.rs index 7013816..7835e47 100644 --- a/crates/shirabe/tests/dependency_resolver/transaction_test.rs +++ b/crates/shirabe/tests/dependency_resolver/transaction_test.rs @@ -80,7 +80,6 @@ fn check_transaction_operations(transaction: &Transaction, expected: Vec PhpMixed { } #[test] -#[ignore] fn test_find_packages_with_replacers_and_providers() { let foo = loaded("foo", "1", vec![("replace", provided_link())]); let foo2 = get_package("foo", "2"); diff --git a/crates/shirabe/tests/repository/vcs/github_driver_test.rs b/crates/shirabe/tests/repository/vcs/github_driver_test.rs index ba370a7..4bfb608 100644 --- a/crates/shirabe/tests/repository/vcs/github_driver_test.rs +++ b/crates/shirabe/tests/repository/vcs/github_driver_test.rs @@ -149,7 +149,6 @@ fn supports_provider() -> Vec<(bool, &'static str)> { } #[test] -#[ignore] fn test_supports() { let SetUp { home, config: _ } = set_up(); let _tear_down = TearDown::new(home.path().to_path_buf()); diff --git a/crates/shirabe/tests/util/forgejo_url_test.rs b/crates/shirabe/tests/util/forgejo_url_test.rs index 5c33596..3cdaac8 100644 --- a/crates/shirabe/tests/util/forgejo_url_test.rs +++ b/crates/shirabe/tests/util/forgejo_url_test.rs @@ -3,7 +3,6 @@ use shirabe::util::forgejo_url::ForgejoUrl; #[test] -#[ignore] fn test_create() { for repo_url in create_provider() { let forgejo_url = ForgejoUrl::try_from(Some(repo_url)); @@ -29,13 +28,11 @@ fn create_provider() -> Vec<&'static str> { } #[test] -#[ignore] fn test_create_invalid() { assert!(ForgejoUrl::create("https://example.org").is_err()); } #[test] -#[ignore] fn test_generate_ssh_url() { let forgejo_url = ForgejoUrl::create("git@codeberg.org:acme/repo.git").unwrap(); -- cgit v1.3.1