From f90900604b35cb4ecc04ce224ad64f74c2132aaa Mon Sep 17 00:00:00 2001 From: nsfisis Date: Mon, 20 Jul 2026 03:48:41 +0900 Subject: test(completion-functional): detail test_complete ignore blockers Beyond the missing CommandCompletionTester harness, the PHP test's expected suggestions depend on the Composer dev checkout environment (its own composer.json/lock, installed vendor packages) and live Packagist queries, which the port cannot reproduce without a fixture environment. Co-Authored-By: Claude Fable 5 --- crates/shirabe/tests/completion_functional_test.rs | 13 ++++++++++--- 1 file changed, 10 insertions(+), 3 deletions(-) (limited to 'crates') diff --git a/crates/shirabe/tests/completion_functional_test.rs b/crates/shirabe/tests/completion_functional_test.rs index 82f42fbf..860df546 100644 --- a/crates/shirabe/tests/completion_functional_test.rs +++ b/crates/shirabe/tests/completion_functional_test.rs @@ -1,9 +1,16 @@ //! ref: composer/tests/Composer/Test/CompletionFunctionalTest.php #[test] -#[ignore = "CommandCompletionTester (Symfony Console test helper) is not implemented in the port"] +#[ignore = "CommandCompletionTester (Symfony Console test helper) is not ported, and the test only works inside the Composer dev checkout (its own composer.json/lock + installed vendor dir, plus live Packagist queries for package-name suggestions)"] fn test_complete() { - // TODO(phase-d): CommandCompletionTester (Symfony Console test helper) is not implemented in - // the port, so this data-provider-driven completion test has no harness to run against. + // TODO(phase-d): two blockers. (1) CommandCompletionTester (Symfony Console test helper + // driving the `|_complete` command) is not implemented in the shirabe-external-packages + // console port, so the data-provider-driven completion test has no harness to run against. + // (2) The PHP test's expected suggestions come from the environment it runs in: the Composer + // dev checkout's own composer.json/composer.lock and installed vendor packages (e.g. + // `depends ` -> composer/semver, psr/log; `run-script ` -> compile/test/phpstan) and live + // Packagist API queries for package-name completion (e.g. `archive symfony/http-`). The port + // has no equivalent fixture environment, so even with a tester the data sets could not be + // reproduced without altering expected values. todo!() } -- cgit v1.3.1