From c899a4675ca90507a420d901ef7fa26d8b285f23 Mon Sep 17 00:00:00 2001 From: nsfisis Date: Tue, 21 Jul 2026 08:08:15 +0900 Subject: refactor(lint): rewrite structural linters from Ruby to PHP Fold scripts/lint and scripts/linters/*.rb into a standalone Composer project under scripts/linters/, matching the scripts/plugin-class-classifier/ convention. Uses no external packages, only PHP + Composer autoloading. Verified byte-for-byte identical output against the original Ruby implementation, both on the current repo (all linters pass) and on a synthetic fixture exercising every violation type. Entry point moves from `scripts/lint` to `scripts/linters/lint`. --- scripts/linters/no_std_collections_maps.rb | 50 ------------------------------ 1 file changed, 50 deletions(-) delete mode 100644 scripts/linters/no_std_collections_maps.rb (limited to 'scripts/linters/no_std_collections_maps.rb') diff --git a/scripts/linters/no_std_collections_maps.rb b/scripts/linters/no_std_collections_maps.rb deleted file mode 100644 index 3701d753..00000000 --- a/scripts/linters/no_std_collections_maps.rb +++ /dev/null @@ -1,50 +0,0 @@ -def no_std_collections_maps(root_dir, excludes = []) - pattern = root_dir.join('crates', '**', '*.rs').to_s - errors = Dir.glob(pattern).sort.flat_map do |path| - relative = Pathname.new(path).relative_path_from(root_dir).to_s - next [] if excludes.include?(relative) - - find_std_map_usages(path, relative) - end - - return true if errors.empty? - - puts 'Found uses of `std::collections::{HashMap, HashSet, BTreeMap, BTreeSet}`.' - puts 'Use `indexmap::IndexMap` / `indexmap::IndexSet` instead:' - errors.each do |err| - puts " #{err}" - end - false -end - -BANNED_MAP_NAMES = %w[HashMap HashSet BTreeMap BTreeSet].freeze - -def find_std_map_usages(path, relative) - errors = [] - - File.readlines(path).each_with_index do |raw, idx| - code = raw.split('//', 2).first || raw - - code.scan(/\bstd::collections::(HashMap|HashSet|BTreeMap|BTreeSet)\b/) do |m| - errors << "#{relative}:#{idx + 1}: use of `std::collections::#{m[0]}` (use `indexmap::#{indexmap_replacement(m[0])}` instead)" - end - - code.scan(/\bstd::collections::\{([^}]*)\}/) do |m| - m[0].split(',').each do |entry| - name = entry.strip.split(/\s+as\s+/).first - next unless BANNED_MAP_NAMES.include?(name) - - errors << "#{relative}:#{idx + 1}: import of `std::collections::#{name}` (use `indexmap::#{indexmap_replacement(name)}` instead)" - end - end - end - - errors.uniq -end - -def indexmap_replacement(name) - case name - when 'HashMap', 'BTreeMap' then 'IndexMap' - when 'HashSet', 'BTreeSet' then 'IndexSet' - end -end -- cgit v1.3.1