From c899a4675ca90507a420d901ef7fa26d8b285f23 Mon Sep 17 00:00:00 2001 From: nsfisis Date: Tue, 21 Jul 2026 08:08:15 +0900 Subject: refactor(lint): rewrite structural linters from Ruby to PHP Fold scripts/lint and scripts/linters/*.rb into a standalone Composer project under scripts/linters/, matching the scripts/plugin-class-classifier/ convention. Uses no external packages, only PHP + Composer autoloading. Verified byte-for-byte identical output against the original Ruby implementation, both on the current repo (all linters pass) and on a synthetic fixture exercising every violation type. Entry point moves from `scripts/lint` to `scripts/linters/lint`. --- scripts/linters/no_use_as_alias.rb | 57 -------------------------------------- 1 file changed, 57 deletions(-) delete mode 100644 scripts/linters/no_use_as_alias.rb (limited to 'scripts/linters/no_use_as_alias.rb') diff --git a/scripts/linters/no_use_as_alias.rb b/scripts/linters/no_use_as_alias.rb deleted file mode 100644 index 8e0c86b3..00000000 --- a/scripts/linters/no_use_as_alias.rb +++ /dev/null @@ -1,57 +0,0 @@ -def no_use_as_alias(root_dir, excludes = []) - pattern = root_dir.join('crates', '**', '*.rs').to_s - errors = Dir.glob(pattern).sort.flat_map do |path| - relative = Pathname.new(path).relative_path_from(root_dir).to_s - next [] if excludes.include?(relative) - - find_use_aliases(path, relative) - end - - return true if errors.empty? - - puts 'Found `use ... as name` aliases.' - puts 'Aliasing imports merely to shorten a namespace is forbidden.' - puts 'Only `as _` (e.g. `use std::io::Write as _;`) and PascalCase renames' - puts '(for collision avoidance, e.g. `use foo::Error as FooError;`) are allowed:' - errors.each do |err| - puts " #{err}" - end - false -end - -USE_ALIAS_START_RE = /\A(?:pub(?:\([^)]*\))?\s+)?use\b/ -PASCAL_CASE_RE = /\A[A-Z][A-Za-z0-9]*\z/ - -def find_use_aliases(path, relative) - errors = [] - in_use = false - brace_depth = 0 - - File.readlines(path).each_with_index do |raw, idx| - code = raw.split('//', 2).first || raw - stripped = code.strip - - unless in_use - next unless stripped =~ USE_ALIAS_START_RE - - in_use = true - brace_depth = 0 - end - - code.scan(/\bas\s+([A-Za-z_][A-Za-z0-9_]*)/) do |m| - name = m[0] - next if name == '_' - next if name =~ PASCAL_CASE_RE - - errors << "#{relative}:#{idx + 1}: `as #{name}` aliasing in `use` statement" - end - - brace_depth += code.count('{') - code.count('}') - if brace_depth <= 0 && code.rstrip.end_with?(';') - in_use = false - brace_depth = 0 - end - end - - errors -end -- cgit v1.3.1