From c899a4675ca90507a420d901ef7fa26d8b285f23 Mon Sep 17 00:00:00 2001 From: nsfisis Date: Tue, 21 Jul 2026 08:08:15 +0900 Subject: refactor(lint): rewrite structural linters from Ruby to PHP Fold scripts/lint and scripts/linters/*.rb into a standalone Composer project under scripts/linters/, matching the scripts/plugin-class-classifier/ convention. Uses no external packages, only PHP + Composer autoloading. Verified byte-for-byte identical output against the original Ruby implementation, both on the current repo (all linters pass) and on a synthetic fixture exercising every violation type. Entry point moves from `scripts/lint` to `scripts/linters/lint`. --- .../linters/src/Linters/NoStdCollectionsMaps.php | 80 ++++++++++++++++++++++ 1 file changed, 80 insertions(+) create mode 100644 scripts/linters/src/Linters/NoStdCollectionsMaps.php (limited to 'scripts/linters/src/Linters/NoStdCollectionsMaps.php') diff --git a/scripts/linters/src/Linters/NoStdCollectionsMaps.php b/scripts/linters/src/Linters/NoStdCollectionsMaps.php new file mode 100644 index 00000000..c2f9c32e --- /dev/null +++ b/scripts/linters/src/Linters/NoStdCollectionsMaps.php @@ -0,0 +1,80 @@ +findStdMapUsages($path, $relative)); + } + + return $errors; + } + + /** @return list */ + private function findStdMapUsages(string $path, string $relative): array + { + $errors = []; + + foreach (file($path) as $idx => $raw) { + $code = explode('//', $raw, 2)[0]; + + if (preg_match_all('/\bstd::collections::(HashMap|HashSet|BTreeMap|BTreeSet)\b/', $code, $m)) { + foreach ($m[1] as $name) { + $errors[] = "{$relative}:" . ($idx + 1) . ": use of `std::collections::{$name}` (use `indexmap::" . self::indexmapReplacement($name) . '` instead)'; + } + } + + if (preg_match_all('/\bstd::collections::\{([^}]*)\}/', $code, $m)) { + foreach ($m[1] as $group) { + foreach (explode(',', $group) as $entry) { + $name = preg_split('/\s+as\s+/', trim($entry))[0]; + if (!in_array($name, self::BANNED_MAP_NAMES, true)) { + continue; + } + $errors[] = "{$relative}:" . ($idx + 1) . ": import of `std::collections::{$name}` (use `indexmap::" . self::indexmapReplacement($name) . '` instead)'; + } + } + } + } + + return array_values(array_unique($errors)); + } + + private static function indexmapReplacement(string $name): string + { + return match ($name) { + 'HashMap', 'BTreeMap' => 'IndexMap', + 'HashSet', 'BTreeSet' => 'IndexSet', + default => throw new \LogicException("unexpected map name: {$name}"), + }; + } +} -- cgit v1.3.1