From a9b1520b81f272dc3b52fc8172fe0d0b04d576e4 Mon Sep 17 00:00:00 2001 From: nsfisis Date: Sun, 18 Aug 2024 01:26:25 +0900 Subject: refactor(backend): rename func name for consistency --- backend/game/hub.go | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) (limited to 'backend/game/hub.go') diff --git a/backend/game/hub.go b/backend/game/hub.go index 7c06e05..9e1194b 100644 --- a/backend/game/hub.go +++ b/backend/game/hub.go @@ -138,7 +138,7 @@ func (hub *gameHub) run() { } } -func (hub *gameHub) sendExecResultMessage(playerID int, testcaseID nullable.Nullable[int], status string, stdout string, stderr string) { +func (hub *gameHub) sendExecResult(playerID int, testcaseID nullable.Nullable[int], status string, stdout string, stderr string) { hub.sendToPlayer(playerID, &playerMessageS2CExecResult{ Type: playerMessageTypeS2CExecResult, Data: playerMessageS2CExecResultPayload{ @@ -218,7 +218,7 @@ func (hub *gameHub) processTaskResults() { case *taskqueue.TaskResultCompileSwiftToWasm: err := hub.processTaskResultCompileSwiftToWasm(taskResult) if err != nil { - hub.sendExecResultMessage( + hub.sendExecResult( taskResult.TaskPayload.UserID(), nullable.NewNullNullable[int](), err.Status, @@ -234,7 +234,7 @@ func (hub *gameHub) processTaskResults() { case *taskqueue.TaskResultCompileWasmToNativeExecutable: err := hub.processTaskResultCompileWasmToNativeExecutable(taskResult) if err != nil { - hub.sendExecResultMessage( + hub.sendExecResult( taskResult.TaskPayload.UserID(), nullable.NewNullNullable[int](), err.Status, @@ -247,7 +247,7 @@ func (hub *gameHub) processTaskResults() { nullable.NewNullNullable[int](), ) } else { - hub.sendExecResultMessage( + hub.sendExecResult( taskResult.TaskPayload.UserID(), nullable.NewNullNullable[int](), "success", @@ -270,7 +270,7 @@ func (hub *gameHub) processTaskResults() { Stderr: "", }) if err != nil { - hub.sendExecResultMessage( + hub.sendExecResult( taskResult.TaskPayload.UserID(), nullable.NewNullableWithValue(int(taskResult.TaskPayload.TestcaseID)), "internal_error", @@ -286,7 +286,7 @@ func (hub *gameHub) processTaskResults() { continue } if err1 != nil { - hub.sendExecResultMessage( + hub.sendExecResult( taskResult.TaskPayload.UserID(), nullable.NewNullableWithValue(int(taskResult.TaskPayload.TestcaseID)), aggregatedStatus, @@ -294,7 +294,7 @@ func (hub *gameHub) processTaskResults() { err1.Stderr, ) } else { - hub.sendExecResultMessage( + hub.sendExecResult( taskResult.TaskPayload.UserID(), nullable.NewNullableWithValue(int(taskResult.TaskPayload.TestcaseID)), "success", -- cgit v1.2.3-70-g09d2 From 4969cc2e9f620c9858f39d22ec61a2c7e1690331 Mon Sep 17 00:00:00 2001 From: nsfisis Date: Sun, 18 Aug 2024 01:27:49 +0900 Subject: feat(backend): do now show success message --- backend/game/hub.go | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) (limited to 'backend/game/hub.go') diff --git a/backend/game/hub.go b/backend/game/hub.go index 9e1194b..21142a1 100644 --- a/backend/game/hub.go +++ b/backend/game/hub.go @@ -251,8 +251,7 @@ func (hub *gameHub) processTaskResults() { taskResult.TaskPayload.UserID(), nullable.NewNullNullable[int](), "success", - // TODO: inherit the command stdout/stderr. - "Successfully compiled", + "", "", ) } @@ -298,8 +297,7 @@ func (hub *gameHub) processTaskResults() { taskResult.TaskPayload.UserID(), nullable.NewNullableWithValue(int(taskResult.TaskPayload.TestcaseID)), "success", - // TODO: inherit the command stdout/stderr? - "Testcase passed", + "", "", ) } -- cgit v1.2.3-70-g09d2 From 3e63c4baf62a9d383a5c62afee9b01684830bba9 Mon Sep 17 00:00:00 2001 From: nsfisis Date: Sun, 18 Aug 2024 01:29:26 +0900 Subject: feat(backend): do now show error message except for compile error --- backend/game/hub.go | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) (limited to 'backend/game/hub.go') diff --git a/backend/game/hub.go b/backend/game/hub.go index 21142a1..d385746 100644 --- a/backend/game/hub.go +++ b/backend/game/hub.go @@ -273,9 +273,8 @@ func (hub *gameHub) processTaskResults() { taskResult.TaskPayload.UserID(), nullable.NewNullableWithValue(int(taskResult.TaskPayload.TestcaseID)), "internal_error", - // TODO: inherit the command stdout/stderr? "", - "internal error", + "", ) hub.sendSubmitResult( taskResult.TaskPayload.UserID(), @@ -289,8 +288,8 @@ func (hub *gameHub) processTaskResults() { taskResult.TaskPayload.UserID(), nullable.NewNullableWithValue(int(taskResult.TaskPayload.TestcaseID)), aggregatedStatus, - err1.Stdout, - err1.Stderr, + "", + "", ) } else { hub.sendExecResult( -- cgit v1.2.3-70-g09d2