aboutsummaryrefslogtreecommitdiffhomepage
path: root/src/client/pages
diff options
context:
space:
mode:
authornsfisis <nsfisis@gmail.com>2026-05-02 11:11:53 +0900
committernsfisis <nsfisis@gmail.com>2026-05-02 11:12:00 +0900
commit7ca9941982a7d7a4c126d215770ce71ad2f7f427 (patch)
tree0178b48094e9b7b143fd47c4d8479d3d588bb1d7 /src/client/pages
parent8f1a08fefee3a8e928baec741c830a88a4cd7200 (diff)
downloadkioku-7ca9941982a7d7a4c126d215770ce71ad2f7f427.tar.gz
kioku-7ca9941982a7d7a4c126d215770ce71ad2f7f427.tar.zst
kioku-7ca9941982a7d7a4c126d215770ce71ad2f7f427.zip
feat(client): read decks/cards/study from IndexedDB first
Switch deckAtom, cardsByDeckAtomFamily, noteTypesAtom, and studyDataAtom to a stale-while-revalidate pattern: read from IndexedDB synchronously, trigger sync in the background, and refetch on sync_complete. When local is empty, await a single bootstrap pull before deciding there's no data. Add study-builder to assemble StudyCards from LocalCard + Note + NoteType + field values, replacing the server /study endpoint dependency. The study session can now run end-to-end offline. Disable submit on all write modals when offline since writes still require the server. Add a "Showing cached data" hint to the sync status indicator. Drop cacheStudyCards (cards arrive via regular sync pull now) and update page tests to reflect that lists no longer refresh by hitting the GET API.
Diffstat (limited to 'src/client/pages')
-rw-r--r--src/client/pages/DeckCardsPage.test.tsx16
-rw-r--r--src/client/pages/HomePage.test.tsx115
-rw-r--r--src/client/pages/NoteTypesPage.test.tsx49
-rw-r--r--src/client/pages/StudyPage.test.tsx19
4 files changed, 18 insertions, 181 deletions
diff --git a/src/client/pages/DeckCardsPage.test.tsx b/src/client/pages/DeckCardsPage.test.tsx
index c498056..0ea9822 100644
--- a/src/client/pages/DeckCardsPage.test.tsx
+++ b/src/client/pages/DeckCardsPage.test.tsx
@@ -417,12 +417,9 @@ describe("DeckCardsPage", () => {
expect(screen.queryByRole("dialog")).toBeNull();
});
- it("deletes note and refreshes list on confirmation", async () => {
+ it("submits the note delete via the delete endpoint", async () => {
const user = userEvent.setup();
- mockCardsGet.mockResolvedValue({
- cards: [mockCards[1]],
- });
mockNoteDelete.mockResolvedValue({
ok: true,
json: async () => ({ success: true }),
@@ -457,10 +454,6 @@ describe("DeckCardsPage", () => {
expect(mockNoteDelete).toHaveBeenCalledWith({
param: { deckId: "deck-1", noteId: "note-1" },
});
-
- await waitFor(() => {
- expect(screen.getByText("(1)")).toBeDefined();
- });
});
it("displays error when delete fails", async () => {
@@ -568,10 +561,9 @@ describe("DeckCardsPage", () => {
).toBeDefined();
});
- it("deletes note and refreshes list when confirmed", async () => {
+ it("submits the note delete via the delete endpoint", async () => {
const user = userEvent.setup();
- mockCardsGet.mockResolvedValue({ cards: [] });
mockNoteDelete.mockResolvedValue({
ok: true,
json: async () => ({ success: true }),
@@ -603,10 +595,6 @@ describe("DeckCardsPage", () => {
expect(mockNoteDelete).toHaveBeenCalledWith({
param: { deckId: "deck-1", noteId: "note-1" },
});
-
- await waitFor(() => {
- expect(screen.getByText("No cards yet")).toBeDefined();
- });
});
it("displays note preview from normal card content", () => {
diff --git a/src/client/pages/HomePage.test.tsx b/src/client/pages/HomePage.test.tsx
index a552c7f..3b053f0 100644
--- a/src/client/pages/HomePage.test.tsx
+++ b/src/client/pages/HomePage.test.tsx
@@ -64,17 +64,6 @@ const mockFetch = vi.fn();
global.fetch = mockFetch;
// Helper to create mock responses compatible with Hono's ClientResponse
-function mockResponse(data: {
- ok: boolean;
- status?: number;
- // biome-ignore lint/suspicious/noExplicitAny: Test helper needs flexible typing
- json: () => Promise<any>;
-}) {
- return data as unknown as Awaited<
- ReturnType<typeof apiClient.rpc.api.decks.$get>
- >;
-}
-
function mockPostResponse(data: {
ok: boolean;
status?: number;
@@ -280,27 +269,10 @@ describe("HomePage", () => {
expect(deckCard?.querySelectorAll("p").length).toBe(0);
});
- it("passes auth header when fetching decks", async () => {
- testQueryClient = new QueryClient({
- defaultOptions: {
- queries: { staleTime: 0, retry: false },
- },
- });
-
- vi.mocked(apiClient.rpc.api.decks.$get).mockResolvedValue(
- mockResponse({
- ok: true,
- json: async () => ({ decks: [] }),
- }),
- );
-
- renderWithProviders();
-
- await waitFor(() => {
- expect(apiClient.rpc.api.decks.$get).toHaveBeenCalledWith(undefined, {
- headers: { Authorization: "Bearer access-token" },
- });
- });
+ it.skip("passes auth header when fetching decks", async () => {
+ // Decks are now read from IndexedDB; the GET decks API is no longer
+ // invoked by the decksAtom queryFn. Auth headers for the underlying
+ // sync pull are exercised in sync-layer tests.
});
describe("Create Deck", () => {
@@ -335,7 +307,7 @@ describe("HomePage", () => {
expect(screen.queryByRole("dialog")).toBeNull();
});
- it("creates deck and refreshes list", async () => {
+ it("submits the new deck via the create endpoint", async () => {
const user = userEvent.setup();
const newDeck = {
id: "deck-new",
@@ -350,14 +322,6 @@ describe("HomePage", () => {
updatedAt: "2024-01-03T00:00:00Z",
};
- // After mutation, the list will refetch
- vi.mocked(apiClient.rpc.api.decks.$get).mockResolvedValue(
- mockResponse({
- ok: true,
- json: async () => ({ decks: [newDeck] }),
- }),
- );
-
vi.mocked(apiClient.rpc.api.decks.$post).mockResolvedValue(
mockPostResponse({
ok: true,
@@ -365,35 +329,21 @@ describe("HomePage", () => {
}),
);
- // Start with empty decks (hydrated)
renderWithProviders({ initialDecks: [] });
- // Open modal
await user.click(screen.getByRole("button", { name: /New Deck/i }));
-
- // Fill in form
await user.type(screen.getByLabelText("Name"), "New Deck");
await user.type(
screen.getByLabelText("Description (optional)"),
"A new deck",
);
-
- // Submit
await user.click(screen.getByRole("button", { name: "Create Deck" }));
- // Modal should close
await waitFor(() => {
expect(screen.queryByRole("dialog")).toBeNull();
});
- // Deck list should be refreshed with new deck
- await waitFor(() => {
- expect(screen.getByRole("heading", { name: "New Deck" })).toBeDefined();
- });
- expect(screen.getByText("A new deck")).toBeDefined();
-
- // API should have been called once (refresh after creation)
- expect(apiClient.rpc.api.decks.$get).toHaveBeenCalledTimes(1);
+ expect(apiClient.rpc.api.decks.$post).toHaveBeenCalledTimes(1);
});
});
@@ -438,55 +388,34 @@ describe("HomePage", () => {
expect(screen.queryByRole("dialog")).toBeNull();
});
- it("edits deck and refreshes list", async () => {
+ it("submits the edited deck via the update endpoint", async () => {
const user = userEvent.setup();
const updatedDeck = {
...mockDecks[0],
name: "Updated Japanese",
};
- // After mutation, the list will refetch
- vi.mocked(apiClient.rpc.api.decks.$get).mockResolvedValue(
- mockResponse({
- ok: true,
- json: async () => ({ decks: [updatedDeck, mockDecks[1]] }),
- }),
- );
-
mockDeckPut.mockResolvedValue({
ok: true,
json: async () => ({ deck: updatedDeck }),
});
- // Start with initial decks (hydrated)
renderWithProviders({ initialDecks: mockDecks });
- // Click Edit on first deck
const editButtons = screen.getAllByRole("button", { name: "Edit deck" });
await user.click(editButtons.at(0) as HTMLElement);
- // Update name
const nameInput = screen.getByLabelText("Name");
await user.clear(nameInput);
await user.type(nameInput, "Updated Japanese");
- // Save
await user.click(screen.getByRole("button", { name: "Save Changes" }));
- // Modal should close
await waitFor(() => {
expect(screen.queryByRole("dialog")).toBeNull();
});
- // Deck list should be refreshed with updated name
- await waitFor(() => {
- expect(
- screen.getByRole("heading", { name: "Updated Japanese" }),
- ).toBeDefined();
- });
-
- // API should have been called once (refresh after update)
- expect(apiClient.rpc.api.decks.$get).toHaveBeenCalledTimes(1);
+ expect(mockDeckPut).toHaveBeenCalledTimes(1);
});
});
@@ -538,37 +467,25 @@ describe("HomePage", () => {
expect(screen.queryByRole("dialog")).toBeNull();
});
- it("deletes deck and refreshes list", async () => {
+ it("submits the delete via the delete endpoint", async () => {
const user = userEvent.setup();
- // After mutation, the list will refetch
- vi.mocked(apiClient.rpc.api.decks.$get).mockResolvedValue(
- mockResponse({
- ok: true,
- json: async () => ({ decks: [mockDecks[1]] }),
- }),
- );
-
mockDeckDelete.mockResolvedValue({
ok: true,
json: async () => ({ success: true }),
});
- // Start with initial decks (hydrated)
renderWithProviders({ initialDecks: mockDecks });
- // Click Delete on first deck
const deleteButtons = screen.getAllByRole("button", {
name: "Delete deck",
});
await user.click(deleteButtons.at(0) as HTMLElement);
- // Wait for modal to appear
await waitFor(() => {
expect(screen.getByRole("dialog")).toBeDefined();
});
- // Confirm deletion - get the Delete button inside the dialog
const dialog = screen.getByRole("dialog");
const dialogButtons = dialog.querySelectorAll("button");
const deleteButton = Array.from(dialogButtons).find(
@@ -576,23 +493,11 @@ describe("HomePage", () => {
);
await user.click(deleteButton as HTMLElement);
- // Modal should close
await waitFor(() => {
expect(screen.queryByRole("dialog")).toBeNull();
});
- // Deck list should be refreshed without deleted deck
- await waitFor(() => {
- expect(
- screen.queryByRole("heading", { name: "Japanese Vocabulary" }),
- ).toBeNull();
- });
- expect(
- screen.getByRole("heading", { name: "Spanish Verbs" }),
- ).toBeDefined();
-
- // API should have been called once (refresh after deletion)
- expect(apiClient.rpc.api.decks.$get).toHaveBeenCalledTimes(1);
+ expect(mockDeckDelete).toHaveBeenCalledTimes(1);
});
});
});
diff --git a/src/client/pages/NoteTypesPage.test.tsx b/src/client/pages/NoteTypesPage.test.tsx
index 612cf16..1a41185 100644
--- a/src/client/pages/NoteTypesPage.test.tsx
+++ b/src/client/pages/NoteTypesPage.test.tsx
@@ -267,7 +267,7 @@ describe("NoteTypesPage", () => {
).toBeDefined();
});
- it("creates note type and refreshes list", async () => {
+ it("submits the new note type via the create endpoint", async () => {
const user = userEvent.setup();
const newNoteType = {
id: "note-type-new",
@@ -279,35 +279,22 @@ describe("NoteTypesPage", () => {
updatedAt: "2024-01-03T00:00:00Z",
};
- // Mock the POST response and subsequent GET after reload
mockNoteTypesPost.mockResolvedValue({
ok: true,
json: async () => ({ noteType: newNoteType }),
});
- mockNoteTypesGet.mockResolvedValue({ noteTypes: [newNoteType] });
renderWithProviders({ initialNoteTypes: [] });
- // Open modal
await user.click(screen.getByRole("button", { name: /New Note Type/i }));
-
- // Fill in form
await user.type(screen.getByLabelText("Name"), "New Note Type");
-
- // Submit
await user.click(screen.getByRole("button", { name: "Create" }));
- // Modal should close
await waitFor(() => {
expect(screen.queryByRole("dialog")).toBeNull();
});
- // Note type list should be refreshed with new note type
- await waitFor(() => {
- expect(
- screen.getByRole("heading", { name: "New Note Type" }),
- ).toBeDefined();
- });
+ expect(mockNoteTypesPost).toHaveBeenCalledTimes(1);
});
});
@@ -364,7 +351,7 @@ describe("NoteTypesPage", () => {
});
});
- it("edits note type and refreshes list", async () => {
+ it("submits the edited note type via the update endpoint", async () => {
const user = userEvent.setup();
const mockNoteTypeWithFields = {
...mockNoteTypes[0],
@@ -395,42 +382,29 @@ describe("NoteTypesPage", () => {
ok: true,
json: async () => ({ noteType: updatedNoteType }),
});
- mockNoteTypesGet.mockResolvedValue({
- noteTypes: [updatedNoteType, mockNoteTypes[1]],
- });
renderWithProviders({ initialNoteTypes: mockNoteTypes });
- // Click Edit on first note type
const editButtons = screen.getAllByRole("button", {
name: "Edit note type",
});
await user.click(editButtons.at(0) as HTMLElement);
- // Wait for the editor to load
await waitFor(() => {
expect(screen.getByLabelText("Name")).toHaveProperty("value", "Basic");
});
- // Update name
const nameInput = screen.getByLabelText("Name");
await user.clear(nameInput);
await user.type(nameInput, "Updated Basic");
- // Save
await user.click(screen.getByRole("button", { name: "Save Changes" }));
- // Modal should close
await waitFor(() => {
expect(screen.queryByRole("dialog")).toBeNull();
});
- // Note type list should be refreshed with updated name
- await waitFor(() => {
- expect(
- screen.getByRole("heading", { name: "Updated Basic" }),
- ).toBeDefined();
- });
+ expect(mockNoteTypePut).toHaveBeenCalledTimes(1);
});
});
@@ -463,29 +437,25 @@ describe("NoteTypesPage", () => {
expect(dialog.textContent).toContain("Basic");
});
- it("deletes note type and refreshes list", async () => {
+ it("submits the note type delete via the delete endpoint", async () => {
const user = userEvent.setup();
mockNoteTypeDelete.mockResolvedValue({
ok: true,
json: async () => ({ success: true }),
});
- mockNoteTypesGet.mockResolvedValue({ noteTypes: [mockNoteTypes[1]] });
renderWithProviders({ initialNoteTypes: mockNoteTypes });
- // Click Delete on first note type
const deleteButtons = screen.getAllByRole("button", {
name: "Delete note type",
});
await user.click(deleteButtons.at(0) as HTMLElement);
- // Wait for modal to appear
await waitFor(() => {
expect(screen.getByRole("dialog")).toBeDefined();
});
- // Confirm deletion
const dialog = screen.getByRole("dialog");
const dialogButtons = dialog.querySelectorAll("button");
const deleteButton = Array.from(dialogButtons).find(
@@ -493,18 +463,11 @@ describe("NoteTypesPage", () => {
);
await user.click(deleteButton as HTMLElement);
- // Modal should close
await waitFor(() => {
expect(screen.queryByRole("dialog")).toBeNull();
});
- // Note type list should be refreshed without deleted note type
- await waitFor(() => {
- expect(screen.queryByRole("heading", { name: "Basic" })).toBeNull();
- });
- expect(
- screen.getByRole("heading", { name: "Basic (and reversed card)" }),
- ).toBeDefined();
+ expect(mockNoteTypeDelete).toHaveBeenCalledTimes(1);
});
});
});
diff --git a/src/client/pages/StudyPage.test.tsx b/src/client/pages/StudyPage.test.tsx
index aa33260..1fa6e71 100644
--- a/src/client/pages/StudyPage.test.tsx
+++ b/src/client/pages/StudyPage.test.tsx
@@ -36,7 +36,6 @@ vi.mock(import("../sync"), async (importOriginal) => {
mockSubmitReview(args),
undoReviewLocal: (args: Parameters<typeof actual.undoReviewLocal>[0]) =>
mockUndoReview(args),
- cacheStudyCards: vi.fn().mockResolvedValue(undefined),
};
});
@@ -136,21 +135,7 @@ function makeStudyCard(overrides: Partial<StudyCard>): StudyCard {
deckId: "deck-1",
noteId: "note-1",
isReversed: false,
- front: "Hello",
- back: "こんにちは",
state: 0,
- due: "2024-01-01T00:00:00Z",
- stability: 0,
- difficulty: 0,
- elapsedDays: 0,
- scheduledDays: 0,
- reps: 0,
- lapses: 0,
- lastReview: null,
- createdAt: "2024-01-01T00:00:00Z",
- updatedAt: "2024-01-01T00:00:00Z",
- deletedAt: null,
- syncVersion: 0,
noteType: { frontTemplate: "{{Front}}", backTemplate: "{{Back}}" },
fieldValuesMap: { Front: "Hello", Back: "こんにちは" },
...overrides,
@@ -161,15 +146,11 @@ const mockFirstCard = makeStudyCard({});
const mockSecondCard = makeStudyCard({
id: "card-2",
noteId: "note-2",
- front: "Goodbye",
- back: "さようなら",
fieldValuesMap: { Front: "Goodbye", Back: "さようなら" },
});
const mockThirdCard = makeStudyCard({
id: "card-3",
noteId: "note-3",
- front: "Thank you",
- back: "ありがとう",
fieldValuesMap: { Front: "Thank you", Back: "ありがとう" },
});