aboutsummaryrefslogtreecommitdiffhomepage
path: root/src/client/components/CreateNoteModal.test.tsx
blob: dcb3360f723e64d3dd36e80ab1fd5454827b856d (plain)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
/**
 * @vitest-environment jsdom
 */
import { cleanup, render, screen, waitFor } from "@testing-library/react";
import userEvent from "@testing-library/user-event";
import { afterEach, beforeEach, describe, expect, it, vi } from "vitest";

const mockNoteTypesGet = vi.fn();
const mockNoteTypeGet = vi.fn();
const mockNotesPost = vi.fn();
const mockHandleResponse = vi.fn();

vi.mock("../api/client", () => ({
	apiClient: {
		rpc: {
			api: {
				"note-types": {
					$get: () => mockNoteTypesGet(),
					":id": {
						$get: (args: unknown) => mockNoteTypeGet(args),
					},
				},
				decks: {
					":deckId": {
						notes: {
							$post: (args: unknown) => mockNotesPost(args),
						},
					},
				},
			},
		},
		handleResponse: (res: unknown) => mockHandleResponse(res),
	},
	ApiClientError: class ApiClientError extends Error {
		constructor(
			message: string,
			public status: number,
			public code?: string,
		) {
			super(message);
			this.name = "ApiClientError";
		}
	},
}));

import { ApiClientError } from "../api/client";
// Import after mock is set up
import { CreateNoteModal } from "./CreateNoteModal";

describe("CreateNoteModal", () => {
	const defaultProps = {
		isOpen: true,
		deckId: "deck-123",
		onClose: vi.fn(),
		onNoteCreated: vi.fn(),
	};

	const mockNoteTypes = [
		{ id: "note-type-1", name: "Basic", isReversible: false },
		{ id: "note-type-2", name: "Basic (reversed)", isReversible: true },
	];

	const mockNoteTypeWithFields = {
		id: "note-type-1",
		name: "Basic",
		frontTemplate: "{{Front}}",
		backTemplate: "{{Back}}",
		isReversible: false,
		fields: [
			{ id: "field-1", name: "Front", order: 0 },
			{ id: "field-2", name: "Back", order: 1 },
		],
	};

	beforeEach(() => {
		vi.clearAllMocks();
		mockNoteTypesGet.mockResolvedValue({ ok: true });
		mockNoteTypeGet.mockResolvedValue({ ok: true });
		mockNotesPost.mockResolvedValue({ ok: true });
	});

	afterEach(() => {
		cleanup();
		vi.restoreAllMocks();
	});

	it("does not render when closed", () => {
		render(<CreateNoteModal {...defaultProps} isOpen={false} />);

		expect(screen.queryByRole("dialog")).toBeNull();
	});

	it("renders modal when open", async () => {
		mockHandleResponse
			.mockResolvedValueOnce({ noteTypes: mockNoteTypes })
			.mockResolvedValueOnce({ noteType: mockNoteTypeWithFields });

		render(<CreateNoteModal {...defaultProps} />);

		expect(screen.getByRole("dialog")).toBeDefined();
		expect(
			screen.getByRole("heading", { name: "Create New Note" }),
		).toBeDefined();

		// Wait for note types to load
		await waitFor(() => {
			expect(screen.getByLabelText("Note Type")).toBeDefined();
		});
	});

	it("loads note types on open", async () => {
		mockHandleResponse
			.mockResolvedValueOnce({ noteTypes: mockNoteTypes })
			.mockResolvedValueOnce({ noteType: mockNoteTypeWithFields });

		render(<CreateNoteModal {...defaultProps} />);

		await waitFor(() => {
			expect(mockNoteTypesGet).toHaveBeenCalled();
		});
	});

	it("auto-selects first note type and loads its fields", async () => {
		mockHandleResponse
			.mockResolvedValueOnce({ noteTypes: mockNoteTypes })
			.mockResolvedValueOnce({ noteType: mockNoteTypeWithFields });

		render(<CreateNoteModal {...defaultProps} />);

		// Wait for fields to be loaded
		await waitFor(() => {
			expect(screen.getByLabelText("Front")).toBeDefined();
			expect(screen.getByLabelText("Back")).toBeDefined();
		});

		// Verify the note type details were fetched
		expect(mockNoteTypeGet).toHaveBeenCalledWith({
			param: { id: "note-type-1" },
		});
	});

	it("displays note type options in select", async () => {
		mockHandleResponse
			.mockResolvedValueOnce({ noteTypes: mockNoteTypes })
			.mockResolvedValueOnce({ noteType: mockNoteTypeWithFields });

		render(<CreateNoteModal {...defaultProps} />);

		await waitFor(() => {
			const select = screen.getByLabelText("Note Type");
			expect(select).toBeDefined();
		});

		const options = screen.getAllByRole("option");
		expect(options).toHaveLength(2);
		expect(options[0]?.textContent).toBe("Basic");
		expect(options[1]?.textContent).toBe("Basic (reversed) (reversed)");
	});

	it("shows message when no note types available", async () => {
		mockHandleResponse.mockResolvedValueOnce({ noteTypes: [] });

		render(<CreateNoteModal {...defaultProps} />);

		await waitFor(() => {
			expect(
				screen.getByText(
					"No note types available. Please create a note type first.",
				),
			).toBeDefined();
		});
	});

	it("shows message when note type has no fields", async () => {
		const noteTypeWithNoFields = {
			...mockNoteTypeWithFields,
			fields: [],
		};

		mockHandleResponse
			.mockResolvedValueOnce({ noteTypes: mockNoteTypes })
			.mockResolvedValueOnce({ noteType: noteTypeWithNoFields });

		render(<CreateNoteModal {...defaultProps} />);

		await waitFor(() => {
			expect(
				screen.getByText(
					"This note type has no fields. Please add fields to the note type first.",
				),
			).toBeDefined();
		});
	});

	it("disables create button when fields are empty", async () => {
		mockHandleResponse
			.mockResolvedValueOnce({ noteTypes: mockNoteTypes })
			.mockResolvedValueOnce({ noteType: mockNoteTypeWithFields });

		render(<CreateNoteModal {...defaultProps} />);

		await waitFor(() => {
			expect(screen.getByLabelText("Front")).toBeDefined();
		});

		const createButton = screen.getByRole("button", { name: "Create Note" });
		expect(createButton).toHaveProperty("disabled", true);
	});

	it("enables create button when all fields have values", async () => {
		const user = userEvent.setup();

		mockHandleResponse
			.mockResolvedValueOnce({ noteTypes: mockNoteTypes })
			.mockResolvedValueOnce({ noteType: mockNoteTypeWithFields });

		render(<CreateNoteModal {...defaultProps} />);

		await waitFor(() => {
			expect(screen.getByLabelText("Front")).toBeDefined();
		});

		await user.type(screen.getByLabelText("Front"), "Question");
		await user.type(screen.getByLabelText("Back"), "Answer");

		const createButton = screen.getByRole("button", { name: "Create Note" });
		expect(createButton).toHaveProperty("disabled", false);
	});

	it("calls onClose when Cancel is clicked", async () => {
		const user = userEvent.setup();
		const onClose = vi.fn();

		mockHandleResponse
			.mockResolvedValueOnce({ noteTypes: mockNoteTypes })
			.mockResolvedValueOnce({ noteType: mockNoteTypeWithFields });

		render(<CreateNoteModal {...defaultProps} onClose={onClose} />);

		await waitFor(() => {
			expect(screen.getByRole("button", { name: "Cancel" })).toBeDefined();
		});

		await user.click(screen.getByRole("button", { name: "Cancel" }));

		expect(onClose).toHaveBeenCalledTimes(1);
	});

	it("calls onClose when clicking outside the modal", async () => {
		const user = userEvent.setup();
		const onClose = vi.fn();

		mockHandleResponse
			.mockResolvedValueOnce({ noteTypes: mockNoteTypes })
			.mockResolvedValueOnce({ noteType: mockNoteTypeWithFields });

		render(<CreateNoteModal {...defaultProps} onClose={onClose} />);

		await waitFor(() => {
			expect(screen.getByRole("dialog")).toBeDefined();
		});

		// Click on the backdrop (the dialog element itself)
		const dialog = screen.getByRole("dialog");
		await user.click(dialog);

		expect(onClose).toHaveBeenCalledTimes(1);
	});

	it("creates note with field values", async () => {
		const user = userEvent.setup();
		const onClose = vi.fn();
		const onNoteCreated = vi.fn();

		mockHandleResponse
			.mockResolvedValueOnce({ noteTypes: mockNoteTypes })
			.mockResolvedValueOnce({ noteType: mockNoteTypeWithFields })
			.mockResolvedValueOnce({
				note: { id: "note-1" },
				fieldValues: [],
				cards: [{ id: "card-1", isReversed: false }],
			});

		render(
			<CreateNoteModal
				isOpen={true}
				deckId="deck-123"
				onClose={onClose}
				onNoteCreated={onNoteCreated}
			/>,
		);

		await waitFor(() => {
			expect(screen.getByLabelText("Front")).toBeDefined();
		});

		await user.type(screen.getByLabelText("Front"), "What is 2+2?");
		await user.type(screen.getByLabelText("Back"), "4");
		await user.click(screen.getByRole("button", { name: "Create Note" }));

		await waitFor(() => {
			expect(mockNotesPost).toHaveBeenCalledWith({
				param: { deckId: "deck-123" },
				json: {
					noteTypeId: "note-type-1",
					fields: {
						"field-1": "What is 2+2?",
						"field-2": "4",
					},
				},
			});
		});

		expect(onNoteCreated).toHaveBeenCalledTimes(1);
		expect(onClose).toHaveBeenCalledTimes(1);
	});

	it("trims whitespace from field values", async () => {
		const user = userEvent.setup();

		mockHandleResponse
			.mockResolvedValueOnce({ noteTypes: mockNoteTypes })
			.mockResolvedValueOnce({ noteType: mockNoteTypeWithFields })
			.mockResolvedValueOnce({
				note: { id: "note-1" },
				fieldValues: [],
				cards: [],
			});

		render(<CreateNoteModal {...defaultProps} />);

		await waitFor(() => {
			expect(screen.getByLabelText("Front")).toBeDefined();
		});

		await user.type(screen.getByLabelText("Front"), "  Question  ");
		await user.type(screen.getByLabelText("Back"), "  Answer  ");
		await user.click(screen.getByRole("button", { name: "Create Note" }));

		await waitFor(() => {
			expect(mockNotesPost).toHaveBeenCalledWith({
				param: { deckId: "deck-123" },
				json: {
					noteTypeId: "note-type-1",
					fields: {
						"field-1": "Question",
						"field-2": "Answer",
					},
				},
			});
		});
	});

	it("shows loading state during submission", async () => {
		const user = userEvent.setup();

		mockHandleResponse
			.mockResolvedValueOnce({ noteTypes: mockNoteTypes })
			.mockResolvedValueOnce({ noteType: mockNoteTypeWithFields });

		mockNotesPost.mockImplementationOnce(() => new Promise(() => {})); // Never resolves

		render(<CreateNoteModal {...defaultProps} />);

		await waitFor(() => {
			expect(screen.getByLabelText("Front")).toBeDefined();
		});

		await user.type(screen.getByLabelText("Front"), "Question");
		await user.type(screen.getByLabelText("Back"), "Answer");
		await user.click(screen.getByRole("button", { name: "Create Note" }));

		expect(screen.getByRole("button", { name: "Creating..." })).toBeDefined();
		expect(screen.getByRole("button", { name: "Creating..." })).toHaveProperty(
			"disabled",
			true,
		);
	});

	it("displays API error message", async () => {
		const user = userEvent.setup();

		mockHandleResponse
			.mockResolvedValueOnce({ noteTypes: mockNoteTypes })
			.mockResolvedValueOnce({ noteType: mockNoteTypeWithFields })
			.mockRejectedValueOnce(new ApiClientError("Note type not found", 400));

		render(<CreateNoteModal {...defaultProps} />);

		await waitFor(() => {
			expect(screen.getByLabelText("Front")).toBeDefined();
		});

		await user.type(screen.getByLabelText("Front"), "Question");
		await user.type(screen.getByLabelText("Back"), "Answer");
		await user.click(screen.getByRole("button", { name: "Create Note" }));

		await waitFor(() => {
			expect(screen.getByRole("alert").textContent).toContain(
				"Note type not found",
			);
		});
	});

	it("displays generic error on unexpected failure", async () => {
		const user = userEvent.setup();

		mockHandleResponse
			.mockResolvedValueOnce({ noteTypes: mockNoteTypes })
			.mockResolvedValueOnce({ noteType: mockNoteTypeWithFields });

		mockNotesPost.mockRejectedValueOnce(new Error("Network error"));

		render(<CreateNoteModal {...defaultProps} />);

		await waitFor(() => {
			expect(screen.getByLabelText("Front")).toBeDefined();
		});

		await user.type(screen.getByLabelText("Front"), "Question");
		await user.type(screen.getByLabelText("Back"), "Answer");
		await user.click(screen.getByRole("button", { name: "Create Note" }));

		await waitFor(() => {
			expect(screen.getByRole("alert").textContent).toContain(
				"Failed to create note. Please try again.",
			);
		});
	});

	it("switches note type and loads new fields", async () => {
		const user = userEvent.setup();

		const reversedNoteType = {
			id: "note-type-2",
			name: "Basic (reversed)",
			frontTemplate: "{{Front}}",
			backTemplate: "{{Back}}",
			isReversible: true,
			fields: [
				{ id: "field-3", name: "Question", order: 0 },
				{ id: "field-4", name: "Answer", order: 1 },
			],
		};

		mockHandleResponse
			.mockResolvedValueOnce({ noteTypes: mockNoteTypes })
			.mockResolvedValueOnce({ noteType: mockNoteTypeWithFields })
			.mockResolvedValueOnce({ noteType: reversedNoteType });

		render(<CreateNoteModal {...defaultProps} />);

		await waitFor(() => {
			expect(screen.getByLabelText("Front")).toBeDefined();
		});

		// Change note type
		const select = screen.getByLabelText("Note Type");
		await user.selectOptions(select, "note-type-2");

		// Wait for new fields to load
		await waitFor(() => {
			expect(screen.getByLabelText("Question")).toBeDefined();
			expect(screen.getByLabelText("Answer")).toBeDefined();
		});

		// Verify the note type details were fetched for the new type
		expect(mockNoteTypeGet).toHaveBeenCalledWith({
			param: { id: "note-type-2" },
		});
	});

	it("shows card count preview for reversible note type", async () => {
		const reversedNoteType = {
			...mockNoteTypeWithFields,
			isReversible: true,
		};

		mockHandleResponse
			.mockResolvedValueOnce({ noteTypes: mockNoteTypes })
			.mockResolvedValueOnce({ noteType: reversedNoteType });

		render(<CreateNoteModal {...defaultProps} />);

		await waitFor(() => {
			expect(screen.getByText("2 cards")).toBeDefined();
			expect(screen.getByText(/normal and reversed/)).toBeDefined();
		});
	});

	it("shows card count preview for non-reversible note type", async () => {
		mockHandleResponse
			.mockResolvedValueOnce({ noteTypes: mockNoteTypes })
			.mockResolvedValueOnce({ noteType: mockNoteTypeWithFields });

		render(<CreateNoteModal {...defaultProps} />);

		await waitFor(() => {
			expect(screen.getByText("1 card")).toBeDefined();
		});
	});

	it("displays error when note types fail to load", async () => {
		mockHandleResponse.mockRejectedValueOnce(
			new ApiClientError("Server error", 500),
		);

		render(<CreateNoteModal {...defaultProps} />);

		await waitFor(() => {
			expect(screen.getByRole("alert").textContent).toContain("Server error");
		});
	});

	it("resets form when closed and reopened", async () => {
		const user = userEvent.setup();
		const onClose = vi.fn();

		mockHandleResponse
			.mockResolvedValueOnce({ noteTypes: mockNoteTypes })
			.mockResolvedValueOnce({ noteType: mockNoteTypeWithFields });

		const { rerender } = render(
			<CreateNoteModal
				isOpen={true}
				deckId="deck-123"
				onClose={onClose}
				onNoteCreated={vi.fn()}
			/>,
		);

		await waitFor(() => {
			expect(screen.getByLabelText("Front")).toBeDefined();
		});

		// Type something in the form
		await user.type(screen.getByLabelText("Front"), "Question");
		await user.type(screen.getByLabelText("Back"), "Answer");

		// Click cancel to close
		await user.click(screen.getByRole("button", { name: "Cancel" }));

		// Note: The component already has note types loaded (hasLoadedNoteTypes = true)
		// so it won't fetch again

		// Reopen the modal
		rerender(
			<CreateNoteModal
				isOpen={true}
				deckId="deck-123"
				onClose={onClose}
				onNoteCreated={vi.fn()}
			/>,
		);

		await waitFor(() => {
			expect(screen.getByLabelText("Front")).toBeDefined();
		});

		// Form should be reset
		expect(screen.getByLabelText("Front")).toHaveProperty("value", "");
		expect(screen.getByLabelText("Back")).toHaveProperty("value", "");
	});
});