aboutsummaryrefslogtreecommitdiffhomepage
path: root/src/client/components/EditDeckModal.test.tsx
blob: fce17f637c49730359a682ff739552aa7fc61dae (plain)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
/**
 * @vitest-environment jsdom
 */
import { cleanup, render, screen, waitFor } from "@testing-library/react";
import userEvent from "@testing-library/user-event";
import { afterEach, beforeEach, describe, expect, it, vi } from "vitest";

const mockPut = vi.fn();
const mockHandleResponse = vi.fn();

vi.mock("../api/client", () => ({
	apiClient: {
		rpc: {
			api: {
				decks: {
					":id": {
						$put: (args: unknown) => mockPut(args),
					},
				},
			},
		},
		handleResponse: (res: unknown) => mockHandleResponse(res),
	},
	ApiClientError: class ApiClientError extends Error {
		constructor(
			message: string,
			public status: number,
			public code?: string,
		) {
			super(message);
			this.name = "ApiClientError";
		}
	},
}));

import { ApiClientError } from "../api/client";
// Import after mock is set up
import { EditDeckModal } from "./EditDeckModal";

describe("EditDeckModal", () => {
	const mockDeck = {
		id: "deck-123",
		name: "Test Deck",
		description: "Test description",
		newCardsPerDay: 20,
	};

	const defaultProps = {
		isOpen: true,
		deck: mockDeck,
		onClose: vi.fn(),
		onDeckUpdated: vi.fn(),
	};

	beforeEach(() => {
		vi.clearAllMocks();
		mockPut.mockResolvedValue({ ok: true });
		mockHandleResponse.mockResolvedValue({
			deck: {
				id: "deck-123",
				name: "Test Deck",
				description: "Test description",
				newCardsPerDay: 20,
			},
		});
	});

	afterEach(() => {
		cleanup();
		vi.restoreAllMocks();
	});

	it("does not render when closed", () => {
		render(<EditDeckModal {...defaultProps} isOpen={false} />);

		expect(screen.queryByRole("dialog")).toBeNull();
	});

	it("does not render when deck is null", () => {
		render(<EditDeckModal {...defaultProps} deck={null} />);

		expect(screen.queryByRole("dialog")).toBeNull();
	});

	it("renders modal when open with deck", () => {
		render(<EditDeckModal {...defaultProps} />);

		expect(screen.getByRole("dialog")).toBeDefined();
		expect(screen.getByRole("heading", { name: "Edit Deck" })).toBeDefined();
		expect(screen.getByLabelText("Name")).toBeDefined();
		expect(screen.getByLabelText("Description (optional)")).toBeDefined();
		expect(screen.getByRole("button", { name: "Cancel" })).toBeDefined();
		expect(screen.getByRole("button", { name: "Save Changes" })).toBeDefined();
	});

	it("populates form with deck values", () => {
		render(<EditDeckModal {...defaultProps} />);

		expect(screen.getByLabelText("Name")).toHaveProperty("value", "Test Deck");
		expect(screen.getByLabelText("Description (optional)")).toHaveProperty(
			"value",
			"Test description",
		);
	});

	it("populates form with empty description when deck description is null", () => {
		const deckWithNullDesc = { ...mockDeck, description: null };
		render(<EditDeckModal {...defaultProps} deck={deckWithNullDesc} />);

		expect(screen.getByLabelText("Description (optional)")).toHaveProperty(
			"value",
			"",
		);
	});

	it("disables save button when name is empty", async () => {
		const user = userEvent.setup();
		render(<EditDeckModal {...defaultProps} />);

		const nameInput = screen.getByLabelText("Name");
		await user.clear(nameInput);

		const saveButton = screen.getByRole("button", { name: "Save Changes" });
		expect(saveButton).toHaveProperty("disabled", true);
	});

	it("enables save button when name has content", () => {
		render(<EditDeckModal {...defaultProps} />);

		const saveButton = screen.getByRole("button", { name: "Save Changes" });
		expect(saveButton).toHaveProperty("disabled", false);
	});

	it("calls onClose when Cancel is clicked", async () => {
		const user = userEvent.setup();
		const onClose = vi.fn();
		render(<EditDeckModal {...defaultProps} onClose={onClose} />);

		await user.click(screen.getByRole("button", { name: "Cancel" }));

		expect(onClose).toHaveBeenCalledTimes(1);
	});

	it("calls onClose when clicking outside the modal", async () => {
		const user = userEvent.setup();
		const onClose = vi.fn();
		render(<EditDeckModal {...defaultProps} onClose={onClose} />);

		// Click on the backdrop (the dialog element itself)
		const dialog = screen.getByRole("dialog");
		await user.click(dialog);

		expect(onClose).toHaveBeenCalledTimes(1);
	});

	it("does not call onClose when clicking inside the modal content", async () => {
		const user = userEvent.setup();
		const onClose = vi.fn();
		render(<EditDeckModal {...defaultProps} onClose={onClose} />);

		// Click on an element inside the modal
		await user.click(screen.getByLabelText("Name"));

		expect(onClose).not.toHaveBeenCalled();
	});

	it("updates deck with new name", async () => {
		const user = userEvent.setup();
		const onClose = vi.fn();
		const onDeckUpdated = vi.fn();

		render(
			<EditDeckModal
				isOpen={true}
				deck={mockDeck}
				onClose={onClose}
				onDeckUpdated={onDeckUpdated}
			/>,
		);

		const nameInput = screen.getByLabelText("Name");
		await user.clear(nameInput);
		await user.type(nameInput, "Updated Deck");
		await user.click(screen.getByRole("button", { name: "Save Changes" }));

		await waitFor(() => {
			expect(mockPut).toHaveBeenCalledWith({
				param: { id: "deck-123" },
				json: {
					name: "Updated Deck",
					description: "Test description",
				},
			});
		});

		expect(onDeckUpdated).toHaveBeenCalledTimes(1);
		expect(onClose).toHaveBeenCalledTimes(1);
	});

	it("updates deck with new description", async () => {
		const user = userEvent.setup();
		const onClose = vi.fn();
		const onDeckUpdated = vi.fn();

		render(
			<EditDeckModal
				isOpen={true}
				deck={mockDeck}
				onClose={onClose}
				onDeckUpdated={onDeckUpdated}
			/>,
		);

		const descInput = screen.getByLabelText("Description (optional)");
		await user.clear(descInput);
		await user.type(descInput, "New description");
		await user.click(screen.getByRole("button", { name: "Save Changes" }));

		await waitFor(() => {
			expect(mockPut).toHaveBeenCalledWith({
				param: { id: "deck-123" },
				json: {
					name: "Test Deck",
					description: "New description",
				},
			});
		});

		expect(onDeckUpdated).toHaveBeenCalledTimes(1);
		expect(onClose).toHaveBeenCalledTimes(1);
	});

	it("clears description when input is emptied", async () => {
		const user = userEvent.setup();

		render(<EditDeckModal {...defaultProps} />);

		const descInput = screen.getByLabelText("Description (optional)");
		await user.clear(descInput);
		await user.click(screen.getByRole("button", { name: "Save Changes" }));

		await waitFor(() => {
			expect(mockPut).toHaveBeenCalledWith({
				param: { id: "deck-123" },
				json: {
					name: "Test Deck",
					description: null,
				},
			});
		});
	});

	it("trims whitespace from name and description", async () => {
		const user = userEvent.setup();

		const deckWithWhitespace = {
			...mockDeck,
			name: "  Deck  ",
			description: "  Description  ",
		};
		render(<EditDeckModal {...defaultProps} deck={deckWithWhitespace} />);

		await user.click(screen.getByRole("button", { name: "Save Changes" }));

		await waitFor(() => {
			expect(mockPut).toHaveBeenCalledWith({
				param: { id: "deck-123" },
				json: {
					name: "Deck",
					description: "Description",
				},
			});
		});
	});

	it("shows loading state during submission", async () => {
		const user = userEvent.setup();

		mockPut.mockImplementation(() => new Promise(() => {})); // Never resolves

		render(<EditDeckModal {...defaultProps} />);

		await user.click(screen.getByRole("button", { name: "Save Changes" }));

		expect(screen.getByRole("button", { name: "Saving..." })).toBeDefined();
		expect(screen.getByRole("button", { name: "Saving..." })).toHaveProperty(
			"disabled",
			true,
		);
		expect(screen.getByRole("button", { name: "Cancel" })).toHaveProperty(
			"disabled",
			true,
		);
		expect(screen.getByLabelText("Name")).toHaveProperty("disabled", true);
		expect(screen.getByLabelText("Description (optional)")).toHaveProperty(
			"disabled",
			true,
		);
	});

	it("displays API error message", async () => {
		const user = userEvent.setup();

		mockHandleResponse.mockRejectedValue(
			new ApiClientError("Deck name already exists", 400),
		);

		render(<EditDeckModal {...defaultProps} />);

		await user.click(screen.getByRole("button", { name: "Save Changes" }));

		await waitFor(() => {
			expect(screen.getByRole("alert").textContent).toContain(
				"Deck name already exists",
			);
		});
	});

	it("displays generic error on unexpected failure", async () => {
		const user = userEvent.setup();

		mockPut.mockRejectedValue(new Error("Network error"));

		render(<EditDeckModal {...defaultProps} />);

		await user.click(screen.getByRole("button", { name: "Save Changes" }));

		await waitFor(() => {
			expect(screen.getByRole("alert").textContent).toContain(
				"Failed to update deck. Please try again.",
			);
		});
	});

	it("displays error when handleResponse throws", async () => {
		const user = userEvent.setup();

		mockHandleResponse.mockRejectedValue(
			new ApiClientError("Not authenticated", 401),
		);

		render(<EditDeckModal {...defaultProps} />);

		await user.click(screen.getByRole("button", { name: "Save Changes" }));

		await waitFor(() => {
			expect(screen.getByRole("alert").textContent).toContain(
				"Not authenticated",
			);
		});
	});

	it("updates form when deck prop changes", () => {
		const { rerender } = render(<EditDeckModal {...defaultProps} />);

		expect(screen.getByLabelText("Name")).toHaveProperty("value", "Test Deck");

		const newDeck = {
			...mockDeck,
			name: "New Deck Name",
			description: "New description",
		};
		rerender(<EditDeckModal {...defaultProps} deck={newDeck} />);

		expect(screen.getByLabelText("Name")).toHaveProperty(
			"value",
			"New Deck Name",
		);
		expect(screen.getByLabelText("Description (optional)")).toHaveProperty(
			"value",
			"New description",
		);
	});

	it("clears error when modal is closed", async () => {
		const user = userEvent.setup();
		const onClose = vi.fn();

		mockHandleResponse.mockRejectedValue(new ApiClientError("Some error", 400));

		const { rerender } = render(
			<EditDeckModal {...defaultProps} onClose={onClose} />,
		);

		// Trigger error
		await user.click(screen.getByRole("button", { name: "Save Changes" }));
		await waitFor(() => {
			expect(screen.getByRole("alert")).toBeDefined();
		});

		// Close and reopen the modal
		await user.click(screen.getByRole("button", { name: "Cancel" }));
		rerender(<EditDeckModal {...defaultProps} onClose={onClose} />);

		// Error should be cleared
		expect(screen.queryByRole("alert")).toBeNull();
	});
});