aboutsummaryrefslogtreecommitdiffhomepage
path: root/src/client/components/EditNoteModal.test.tsx
blob: 61f94bde4eaccc3253b4c56fc3c792377bead542 (plain)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
/**
 * @vitest-environment jsdom
 */
import { cleanup, render, screen, waitFor } from "@testing-library/react";
import userEvent from "@testing-library/user-event";
import { afterEach, beforeEach, describe, expect, it, vi } from "vitest";
import { apiClient } from "../api/client";

vi.mock("../api/client", () => ({
	apiClient: {
		getAuthHeader: vi.fn(),
	},
	ApiClientError: class ApiClientError extends Error {
		constructor(
			message: string,
			public status: number,
			public code?: string,
		) {
			super(message);
			this.name = "ApiClientError";
		}
	},
}));

// Import after mock is set up
import { EditNoteModal } from "./EditNoteModal";

// Mock fetch globally
const mockFetch = vi.fn();
global.fetch = mockFetch;

describe("EditNoteModal", () => {
	const defaultProps = {
		isOpen: true,
		deckId: "deck-123",
		noteId: "note-456",
		onClose: vi.fn(),
		onNoteUpdated: vi.fn(),
	};

	const mockNoteWithFieldValues = {
		id: "note-456",
		deckId: "deck-123",
		noteTypeId: "note-type-1",
		fieldValues: [
			{
				id: "fv-1",
				noteId: "note-456",
				noteFieldTypeId: "field-1",
				value: "Existing front",
			},
			{
				id: "fv-2",
				noteId: "note-456",
				noteFieldTypeId: "field-2",
				value: "Existing back",
			},
		],
	};

	const mockNoteTypeWithFields = {
		id: "note-type-1",
		name: "Basic",
		frontTemplate: "{{Front}}",
		backTemplate: "{{Back}}",
		isReversible: false,
		fields: [
			{ id: "field-1", name: "Front", order: 0 },
			{ id: "field-2", name: "Back", order: 1 },
		],
	};

	beforeEach(() => {
		vi.clearAllMocks();
		vi.mocked(apiClient.getAuthHeader).mockReturnValue({
			Authorization: "Bearer access-token",
		});
	});

	afterEach(() => {
		cleanup();
		vi.restoreAllMocks();
	});

	it("does not render when closed", () => {
		render(<EditNoteModal {...defaultProps} isOpen={false} />);

		expect(screen.queryByRole("dialog")).toBeNull();
	});

	it("does not render when noteId is null", () => {
		render(<EditNoteModal {...defaultProps} noteId={null} />);

		expect(screen.queryByRole("dialog")).toBeNull();
	});

	it("renders modal when open with noteId", async () => {
		mockFetch
			.mockResolvedValueOnce({
				ok: true,
				json: async () => ({ note: mockNoteWithFieldValues }),
			})
			.mockResolvedValueOnce({
				ok: true,
				json: async () => ({ noteType: mockNoteTypeWithFields }),
			});

		render(<EditNoteModal {...defaultProps} />);

		expect(screen.getByRole("dialog")).toBeDefined();
		expect(screen.getByRole("heading", { name: "Edit Note" })).toBeDefined();

		// Wait for fields to load
		await waitFor(() => {
			expect(screen.getByLabelText("Front")).toBeDefined();
		});
	});

	it("fetches note and note type on open", async () => {
		mockFetch
			.mockResolvedValueOnce({
				ok: true,
				json: async () => ({ note: mockNoteWithFieldValues }),
			})
			.mockResolvedValueOnce({
				ok: true,
				json: async () => ({ noteType: mockNoteTypeWithFields }),
			});

		render(<EditNoteModal {...defaultProps} />);

		await waitFor(() => {
			expect(mockFetch).toHaveBeenCalledWith(
				"/api/decks/deck-123/notes/note-456",
				{
					headers: { Authorization: "Bearer access-token" },
				},
			);
		});

		await waitFor(() => {
			expect(mockFetch).toHaveBeenCalledWith("/api/note-types/note-type-1", {
				headers: { Authorization: "Bearer access-token" },
			});
		});
	});

	it("populates form with note field values", async () => {
		mockFetch
			.mockResolvedValueOnce({
				ok: true,
				json: async () => ({ note: mockNoteWithFieldValues }),
			})
			.mockResolvedValueOnce({
				ok: true,
				json: async () => ({ noteType: mockNoteTypeWithFields }),
			});

		render(<EditNoteModal {...defaultProps} />);

		await waitFor(() => {
			expect(screen.getByLabelText("Front")).toHaveProperty(
				"value",
				"Existing front",
			);
			expect(screen.getByLabelText("Back")).toHaveProperty(
				"value",
				"Existing back",
			);
		});
	});

	it("displays note type name (read-only)", async () => {
		mockFetch
			.mockResolvedValueOnce({
				ok: true,
				json: async () => ({ note: mockNoteWithFieldValues }),
			})
			.mockResolvedValueOnce({
				ok: true,
				json: async () => ({ noteType: mockNoteTypeWithFields }),
			});

		render(<EditNoteModal {...defaultProps} />);

		await waitFor(() => {
			expect(screen.getByText("Basic")).toBeDefined();
		});
	});

	it("disables save button when fields are empty", async () => {
		const user = userEvent.setup();

		mockFetch
			.mockResolvedValueOnce({
				ok: true,
				json: async () => ({ note: mockNoteWithFieldValues }),
			})
			.mockResolvedValueOnce({
				ok: true,
				json: async () => ({ noteType: mockNoteTypeWithFields }),
			});

		render(<EditNoteModal {...defaultProps} />);

		await waitFor(() => {
			expect(screen.getByLabelText("Front")).toBeDefined();
		});

		// Clear front field
		const frontInput = screen.getByLabelText("Front");
		await user.clear(frontInput);

		const saveButton = screen.getByRole("button", { name: "Save Changes" });
		expect(saveButton).toHaveProperty("disabled", true);
	});

	it("enables save button when all fields have values", async () => {
		mockFetch
			.mockResolvedValueOnce({
				ok: true,
				json: async () => ({ note: mockNoteWithFieldValues }),
			})
			.mockResolvedValueOnce({
				ok: true,
				json: async () => ({ noteType: mockNoteTypeWithFields }),
			});

		render(<EditNoteModal {...defaultProps} />);

		await waitFor(() => {
			expect(screen.getByLabelText("Front")).toBeDefined();
		});

		const saveButton = screen.getByRole("button", { name: "Save Changes" });
		expect(saveButton).toHaveProperty("disabled", false);
	});

	it("calls onClose when Cancel is clicked", async () => {
		const user = userEvent.setup();
		const onClose = vi.fn();

		mockFetch
			.mockResolvedValueOnce({
				ok: true,
				json: async () => ({ note: mockNoteWithFieldValues }),
			})
			.mockResolvedValueOnce({
				ok: true,
				json: async () => ({ noteType: mockNoteTypeWithFields }),
			});

		render(<EditNoteModal {...defaultProps} onClose={onClose} />);

		await waitFor(() => {
			expect(screen.getByRole("button", { name: "Cancel" })).toBeDefined();
		});

		await user.click(screen.getByRole("button", { name: "Cancel" }));

		expect(onClose).toHaveBeenCalledTimes(1);
	});

	it("calls onClose when clicking outside the modal", async () => {
		const user = userEvent.setup();
		const onClose = vi.fn();

		mockFetch
			.mockResolvedValueOnce({
				ok: true,
				json: async () => ({ note: mockNoteWithFieldValues }),
			})
			.mockResolvedValueOnce({
				ok: true,
				json: async () => ({ noteType: mockNoteTypeWithFields }),
			});

		render(<EditNoteModal {...defaultProps} onClose={onClose} />);

		await waitFor(() => {
			expect(screen.getByRole("dialog")).toBeDefined();
		});

		// Click on the backdrop (the dialog element itself)
		const dialog = screen.getByRole("dialog");
		await user.click(dialog);

		expect(onClose).toHaveBeenCalledTimes(1);
	});

	it("updates note with new field values", async () => {
		const user = userEvent.setup();
		const onClose = vi.fn();
		const onNoteUpdated = vi.fn();

		mockFetch
			.mockResolvedValueOnce({
				ok: true,
				json: async () => ({ note: mockNoteWithFieldValues }),
			})
			.mockResolvedValueOnce({
				ok: true,
				json: async () => ({ noteType: mockNoteTypeWithFields }),
			})
			.mockResolvedValueOnce({
				ok: true,
				json: async () => ({ note: mockNoteWithFieldValues }),
			});

		render(
			<EditNoteModal
				isOpen={true}
				deckId="deck-123"
				noteId="note-456"
				onClose={onClose}
				onNoteUpdated={onNoteUpdated}
			/>,
		);

		await waitFor(() => {
			expect(screen.getByLabelText("Front")).toBeDefined();
		});

		const frontInput = screen.getByLabelText("Front");
		await user.clear(frontInput);
		await user.type(frontInput, "Updated front");
		await user.click(screen.getByRole("button", { name: "Save Changes" }));

		await waitFor(() => {
			expect(mockFetch).toHaveBeenCalledWith(
				"/api/decks/deck-123/notes/note-456",
				{
					method: "PUT",
					headers: {
						"Content-Type": "application/json",
						Authorization: "Bearer access-token",
					},
					body: JSON.stringify({
						fields: {
							"field-1": "Updated front",
							"field-2": "Existing back",
						},
					}),
				},
			);
		});

		expect(onNoteUpdated).toHaveBeenCalledTimes(1);
		expect(onClose).toHaveBeenCalledTimes(1);
	});

	it("trims whitespace from field values", async () => {
		const user = userEvent.setup();

		const noteWithWhitespace = {
			...mockNoteWithFieldValues,
			fieldValues: [
				{
					id: "fv-1",
					noteId: "note-456",
					noteFieldTypeId: "field-1",
					value: "  Trimmed  ",
				},
				{
					id: "fv-2",
					noteId: "note-456",
					noteFieldTypeId: "field-2",
					value: "  Value  ",
				},
			],
		};

		mockFetch
			.mockResolvedValueOnce({
				ok: true,
				json: async () => ({ note: noteWithWhitespace }),
			})
			.mockResolvedValueOnce({
				ok: true,
				json: async () => ({ noteType: mockNoteTypeWithFields }),
			})
			.mockResolvedValueOnce({
				ok: true,
				json: async () => ({ note: noteWithWhitespace }),
			});

		render(<EditNoteModal {...defaultProps} />);

		await waitFor(() => {
			expect(screen.getByLabelText("Front")).toBeDefined();
		});

		await user.click(screen.getByRole("button", { name: "Save Changes" }));

		await waitFor(() => {
			expect(mockFetch).toHaveBeenCalledWith(
				"/api/decks/deck-123/notes/note-456",
				{
					method: "PUT",
					headers: {
						"Content-Type": "application/json",
						Authorization: "Bearer access-token",
					},
					body: JSON.stringify({
						fields: {
							"field-1": "Trimmed",
							"field-2": "Value",
						},
					}),
				},
			);
		});
	});

	it("shows loading state during fetch", async () => {
		mockFetch.mockImplementationOnce(() => new Promise(() => {})); // Never resolves

		render(<EditNoteModal {...defaultProps} />);

		expect(screen.getByText("Loading note...")).toBeDefined();
	});

	it("shows loading state during submission", async () => {
		const user = userEvent.setup();

		mockFetch
			.mockResolvedValueOnce({
				ok: true,
				json: async () => ({ note: mockNoteWithFieldValues }),
			})
			.mockResolvedValueOnce({
				ok: true,
				json: async () => ({ noteType: mockNoteTypeWithFields }),
			})
			.mockImplementationOnce(() => new Promise(() => {})); // Never resolves

		render(<EditNoteModal {...defaultProps} />);

		await waitFor(() => {
			expect(screen.getByLabelText("Front")).toBeDefined();
		});

		await user.click(screen.getByRole("button", { name: "Save Changes" }));

		expect(screen.getByRole("button", { name: "Saving..." })).toBeDefined();
		expect(screen.getByRole("button", { name: "Saving..." })).toHaveProperty(
			"disabled",
			true,
		);
	});

	it("displays API error message when note fetch fails", async () => {
		mockFetch.mockResolvedValueOnce({
			ok: false,
			status: 404,
			json: async () => ({ error: "Note not found" }),
		});

		render(<EditNoteModal {...defaultProps} />);

		await waitFor(() => {
			expect(screen.getByRole("alert").textContent).toContain("Note not found");
		});
	});

	it("displays API error message when note type fetch fails", async () => {
		mockFetch
			.mockResolvedValueOnce({
				ok: true,
				json: async () => ({ note: mockNoteWithFieldValues }),
			})
			.mockResolvedValueOnce({
				ok: false,
				status: 404,
				json: async () => ({ error: "Note type not found" }),
			});

		render(<EditNoteModal {...defaultProps} />);

		await waitFor(() => {
			expect(screen.getByRole("alert").textContent).toContain(
				"Note type not found",
			);
		});
	});

	it("displays API error message when update fails", async () => {
		const user = userEvent.setup();

		mockFetch
			.mockResolvedValueOnce({
				ok: true,
				json: async () => ({ note: mockNoteWithFieldValues }),
			})
			.mockResolvedValueOnce({
				ok: true,
				json: async () => ({ noteType: mockNoteTypeWithFields }),
			})
			.mockResolvedValueOnce({
				ok: false,
				status: 400,
				json: async () => ({ error: "Failed to update note" }),
			});

		render(<EditNoteModal {...defaultProps} />);

		await waitFor(() => {
			expect(screen.getByLabelText("Front")).toBeDefined();
		});

		await user.click(screen.getByRole("button", { name: "Save Changes" }));

		await waitFor(() => {
			expect(screen.getByRole("alert").textContent).toContain(
				"Failed to update note",
			);
		});
	});

	it("displays generic error on unexpected failure", async () => {
		mockFetch.mockRejectedValueOnce(new Error("Network error"));

		render(<EditNoteModal {...defaultProps} />);

		await waitFor(() => {
			expect(screen.getByRole("alert").textContent).toContain(
				"Failed to load note. Please try again.",
			);
		});
	});

	it("displays error when not authenticated", async () => {
		vi.mocked(apiClient.getAuthHeader).mockReturnValue(undefined);

		render(<EditNoteModal {...defaultProps} />);

		await waitFor(() => {
			expect(screen.getByRole("alert").textContent).toContain(
				"Not authenticated",
			);
		});
	});

	it("resets form when modal is closed and reopened with different noteId", async () => {
		const onClose = vi.fn();

		mockFetch
			.mockResolvedValueOnce({
				ok: true,
				json: async () => ({ note: mockNoteWithFieldValues }),
			})
			.mockResolvedValueOnce({
				ok: true,
				json: async () => ({ noteType: mockNoteTypeWithFields }),
			});

		const { rerender } = render(
			<EditNoteModal
				isOpen={true}
				deckId="deck-123"
				noteId="note-456"
				onClose={onClose}
				onNoteUpdated={vi.fn()}
			/>,
		);

		await waitFor(() => {
			expect(screen.getByLabelText("Front")).toHaveProperty(
				"value",
				"Existing front",
			);
		});

		// Close modal
		rerender(
			<EditNoteModal
				isOpen={false}
				deckId="deck-123"
				noteId={null}
				onClose={onClose}
				onNoteUpdated={vi.fn()}
			/>,
		);

		// Setup new note data
		const newNoteWithFieldValues = {
			id: "note-789",
			deckId: "deck-123",
			noteTypeId: "note-type-1",
			fieldValues: [
				{
					id: "fv-3",
					noteId: "note-789",
					noteFieldTypeId: "field-1",
					value: "New front",
				},
				{
					id: "fv-4",
					noteId: "note-789",
					noteFieldTypeId: "field-2",
					value: "New back",
				},
			],
		};

		mockFetch
			.mockResolvedValueOnce({
				ok: true,
				json: async () => ({ note: newNoteWithFieldValues }),
			})
			.mockResolvedValueOnce({
				ok: true,
				json: async () => ({ noteType: mockNoteTypeWithFields }),
			});

		// Reopen with different noteId
		rerender(
			<EditNoteModal
				isOpen={true}
				deckId="deck-123"
				noteId="note-789"
				onClose={onClose}
				onNoteUpdated={vi.fn()}
			/>,
		);

		await waitFor(() => {
			expect(screen.getByLabelText("Front")).toHaveProperty(
				"value",
				"New front",
			);
			expect(screen.getByLabelText("Back")).toHaveProperty("value", "New back");
		});
	});

	it("shows reversed indicator for reversible note type", async () => {
		const reversibleNoteType = {
			...mockNoteTypeWithFields,
			isReversible: true,
		};

		mockFetch
			.mockResolvedValueOnce({
				ok: true,
				json: async () => ({ note: mockNoteWithFieldValues }),
			})
			.mockResolvedValueOnce({
				ok: true,
				json: async () => ({ noteType: reversibleNoteType }),
			});

		render(<EditNoteModal {...defaultProps} />);

		await waitFor(() => {
			expect(screen.getByText("Basic (reversed)")).toBeDefined();
		});
	});
});