1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
|
import { describe, expect, it, vi } from "vitest";
import type {
Card,
CardForStudy,
CardRepository,
CardWithNoteData,
Note,
NoteFieldValue,
} from "./types.js";
function createMockCard(overrides: Partial<Card> = {}): Card {
return {
id: "card-uuid-123",
deckId: "deck-uuid-123",
noteId: "note-uuid-123",
isReversed: false,
front: "Front text",
back: "Back text",
state: 0,
due: new Date("2024-01-01"),
stability: 0,
difficulty: 0,
elapsedDays: 0,
scheduledDays: 0,
reps: 0,
lapses: 0,
lastReview: null,
createdAt: new Date("2024-01-01"),
updatedAt: new Date("2024-01-01"),
deletedAt: null,
syncVersion: 0,
...overrides,
};
}
function createMockNote(overrides: Partial<Note> = {}): Note {
return {
id: "note-uuid-123",
deckId: "deck-uuid-123",
noteTypeId: "note-type-uuid-123",
createdAt: new Date("2024-01-01"),
updatedAt: new Date("2024-01-01"),
deletedAt: null,
syncVersion: 0,
...overrides,
};
}
function createMockNoteFieldValue(
overrides: Partial<NoteFieldValue> = {},
): NoteFieldValue {
return {
id: "field-value-uuid-123",
noteId: "note-uuid-123",
noteFieldTypeId: "field-type-uuid-123",
value: "Test value",
createdAt: new Date("2024-01-01"),
updatedAt: new Date("2024-01-01"),
syncVersion: 0,
...overrides,
};
}
function createMockCardWithNoteData(
overrides: Partial<CardWithNoteData> = {},
): CardWithNoteData {
const card = createMockCard({
noteId: "note-uuid-123",
isReversed: false,
...overrides,
});
return {
...card,
note: overrides.note ?? createMockNote(),
fieldValues: overrides.fieldValues ?? [
createMockNoteFieldValue({
noteFieldTypeId: "field-front",
value: "Question",
}),
createMockNoteFieldValue({
id: "field-value-uuid-456",
noteFieldTypeId: "field-back",
value: "Answer",
}),
],
};
}
function createMockCardForStudy(
overrides: Partial<CardForStudy> = {},
): CardForStudy {
const card = createMockCard(overrides);
return {
...card,
noteType: overrides.noteType ?? {
frontTemplate: "{{Front}}",
backTemplate: "{{Back}}",
},
fieldValuesMap: overrides.fieldValuesMap ?? { Front: "Q", Back: "A" },
};
}
function createMockCardRepo(): CardRepository {
return {
findByDeckId: vi.fn(),
findById: vi.fn(),
findByIdWithNoteData: vi.fn(),
findByNoteId: vi.fn(),
create: vi.fn(),
update: vi.fn(),
softDelete: vi.fn(),
softDeleteByNoteId: vi.fn(),
findDueCards: vi.fn(),
findDueCardsWithNoteData: vi.fn(),
findDueCardsForStudy: vi.fn(),
updateFSRSFields: vi.fn(),
};
}
describe("CardRepository mock factory", () => {
describe("createMockCard", () => {
it("creates a valid Card with defaults", () => {
const card = createMockCard();
expect(card.id).toBe("card-uuid-123");
expect(card.deckId).toBe("deck-uuid-123");
expect(card.noteId).toBe("note-uuid-123");
expect(card.isReversed).toBe(false);
expect(card.front).toBe("Front text");
expect(card.back).toBe("Back text");
expect(card.state).toBe(0);
expect(card.deletedAt).toBeNull();
expect(card.syncVersion).toBe(0);
});
it("allows overriding properties", () => {
const card = createMockCard({
id: "custom-id",
noteId: "note-uuid-456",
isReversed: true,
front: "Custom front",
});
expect(card.id).toBe("custom-id");
expect(card.noteId).toBe("note-uuid-456");
expect(card.isReversed).toBe(true);
expect(card.front).toBe("Custom front");
});
it("creates card with note association", () => {
const card = createMockCard({
noteId: "note-uuid-123",
isReversed: false,
});
expect(card.noteId).toBe("note-uuid-123");
expect(card.isReversed).toBe(false);
});
it("creates reversed card", () => {
const card = createMockCard({
noteId: "note-uuid-123",
isReversed: true,
});
expect(card.noteId).toBe("note-uuid-123");
expect(card.isReversed).toBe(true);
});
});
describe("createMockCardWithNoteData", () => {
it("creates CardWithNoteData with defaults", () => {
const cardWithNote = createMockCardWithNoteData();
expect(cardWithNote.noteId).toBe("note-uuid-123");
expect(cardWithNote.isReversed).toBe(false);
expect(cardWithNote.note).toBeDefined();
expect(cardWithNote.note?.id).toBe("note-uuid-123");
expect(cardWithNote.fieldValues).toHaveLength(2);
});
it("allows overriding note", () => {
const customNote = createMockNote({
id: "custom-note-id",
noteTypeId: "custom-note-type",
});
const cardWithNote = createMockCardWithNoteData({
note: customNote,
});
expect(cardWithNote.note?.id).toBe("custom-note-id");
expect(cardWithNote.note?.noteTypeId).toBe("custom-note-type");
});
it("allows overriding field values", () => {
const customFieldValues = [
createMockNoteFieldValue({ noteFieldTypeId: "word", value: "日本語" }),
];
const cardWithNote = createMockCardWithNoteData({
fieldValues: customFieldValues,
});
expect(cardWithNote.fieldValues).toHaveLength(1);
expect(cardWithNote.fieldValues[0]?.value).toBe("日本語");
});
it("card always has note association", () => {
// All cards now require note association
const cardWithNote = createMockCardWithNoteData();
expect(cardWithNote.noteId).toBe("note-uuid-123");
expect(cardWithNote.note).not.toBeNull();
expect(cardWithNote.fieldValues).toHaveLength(2);
});
});
describe("createMockCardRepo", () => {
it("creates a repository with all required methods", () => {
const repo = createMockCardRepo();
expect(repo.findByDeckId).toBeDefined();
expect(repo.findById).toBeDefined();
expect(repo.findByIdWithNoteData).toBeDefined();
expect(repo.findByNoteId).toBeDefined();
expect(repo.create).toBeDefined();
expect(repo.update).toBeDefined();
expect(repo.softDelete).toBeDefined();
expect(repo.softDeleteByNoteId).toBeDefined();
expect(repo.findDueCards).toBeDefined();
expect(repo.updateFSRSFields).toBeDefined();
});
it("methods are mockable for findByDeckId", async () => {
const repo = createMockCardRepo();
const mockCards = [createMockCard(), createMockCard({ id: "card-2" })];
vi.mocked(repo.findByDeckId).mockResolvedValue(mockCards);
const results = await repo.findByDeckId("deck-123");
expect(results).toHaveLength(2);
expect(repo.findByDeckId).toHaveBeenCalledWith("deck-123");
});
it("methods are mockable for findById", async () => {
const repo = createMockCardRepo();
const mockCard = createMockCard();
vi.mocked(repo.findById).mockResolvedValue(mockCard);
const found = await repo.findById("card-id", "deck-id");
expect(found).toEqual(mockCard);
expect(repo.findById).toHaveBeenCalledWith("card-id", "deck-id");
});
it("methods are mockable for findByIdWithNoteData", async () => {
const repo = createMockCardRepo();
const mockCardWithNote = createMockCardWithNoteData();
vi.mocked(repo.findByIdWithNoteData).mockResolvedValue(mockCardWithNote);
const found = await repo.findByIdWithNoteData("card-id", "deck-id");
expect(found?.note).toBeDefined();
expect(found?.fieldValues).toHaveLength(2);
expect(repo.findByIdWithNoteData).toHaveBeenCalledWith(
"card-id",
"deck-id",
);
});
it("methods are mockable for findByNoteId", async () => {
const repo = createMockCardRepo();
const mockCards = [
createMockCard({ id: "card-1", isReversed: false }),
createMockCard({ id: "card-2", isReversed: true }),
];
vi.mocked(repo.findByNoteId).mockResolvedValue(mockCards);
const found = await repo.findByNoteId("note-id");
expect(found).toHaveLength(2);
expect(found[0]?.isReversed).toBe(false);
expect(found[1]?.isReversed).toBe(true);
expect(repo.findByNoteId).toHaveBeenCalledWith("note-id");
});
it("methods are mockable for softDeleteByNoteId", async () => {
const repo = createMockCardRepo();
vi.mocked(repo.softDeleteByNoteId).mockResolvedValue(true);
const deleted = await repo.softDeleteByNoteId("note-id");
expect(deleted).toBe(true);
expect(repo.softDeleteByNoteId).toHaveBeenCalledWith("note-id");
});
it("returns undefined when card not found", async () => {
const repo = createMockCardRepo();
vi.mocked(repo.findById).mockResolvedValue(undefined);
vi.mocked(repo.findByIdWithNoteData).mockResolvedValue(undefined);
expect(await repo.findById("nonexistent", "deck-id")).toBeUndefined();
expect(
await repo.findByIdWithNoteData("nonexistent", "deck-id"),
).toBeUndefined();
});
it("returns false when soft delete fails", async () => {
const repo = createMockCardRepo();
vi.mocked(repo.softDelete).mockResolvedValue(false);
vi.mocked(repo.softDeleteByNoteId).mockResolvedValue(false);
expect(await repo.softDelete("nonexistent", "deck-id")).toBe(false);
expect(await repo.softDeleteByNoteId("nonexistent")).toBe(false);
});
it("returns empty array when no cards found for note", async () => {
const repo = createMockCardRepo();
vi.mocked(repo.findByNoteId).mockResolvedValue([]);
const found = await repo.findByNoteId("nonexistent-note");
expect(found).toHaveLength(0);
});
});
});
describe("Card interface contracts", () => {
it("Card has required sync fields", () => {
const card = createMockCard();
expect(card).toHaveProperty("syncVersion");
expect(card).toHaveProperty("createdAt");
expect(card).toHaveProperty("updatedAt");
expect(card).toHaveProperty("deletedAt");
});
it("Card has required note association fields", () => {
const card = createMockCard();
expect(card).toHaveProperty("noteId");
expect(card).toHaveProperty("isReversed");
});
it("Card has required FSRS fields", () => {
const card = createMockCard();
expect(card).toHaveProperty("state");
expect(card).toHaveProperty("due");
expect(card).toHaveProperty("stability");
expect(card).toHaveProperty("difficulty");
expect(card).toHaveProperty("elapsedDays");
expect(card).toHaveProperty("scheduledDays");
expect(card).toHaveProperty("reps");
expect(card).toHaveProperty("lapses");
expect(card).toHaveProperty("lastReview");
});
it("CardWithNoteData extends Card with note and fieldValues", () => {
const cardWithNote = createMockCardWithNoteData();
expect(cardWithNote).toHaveProperty("id");
expect(cardWithNote).toHaveProperty("deckId");
expect(cardWithNote).toHaveProperty("note");
expect(cardWithNote).toHaveProperty("fieldValues");
expect(Array.isArray(cardWithNote.fieldValues)).toBe(true);
});
it("CardForStudy extends Card with noteType and fieldValuesMap", () => {
const cardForStudy = createMockCardForStudy({
noteType: {
frontTemplate: "{{Front}}",
backTemplate: "{{Back}}",
},
fieldValuesMap: {
Front: "Question",
Back: "Answer",
},
});
expect(cardForStudy).toHaveProperty("id");
expect(cardForStudy).toHaveProperty("deckId");
expect(cardForStudy).toHaveProperty("noteType");
expect(cardForStudy).toHaveProperty("fieldValuesMap");
expect(cardForStudy.noteType?.frontTemplate).toBe("{{Front}}");
expect(cardForStudy.fieldValuesMap.Front).toBe("Question");
});
it("CardForStudy has required note data", () => {
const cardForStudy = createMockCardForStudy({
front: "Question",
back: "Answer",
});
expect(cardForStudy.noteId).toBe("note-uuid-123");
expect(cardForStudy.noteType).not.toBeNull();
expect(cardForStudy.noteType.frontTemplate).toBe("{{Front}}");
expect(cardForStudy.fieldValuesMap).toEqual({ Front: "Q", Back: "A" });
});
});
describe("Card and Note relationship", () => {
it("card has required noteId and isReversed", () => {
const card = createMockCard();
expect(card.noteId).toBe("note-uuid-123");
expect(card.isReversed).toBe(false);
});
it("card with explicit note data", () => {
const card = createMockCard({
noteId: "different-note-id",
isReversed: false,
});
expect(card.noteId).toBe("different-note-id");
expect(card.isReversed).toBe(false);
});
it("reversed card has isReversed true", () => {
const card = createMockCard({
isReversed: true,
});
expect(card.noteId).toBe("note-uuid-123");
expect(card.isReversed).toBe(true);
});
it("multiple cards can reference the same note", () => {
const normalCard = createMockCard({
id: "card-normal",
noteId: "shared-note-id",
isReversed: false,
});
const reversedCard = createMockCard({
id: "card-reversed",
noteId: "shared-note-id",
isReversed: true,
});
expect(normalCard.noteId).toBe(reversedCard.noteId);
expect(normalCard.isReversed).toBe(false);
expect(reversedCard.isReversed).toBe(true);
});
});
describe("Card deletion behavior", () => {
describe("softDelete cascades to Note and sibling Cards", () => {
it("when a card is deleted, it also deletes the parent Note", async () => {
// This test documents the expected behavior:
// Deleting a card should also soft-delete its parent Note
const repo = createMockCardRepo();
const card = createMockCard({ id: "card-1", noteId: "note-1" });
// The implementation first finds the card to get noteId
vi.mocked(repo.findById).mockResolvedValue(card);
vi.mocked(repo.softDelete).mockResolvedValue(true);
const deleted = await repo.softDelete("card-1", "deck-1");
expect(deleted).toBe(true);
expect(repo.softDelete).toHaveBeenCalledWith("card-1", "deck-1");
});
it("when a card is deleted, sibling cards (same noteId) should also be deleted", async () => {
// This test documents the expected behavior:
// A reversible note creates 2 cards with the same noteId.
// When one card is deleted, both cards should be soft-deleted.
const repo = createMockCardRepo();
const normalCard = createMockCard({
id: "card-normal",
noteId: "shared-note",
isReversed: false,
});
const reversedCard = createMockCard({
id: "card-reversed",
noteId: "shared-note",
isReversed: true,
});
// Before deletion: both cards exist
vi.mocked(repo.findByNoteId).mockResolvedValue([
normalCard,
reversedCard,
]);
expect((await repo.findByNoteId("shared-note")).length).toBe(2);
// After deleting one card, both should be deleted
vi.mocked(repo.softDelete).mockResolvedValue(true);
const deleted = await repo.softDelete("card-normal", "deck-1");
expect(deleted).toBe(true);
});
it("deleting non-existent card returns false", async () => {
const repo = createMockCardRepo();
vi.mocked(repo.findById).mockResolvedValue(undefined);
vi.mocked(repo.softDelete).mockResolvedValue(false);
const deleted = await repo.softDelete("nonexistent", "deck-1");
expect(deleted).toBe(false);
});
});
});
|