aboutsummaryrefslogtreecommitdiffhomepage
path: root/crates/mozart-sat-resolver/src/pool.rs
diff options
context:
space:
mode:
authornsfisis <nsfisis@gmail.com>2026-05-03 11:55:03 +0900
committernsfisis <nsfisis@gmail.com>2026-05-03 11:55:03 +0900
commitae1aa6540761e54a76b8f7984cf93cd3a0d011d0 (patch)
treef111e1c73977f0bffb6323b03f4210269b43b297 /crates/mozart-sat-resolver/src/pool.rs
parent30ae6c869adc7f3cb87a4d63edd6d0cda89d571d (diff)
downloadphp-mozart-ae1aa6540761e54a76b8f7984cf93cd3a0d011d0.tar.gz
php-mozart-ae1aa6540761e54a76b8f7984cf93cd3a0d011d0.tar.zst
php-mozart-ae1aa6540761e54a76b8f7984cf93cd3a0d011d0.zip
refactor: switch internal maps/sets from HashMap to IndexMap
Adopt indexmap workspace-wide so iteration order is deterministic and follows insertion order. The non-deterministic order of std HashMap otherwise leaks into resolver decisions when multiple valid solutions exist (e.g. cyclic require pairs under prefer-lowest), making behavior flaky and divergent from Composer's PHP-array semantics. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Diffstat (limited to 'crates/mozart-sat-resolver/src/pool.rs')
-rw-r--r--crates/mozart-sat-resolver/src/pool.rs10
1 files changed, 5 insertions, 5 deletions
diff --git a/crates/mozart-sat-resolver/src/pool.rs b/crates/mozart-sat-resolver/src/pool.rs
index 0312c24..9268675 100644
--- a/crates/mozart-sat-resolver/src/pool.rs
+++ b/crates/mozart-sat-resolver/src/pool.rs
@@ -1,5 +1,5 @@
+use indexmap::IndexMap;
use mozart_semver::VersionConstraint;
-use std::collections::HashMap;
use std::fmt;
/// Unique identifier for a package in the pool. 1-based.
@@ -122,9 +122,9 @@ pub struct Pool {
/// All packages, indexed by (id - 1).
packages: Vec<PoolPackage>,
/// Index: package name → list of package IDs providing that name.
- package_by_name: HashMap<String, Vec<PackageId>>,
+ package_by_name: IndexMap<String, Vec<PackageId>>,
/// Cache for what_provides results.
- provider_cache: HashMap<(String, String), Vec<PackageId>>,
+ provider_cache: IndexMap<(String, String), Vec<PackageId>>,
/// Packages that are fixed/locked but unacceptable (e.g. failed stability).
unacceptable_fixed_packages: Vec<PackageId>,
}
@@ -133,7 +133,7 @@ impl Pool {
/// Create a new pool from a list of package inputs.
pub fn new(inputs: Vec<PoolPackageInput>, unacceptable_fixed_ids: Vec<PackageId>) -> Self {
let mut packages: Vec<PoolPackage> = Vec::with_capacity(inputs.len());
- let mut package_by_name: HashMap<String, Vec<PackageId>> = HashMap::new();
+ let mut package_by_name: IndexMap<String, Vec<PackageId>> = IndexMap::new();
// Collect alias links (alias_idx, target_name, target_normalized) for
// a second pass once every input has a stable ID.
let mut pending_aliases: Vec<(usize, String, String)> = Vec::new();
@@ -189,7 +189,7 @@ impl Pool {
Pool {
packages,
package_by_name,
- provider_cache: HashMap::new(),
+ provider_cache: IndexMap::new(),
unacceptable_fixed_packages: unacceptable_fixed_ids,
}
}