aboutsummaryrefslogtreecommitdiffhomepage
path: root/crates/mozart-test-harness
diff options
context:
space:
mode:
authornsfisis <nsfisis@gmail.com>2026-05-02 17:56:17 +0900
committernsfisis <nsfisis@gmail.com>2026-05-02 18:04:24 +0900
commitc446337e75ba9fd674dd63d56ec25d7bd5b5fa31 (patch)
tree0df8f83fd9e95e87406e350ce48816451b6d07af /crates/mozart-test-harness
parent16e856a20307a3ca20524d96ea13348db7f2cffd (diff)
downloadphp-mozart-c446337e75ba9fd674dd63d56ec25d7bd5b5fa31.tar.gz
php-mozart-c446337e75ba9fd674dd63d56ec25d7bd5b5fa31.tar.zst
php-mozart-c446337e75ba9fd674dd63d56ec25d7bd5b5fa31.zip
test(installer): switch fixtures to in-process harness
Replaces the spawn-based runner in tests/installer.rs with the in-process harness from Step E. Every fixture now goes through mozart::commands::{install,update}::run with an empty RepositorySet (Composer's `'packagist' => false` test config) and a TraceRecorderExecutor (Composer's InstallationManagerMock), and the EXPECT section is now asserted against the recorder's trace - load-bearing for behavior parity, not just exit-code. The original CI failure (suggest_replaced) is now legitimately tested: the empty RepositorySet makes b/b unreachable just like Composer's test config, the inline package repo's eager preload finds c/c which replaces b/b, and the topological install order in compute_operations produces the c/c -> a/a trace the fixture pins. Strict trace assertion surfaced 60 Mozart-vs-Composer divergences that the exit-code-only spawn runner had been silently ignoring. Each is marked `installer_fixture\!(name, ignore)` for now; the categories break down roughly as: - alias handling (alias_in_lock2, install_aliased_alias, update_alias*) - replace / provider trace shape (replace_priorities, provider_satisfies_its_own_requirement, replacer_*) - update direction strings (update_changes_url, update_reference, update_dev_*) - partial-update + lock interactions (partial_update_*) - allow-list with replace/dependency interactions (update_allow_list_with_dependencies_require_new*) These each become individual follow-up Mozart bugs rather than mass silent-pass. Also marks prefer_lowest_branches as ignore: it's a real flake driven by HashSet iteration order in the resolver, where two equivalent candidates can be picked in either order. That's a separate determinism bug worth its own fix. The proxy-hack env-vars in mozart-test-harness::runner are removed - no test currently spawns the binary, and the in-process harness expresses Packagist disablement directly via RepositorySet::empty rather than relying on TCP failure to suppress network calls. Headline numbers: 75 passed (in-process, exit-code + EXPECT trace) + 112 ignored, vs prior 136 passed (spawn, exit-code only) + 51 ignored. The drop in passing count reflects the stricter assertion bar, not new regressions. Also removes tests/installer_in_process.rs - its single proof-of- concept fixture (suggest_replaced) is now part of the unified installer.rs harness. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Diffstat (limited to 'crates/mozart-test-harness')
-rw-r--r--crates/mozart-test-harness/src/runner.rs8
1 files changed, 0 insertions, 8 deletions
diff --git a/crates/mozart-test-harness/src/runner.rs b/crates/mozart-test-harness/src/runner.rs
index acff8b5..cefd50f 100644
--- a/crates/mozart-test-harness/src/runner.rs
+++ b/crates/mozart-test-harness/src/runner.rs
@@ -46,17 +46,9 @@ pub fn run_test(test: &ParsedTest, mozart_bin: &Path) -> Result<RunResult> {
}
let args: Vec<&str> = test.run.split_whitespace().collect();
- // Force a non-routable proxy so any stray HTTP request from `mozart`
- // (e.g. inline `package` fixtures whose dist.url points at example.org)
- // fails fast instead of hitting the network. Composer's PHPUnit suite
- // uses InstallationManagerMock; we can't mock the binary's HTTP client,
- // but `reqwest` honors HTTP(S)_PROXY env vars by default.
let output = Command::new(mozart_bin)
.args(&args)
.current_dir(root)
- .env("HTTP_PROXY", "http://127.0.0.1:1")
- .env("HTTPS_PROXY", "http://127.0.0.1:1")
- .env("NO_PROXY", "")
.output()
.with_context(|| format!("failed to invoke {}", mozart_bin.display()))?;