diff options
| author | nsfisis <nsfisis@gmail.com> | 2026-05-03 11:55:03 +0900 |
|---|---|---|
| committer | nsfisis <nsfisis@gmail.com> | 2026-05-03 11:55:03 +0900 |
| commit | ae1aa6540761e54a76b8f7984cf93cd3a0d011d0 (patch) | |
| tree | f111e1c73977f0bffb6323b03f4210269b43b297 /crates/mozart-vcs/src/driver/git.rs | |
| parent | 30ae6c869adc7f3cb87a4d63edd6d0cda89d571d (diff) | |
| download | php-mozart-ae1aa6540761e54a76b8f7984cf93cd3a0d011d0.tar.gz php-mozart-ae1aa6540761e54a76b8f7984cf93cd3a0d011d0.tar.zst php-mozart-ae1aa6540761e54a76b8f7984cf93cd3a0d011d0.zip | |
refactor: switch internal maps/sets from HashMap to IndexMap
Adopt indexmap workspace-wide so iteration order is deterministic and
follows insertion order. The non-deterministic order of std HashMap
otherwise leaks into resolver decisions when multiple valid solutions
exist (e.g. cyclic require pairs under prefer-lowest), making behavior
flaky and divergent from Composer's PHP-array semantics.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Diffstat (limited to 'crates/mozart-vcs/src/driver/git.rs')
| -rw-r--r-- | crates/mozart-vcs/src/driver/git.rs | 9 |
1 files changed, 5 insertions, 4 deletions
diff --git a/crates/mozart-vcs/src/driver/git.rs b/crates/mozart-vcs/src/driver/git.rs index cc9a210..43f4ecb 100644 --- a/crates/mozart-vcs/src/driver/git.rs +++ b/crates/mozart-vcs/src/driver/git.rs @@ -1,4 +1,5 @@ -use std::collections::{BTreeMap, HashMap}; +use indexmap::IndexMap; +use std::collections::BTreeMap; use std::path::{Path, PathBuf}; use anyhow::Result; @@ -17,7 +18,7 @@ pub struct GitDriver { root_identifier: Option<String>, tags: Option<BTreeMap<String, String>>, branches: Option<BTreeMap<String, String>>, - info_cache: HashMap<String, Option<serde_json::Value>>, + info_cache: IndexMap<String, Option<serde_json::Value>>, git_util: GitUtil, is_local: bool, } @@ -37,7 +38,7 @@ impl GitDriver { root_identifier: None, tags: None, branches: None, - info_cache: HashMap::new(), + info_cache: IndexMap::new(), git_util, is_local, } @@ -85,7 +86,7 @@ impl GitDriver { fn parse_tags(output: &str) -> BTreeMap<String, String> { let mut tags = BTreeMap::new(); // First pass: collect dereferenced tags (^{}) - let mut dereferenced = HashMap::new(); + let mut dereferenced = IndexMap::new(); for line in output.lines() { let line = line.trim(); if line.is_empty() { |