aboutsummaryrefslogtreecommitdiffhomepage
path: root/crates/mozart/src/commands/dependency.rs
diff options
context:
space:
mode:
authornsfisis <nsfisis@gmail.com>2026-05-03 11:55:03 +0900
committernsfisis <nsfisis@gmail.com>2026-05-03 11:55:03 +0900
commitae1aa6540761e54a76b8f7984cf93cd3a0d011d0 (patch)
treef111e1c73977f0bffb6323b03f4210269b43b297 /crates/mozart/src/commands/dependency.rs
parent30ae6c869adc7f3cb87a4d63edd6d0cda89d571d (diff)
downloadphp-mozart-ae1aa6540761e54a76b8f7984cf93cd3a0d011d0.tar.gz
php-mozart-ae1aa6540761e54a76b8f7984cf93cd3a0d011d0.tar.zst
php-mozart-ae1aa6540761e54a76b8f7984cf93cd3a0d011d0.zip
refactor: switch internal maps/sets from HashMap to IndexMap
Adopt indexmap workspace-wide so iteration order is deterministic and follows insertion order. The non-deterministic order of std HashMap otherwise leaks into resolver decisions when multiple valid solutions exist (e.g. cyclic require pairs under prefer-lowest), making behavior flaky and divergent from Composer's PHP-array semantics. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Diffstat (limited to 'crates/mozart/src/commands/dependency.rs')
-rw-r--r--crates/mozart/src/commands/dependency.rs13
1 files changed, 7 insertions, 6 deletions
diff --git a/crates/mozart/src/commands/dependency.rs b/crates/mozart/src/commands/dependency.rs
index 6dcaec8..d044432 100644
--- a/crates/mozart/src/commands/dependency.rs
+++ b/crates/mozart/src/commands/dependency.rs
@@ -4,7 +4,8 @@
//! `prohibits` (aka `why-not`) answers: "Which packages prevent version X of package Y from being
//! installed?"
-use std::collections::{BTreeMap, HashSet};
+use indexmap::IndexSet;
+use std::collections::BTreeMap;
use std::path::Path;
use anyhow::Result;
@@ -233,7 +234,7 @@ fn get_dependents_forward(
needles: &[String],
recursive: bool,
) -> Result<Vec<DependencyResult>> {
- let needle_set: HashSet<String> = needles.iter().map(|n| n.to_lowercase()).collect();
+ let needle_set: IndexSet<String> = needles.iter().map(|n| n.to_lowercase()).collect();
// Build name→PackageInfo lookup
let pkg_map: BTreeMap<String, &PackageInfo> = packages
@@ -243,7 +244,7 @@ fn get_dependents_forward(
if recursive {
// Recursive: BFS from needles upward to root, building a tree
- let mut visited: HashSet<String> = HashSet::new();
+ let mut visited: IndexSet<String> = IndexSet::new();
let mut results: Vec<DependencyResult> = Vec::new();
for needle in needles {
@@ -318,8 +319,8 @@ fn recurse_dependents(
packages: &[PackageInfo],
needle: &str,
pkg_map: &BTreeMap<String, &PackageInfo>,
- visited: &mut HashSet<String>,
- _original_needles: &HashSet<String>,
+ visited: &mut IndexSet<String>,
+ _original_needles: &IndexSet<String>,
) -> Vec<DependencyResult> {
let _ = pkg_map; // kept for potential future use
let direct = collect_direct_requires(packages, needle);
@@ -545,7 +546,7 @@ pub fn print_table(results: &[DependencyResult], console: &mozart_core::console:
.max()
.unwrap_or(0);
- let mut seen: HashSet<String> = HashSet::new();
+ let mut seen: IndexSet<String> = IndexSet::new();
for r in results {
let key = format!(
"{}|{}|{}|{}",