aboutsummaryrefslogtreecommitdiffhomepage
path: root/crates/mozart
diff options
context:
space:
mode:
authornsfisis <nsfisis@gmail.com>2026-05-03 12:32:10 +0900
committernsfisis <nsfisis@gmail.com>2026-05-03 12:32:10 +0900
commit2af684c6397001944c9d9aac20ca59677d6a9650 (patch)
tree054f40875ca547223c36f19e876269baadb1bf6f /crates/mozart
parentab2772b8c85139df7d5e625ac5262d385e5ab4c0 (diff)
downloadphp-mozart-2af684c6397001944c9d9aac20ca59677d6a9650.tar.gz
php-mozart-2af684c6397001944c9d9aac20ca59677d6a9650.tar.zst
php-mozart-2af684c6397001944c9d9aac20ca59677d6a9650.zip
fix(install): emit MarkAliasUninstalled and fix dev-branch upgrade direction
Two pieces of Composer's update-trace machinery were missing: 1. VersionParser::isUpgrade in Composer\Package\Version (which overrides the upstream Semver one) substitutes dev-master / dev-trunk / dev-default with the 9999999-dev default-branch alias, then returns true whenever either side starts with `dev-`. Mozart's is_upgrade compared via the generic version order, so dev-master → dev-foo came out as Downgrading. Port the override. 2. Transaction::calculateOperations seeds removeAliasMap from the currently-installed AliasPackages and emits MarkAliasUninstalled for every entry not covered by the new lock. Mozart never emitted those, so updating away from a branch-aliased package produced no trace line for the alias retirement. Walk installed.json's `extra.branch-alias` map, compare against the new lock's aliases[] block, and emit a MarkAliasUninstalled PackageOperation (a new variant on the executor surface — no filesystem effects, only the trace recorder cares). Unblocks update_alias, update_alias_lock2, and update_no_dev_still_resolves_dev installer fixtures. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Diffstat (limited to 'crates/mozart')
-rw-r--r--crates/mozart/src/commands/install.rs82
-rw-r--r--crates/mozart/tests/installer.rs6
2 files changed, 84 insertions, 4 deletions
diff --git a/crates/mozart/src/commands/install.rs b/crates/mozart/src/commands/install.rs
index 7aac3af..c7caff4 100644
--- a/crates/mozart/src/commands/install.rs
+++ b/crates/mozart/src/commands/install.rs
@@ -5,7 +5,8 @@ use mozart_core::console_format;
use mozart_registry::installed;
use mozart_registry::installer_executor::{
ExecuteContext, FilesystemExecutor, InstallerExecutor, PackageOperation,
- format_full_pretty_version, format_update_pretty_versions,
+ format_full_pretty_version, format_full_pretty_version_for_installed,
+ format_full_pretty_with_pretty_for_installed, format_update_pretty_versions,
};
use mozart_registry::lockfile;
use std::collections::BTreeMap;
@@ -329,6 +330,64 @@ fn topological_sort<'a>(
ordered
}
+/// Pre-rendered MarkAliasUninstalled operation. Composer derives the alias
+/// from the installed package's `extra.branch-alias` map and the comparison
+/// runs against the new lock's `aliases[]` block; we precompute the trace
+/// strings here so the executor call site can stay simple.
+struct StaleInstalledAlias {
+ name: String,
+ alias_full: String,
+ target_full: String,
+}
+
+/// Walk every `installed.json` entry, expand its `extra.branch-alias` map
+/// into `(target_branch_pretty → alias_pretty)` pairs, and emit a
+/// [`StaleInstalledAlias`] for each pair whose alias version doesn't appear
+/// in the new lock's `aliases[]` block under the same package. Mirrors
+/// Composer's `Transaction::calculateOperations`, which seeds `removeAliasMap`
+/// from the present alias packages and trims it as the result is walked —
+/// whatever's left becomes a `MarkAliasUninstalledOperation`.
+fn collect_stale_installed_aliases(
+ installed: &installed::InstalledPackages,
+ lock_aliases: &[lockfile::LockAlias],
+) -> Vec<StaleInstalledAlias> {
+ let mut stale = Vec::new();
+ for entry in &installed.packages {
+ let Some(branch_alias) = entry
+ .extra_fields
+ .get("extra")
+ .and_then(|e| e.get("branch-alias"))
+ .and_then(|b| b.as_object())
+ else {
+ continue;
+ };
+ for (target_branch, alias_value) in branch_alias {
+ // The map key is the branch name (e.g. `dev-master`); only the
+ // alias for the *currently installed* version applies.
+ if entry.version != *target_branch {
+ continue;
+ }
+ let Some(alias_pretty) = alias_value.as_str() else {
+ continue;
+ };
+ // Already covered by the new lock under the same package +
+ // alias version → not stale.
+ let still_present = lock_aliases
+ .iter()
+ .any(|a| a.package.eq_ignore_ascii_case(&entry.name) && a.alias == alias_pretty);
+ if still_present {
+ continue;
+ }
+ stale.push(StaleInstalledAlias {
+ name: entry.name.clone(),
+ alias_full: format_full_pretty_with_pretty_for_installed(alias_pretty, entry),
+ target_full: format_full_pretty_version_for_installed(entry),
+ });
+ }
+ }
+ stale
+}
+
/// Compare an installed-package entry's source/dist references with a
/// locked package's. Mirrors the reference-equality leg of Composer's
/// `Transaction::calculateOperations` update-detection: a same-version
@@ -670,6 +729,27 @@ pub async fn install_from_lock(
executor.uninstall_package(name, from_version, &exec_ctx)?;
}
+ // Mirror Composer's `Transaction::moveUninstallsToFront` +
+ // `MarkAliasUninstalledOperation` emission: any alias declared on a
+ // currently-installed package (via `extra.branch-alias`) that is no
+ // longer present in the new lock's `aliases[]` block needs a trace
+ // line so consumers see the alias was retired alongside its target.
+ // Detection runs before installs/updates since Composer hoists alias
+ // uninstalls to the front of the operations list.
+ let stale_aliases = collect_stale_installed_aliases(&installed, &lock.aliases);
+ for stale in &stale_aliases {
+ executor
+ .install_package(
+ PackageOperation::MarkAliasUninstalled {
+ name: &stale.name,
+ alias_full: &stale.alias_full,
+ target_full: &stale.target_full,
+ },
+ &exec_ctx,
+ )
+ .await?;
+ }
+
if !removals.is_empty() {
executor.cleanup_after_uninstalls(&exec_ctx)?;
}
diff --git a/crates/mozart/tests/installer.rs b/crates/mozart/tests/installer.rs
index 07e69d2..0cf7e84 100644
--- a/crates/mozart/tests/installer.rs
+++ b/crates/mozart/tests/installer.rs
@@ -366,9 +366,9 @@ installer_fixture!(
update_abandoned_package_required_but_blocked_via_audit_config,
ignore
);
-installer_fixture!(update_alias, ignore);
+installer_fixture!(update_alias);
installer_fixture!(update_alias_lock, ignore);
-installer_fixture!(update_alias_lock2, ignore);
+installer_fixture!(update_alias_lock2);
installer_fixture!(update_all);
installer_fixture!(update_all_dry_run);
installer_fixture!(update_allow_list);
@@ -408,7 +408,7 @@ installer_fixture!(update_installed_reference);
installer_fixture!(update_installed_reference_dry_run);
installer_fixture!(update_mirrors_changes_url, ignore);
installer_fixture!(update_mirrors_fails_with_new_req, ignore);
-installer_fixture!(update_no_dev_still_resolves_dev, ignore);
+installer_fixture!(update_no_dev_still_resolves_dev);
installer_fixture!(update_no_install);
installer_fixture!(update_package_present_in_lock_but_not_at_all_in_remote);
installer_fixture!(update_package_present_in_lock_but_not_in_remote);