1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
|
use crate::composer::Composer;
use clap::Args;
use indexmap::IndexMap;
use mozart_core::composer::LocalRepository;
use mozart_core::console::IoInterface;
use mozart_core::package::PackageInterface as _;
use mozart_core::{console_writeln, console_writeln_error};
use std::collections::BTreeMap;
use std::path::Path;
/// Exit code for stale lock file (matches Composer's BumpCommand::ERROR_LOCK_OUTDATED).
const ERROR_LOCK_OUTDATED: i32 = 2;
#[derive(Args)]
pub struct BumpArgs {
/// Package(s) to bump
pub packages: Vec<String>,
/// Only bump packages in require-dev
#[arg(short = 'D', long)]
pub dev_only: bool,
/// Only bump packages in require
#[arg(short = 'R', long)]
pub no_dev_only: bool,
/// Only output what would be changed, do not modify files
#[arg(long)]
pub dry_run: bool,
}
pub async fn execute(
args: &BumpArgs,
cli: &super::Cli,
io: std::sync::Arc<std::sync::Mutex<Box<dyn IoInterface>>>,
) -> anyhow::Result<()> {
let working_dir = cli.working_dir()?;
let composer = Composer::require(io.clone(), &working_dir)?;
let exit = do_bump(
io,
&composer,
args.dev_only,
args.no_dev_only,
args.dry_run,
&args.packages,
"--dev-only",
)
.await?;
if exit != 0 {
return Err(mozart_core::exit_code::bail_silent(exit));
}
Ok(())
}
/// Mirrors `Composer\Command\BumpCommand::doBump`. Returns the exit code
/// (0 / `ERROR_GENERIC` / `ERROR_LOCK_OUTDATED`).
///
/// `dev_only_flag_hint` is the option name shown in the `Alternatively you can use {hint}`
/// warning when the package has no `type` set. `bump` itself passes `--dev-only`;
/// `update --bump` will pass its own combined option name once that command is ported.
pub async fn do_bump(
io: std::sync::Arc<std::sync::Mutex<Box<dyn IoInterface>>>,
composer: &Composer,
dev_only: bool,
no_dev_only: bool,
dry_run: bool,
packages_filter: &[String],
dev_only_flag_hint: &str,
) -> anyhow::Result<i32> {
let composer_json_path = composer.project_dir().join("composer.json");
if !is_readable(&composer_json_path) {
console_writeln_error!(
io,
"<error>{} is not readable.</error>",
composer_json_path.display(),
);
return Ok(mozart_core::exit_code::GENERAL_ERROR);
}
let contents = match std::fs::read_to_string(&composer_json_path) {
Ok(c) => c,
Err(_) => {
console_writeln_error!(
io,
"<error>{} is not readable.</error>",
composer_json_path.display(),
);
return Ok(mozart_core::exit_code::GENERAL_ERROR);
}
};
if !is_writable(&composer_json_path) {
console_writeln_error!(
io,
"<error>{} is not writable.</error>",
composer_json_path.display(),
);
return Ok(mozart_core::exit_code::GENERAL_ERROR);
}
// Mirrors Composer's `$hasLockfileDisabled = !$config->has('lock') || $config->get('lock')`.
// The PHP variable is named "hasLockfileDisabled" but its value is *true* when the
// lock is enabled (default) — i.e. the name is upstream-confusing. Mozart's
// `Config::lock` is a `bool` (defaults to `true`), so the equivalent is just the field.
let lock_enabled = composer.config().lock;
let lock_path = composer.locker().lock_file_path();
let locked_versions: IndexMap<String, (String, Option<String>)> = if !lock_enabled {
// Composer always reaches for the locker here, even though `lock` is disabled.
// Mirror that: if a lockfile exists on disk we use it; otherwise we fall back
// to an empty map (`getLockedRepository` would throw in PHP — Mozart degrades
// gracefully because `bump` has nothing to bump in that case anyway).
if composer.locker().is_locked() {
let lock = mozart_core::repository::lockfile::LockFile::read_from_file(lock_path)?;
build_locked_versions_from_lock(&lock)
} else {
IndexMap::new()
}
} else if composer.locker().is_locked() {
let lock = mozart_core::repository::lockfile::LockFile::read_from_file(lock_path)?;
if !lock.is_fresh(&contents) {
console_writeln_error!(
io,
"<error>The lock file is not up to date with the latest changes in composer.json. Run the appropriate `update` to fix that before you use the `bump` command.</error>",
);
return Ok(ERROR_LOCK_OUTDATED);
}
build_locked_versions_from_lock(&lock)
} else {
build_locked_versions_from_local(composer.repository_manager().local_repository())
};
let package_type = composer.package().package_type();
if package_type != "project" && !dev_only {
console_writeln_error!(
io,
"<warning>Warning: Bumping dependency constraints is not recommended for libraries as it will narrow down your dependencies and may cause problems for your users.</warning>",
);
if package_type == "library" {
console_writeln_error!(
io,
"<warning>If your package is not a library, you can explicitly specify the \"type\" by using \"composer config type project\".</warning>",
);
console_writeln_error!(
io,
"<warning>Alternatively you can use {dev_only_flag_hint} to only bump dependencies within \"require-dev\".</warning>",
);
}
}
let mut tasks = Vec::new();
if !dev_only {
tasks.push(("require", composer.package().requires()));
}
if !no_dev_only {
tasks.push(("require-dev", composer.package().dev_requires()));
}
let stripped_filter: Option<Vec<String>> = if packages_filter.is_empty() {
None
} else {
let mut filtered: Vec<String> = packages_filter
.iter()
.map(|p| strip_inline_constraint(p).to_lowercase())
.collect();
filtered.sort();
filtered.dedup();
Some(filtered)
};
let mut updates: BTreeMap<&'static str, BTreeMap<String, String>> = BTreeMap::new();
for (key, reqs) in &tasks {
for (pkg_name, link) in reqs.iter() {
let constraint = &link.constraint;
if mozart_core::platform::is_platform_package(pkg_name) {
continue;
}
if let Some(ref filter) = stripped_filter
&& !filter
.iter()
.any(|pat| mozart_core::matches_wildcard(pkg_name, pat))
{
continue;
}
let Some((pretty_version, version_normalized)) =
locked_versions.get(&pkg_name.to_lowercase())
else {
continue;
};
let Some(new_constraint) = mozart_core::version_bumper::bump_requirement(
constraint,
pretty_version,
version_normalized.as_deref(),
) else {
continue;
};
if &new_constraint == constraint {
continue;
}
updates
.entry(*key)
.or_default()
.insert(pkg_name.clone(), new_constraint);
}
}
if !dry_run && !update_file_cleanly(&composer_json_path, &updates)? {
let mut composer_definition: mozart_core::package::RawPackageData =
serde_json::from_str(&std::fs::read_to_string(&composer_json_path)?)?;
for (key, packages) in &updates {
for (package, version) in packages {
match *key {
"require" => {
composer_definition
.require
.insert(package.clone(), version.clone());
}
"require-dev" => {
composer_definition
.require_dev
.insert(package.clone(), version.clone());
}
_ => unreachable!(),
}
}
}
mozart_core::package::write_to_file(&composer_definition, &composer_json_path)?;
}
let change_count: usize = updates.values().map(|m| m.len()).sum();
if change_count > 0 {
if dry_run {
console_writeln!(
io,
"<info>{} would be updated with:</info>",
composer_json_path.display(),
);
for (require_type, packages) in &updates {
for (package, version) in packages {
console_writeln!(io, "<info> - {require_type}.{package}: {version}</info>");
}
}
} else {
console_writeln!(
io,
"<info>{} has been updated ({change_count} changes).</info>",
composer_json_path.display(),
);
}
} else {
console_writeln!(
io,
"<info>No requirements to update in {}.</info>",
composer_json_path.display(),
);
}
if !dry_run && composer.locker().is_locked() && composer.config().lock && change_count > 0 {
update_lock_hash(lock_path, &composer_json_path)?;
}
if dry_run && change_count > 0 {
return Ok(mozart_core::exit_code::GENERAL_ERROR);
}
Ok(0)
}
/// Mirrors `BumpCommand::updateFileCleanly`. Returns `Ok(true)` on a clean,
/// formatting-preserving write; `Ok(false)` when the caller must fall back
/// to a full structured rewrite of `composer.json`.
///
/// Mozart does not yet have a `JsonManipulator` port, so this always returns
/// `Ok(false)` and the caller falls back. See `docs/known-incompatibilities.md`.
fn update_file_cleanly(
_path: &Path,
_updates: &BTreeMap<&'static str, BTreeMap<String, String>>,
) -> anyhow::Result<bool> {
Ok(false)
}
/// Recompute the lock file's `content-hash` to match `composer_json_path`.
/// Mirrors `Locker::updateHash`, which `BumpCommand::doBump` calls after a
/// successful in-place edit so the lockfile stays "fresh" for the next install.
fn update_lock_hash(lock_path: &Path, composer_json_path: &Path) -> anyhow::Result<()> {
let new_composer_json_content = std::fs::read_to_string(composer_json_path)?;
let new_hash = mozart_core::repository::lockfile::LockFile::compute_content_hash(
&new_composer_json_content,
)?;
let mut lock = mozart_core::repository::lockfile::LockFile::read_from_file(lock_path)?;
lock.content_hash = new_hash;
lock.write_to_file(lock_path)?;
Ok(())
}
fn is_readable(path: &Path) -> bool {
std::fs::File::open(path).is_ok()
}
fn is_writable(path: &Path) -> bool {
match std::fs::metadata(path) {
Ok(m) => !m.permissions().readonly(),
Err(_) => false,
}
}
/// Build a map of lowercase package names to (pretty_version, version_normalized)
/// from a parsed `composer.lock`.
fn build_locked_versions_from_lock(
lock: &mozart_core::repository::lockfile::LockFile,
) -> IndexMap<String, (String, Option<String>)> {
let mut map: IndexMap<String, (String, Option<String>)> = IndexMap::new();
let all_packages = lock
.packages
.iter()
.chain(lock.packages_dev.as_deref().unwrap_or(&[]));
for pkg in all_packages {
map.insert(
pkg.name.to_lowercase(),
(pkg.version.clone(), pkg.version_normalized.clone()),
);
}
map
}
/// Build a map of lowercase package names to (pretty_version, None) from
/// the local repository (`vendor/composer/installed.json`). Used as the
/// fallback when no `composer.lock` is present, mirroring Composer's
/// `getRepositoryManager()->getLocalRepository()` branch.
fn build_locked_versions_from_local(
repo: &LocalRepository,
) -> IndexMap<String, (String, Option<String>)> {
let mut map: IndexMap<String, (String, Option<String>)> = IndexMap::new();
for pkg in repo.get_canonical_packages() {
map.insert(
pkg.pretty_name().to_lowercase(),
(pkg.pretty_version().to_string(), None),
);
}
map
}
/// Strip an inline constraint suffix from a package filter argument.
///
/// Composer allows arguments like `vendor/pkg:^2.0`, `vendor/pkg=2.0`, or
/// `vendor/pkg ^2.0`. This function strips everything from the first `:`,
/// `=`, or ` ` character onward, returning just the package name portion.
/// Mirrors `Preg::replace('{[:= ].+}', '', $constraint)`.
fn strip_inline_constraint(arg: &str) -> &str {
arg.find([':', '=', ' '])
.map(|pos| &arg[..pos])
.unwrap_or(arg)
}
#[cfg(test)]
mod tests {
use super::*;
use mozart_core::repository::lockfile::{LockFile, LockedPackage};
use tempfile::tempdir;
fn minimal_lock(packages: Vec<LockedPackage>, packages_dev: Vec<LockedPackage>) -> LockFile {
LockFile {
readme: LockFile::default_readme(),
content_hash: "placeholder".to_string(),
packages,
packages_dev: Some(packages_dev),
aliases: vec![],
minimum_stability: "stable".to_string(),
stability_flags: serde_json::json!({}),
prefer_stable: false,
prefer_lowest: false,
platform: serde_json::json!({}),
platform_dev: serde_json::json!({}),
plugin_api_version: Some("2.6.0".to_string()),
}
}
fn make_locked_package(name: &str, version: &str) -> LockedPackage {
LockedPackage {
name: name.to_string(),
version: version.to_string(),
version_normalized: Some(format!("{version}.0")),
source: None,
dist: None,
require: indexmap::IndexMap::new(),
require_dev: indexmap::IndexMap::new(),
conflict: indexmap::IndexMap::new(),
provide: indexmap::IndexMap::new(),
replace: indexmap::IndexMap::new(),
suggest: None,
package_type: None,
autoload: None,
autoload_dev: None,
license: None,
description: None,
homepage: None,
keywords: None,
authors: None,
support: None,
funding: None,
time: None,
extra_fields: indexmap::IndexMap::new(),
}
}
fn write_composer_json(dir: &std::path::Path, content: &str) {
std::fs::write(dir.join("composer.json"), content).unwrap();
}
fn write_lock_with_hash(dir: &std::path::Path, mut lock: LockFile, composer_json: &str) {
let hash = LockFile::compute_content_hash(composer_json).unwrap();
lock.content_hash = hash;
lock.write_to_file(&dir.join("composer.lock")).unwrap();
}
fn make_cli(working_dir: &std::path::Path) -> super::super::Cli {
super::super::Cli {
command: Some(super::super::Commands::Bump(BumpArgs {
packages: vec![],
dev_only: false,
no_dev_only: false,
dry_run: false,
})),
version: false,
verbose: 0,
profile: false,
no_plugins: false,
no_scripts: false,
working_dir: Some(working_dir.to_str().unwrap().to_string()),
no_cache: false,
no_interaction: false,
quiet: false,
ansi: false,
no_ansi: false,
}
}
fn quiet_io() -> std::sync::Arc<std::sync::Mutex<Box<dyn IoInterface>>> {
std::sync::Arc::new(std::sync::Mutex::new(
Box::new(mozart_core::console::Console::new(
0, false, false, false, false,
)) as Box<dyn IoInterface>,
))
}
#[tokio::test]
async fn test_basic_bump_modifies_composer_json() {
let dir = tempdir().unwrap();
let composer_json = r#"{
"name": "test/project",
"type": "project",
"require": {
"psr/log": "^1.0"
}
}"#;
write_composer_json(dir.path(), composer_json);
let lock = minimal_lock(vec![make_locked_package("psr/log", "1.1.4")], vec![]);
write_lock_with_hash(dir.path(), lock, composer_json);
let args = BumpArgs {
packages: vec![],
dev_only: false,
no_dev_only: false,
dry_run: false,
};
let cli = make_cli(dir.path());
execute(&args, &cli, quiet_io()).await.unwrap();
let updated = std::fs::read_to_string(dir.path().join("composer.json")).unwrap();
let parsed: serde_json::Value = serde_json::from_str(&updated).unwrap();
assert_eq!(parsed["require"]["psr/log"], "^1.1.4");
}
#[tokio::test]
async fn test_dry_run_does_not_modify_files() {
let dir = tempdir().unwrap();
let composer_json = r#"{
"name": "test/project",
"type": "project",
"require": {
"psr/log": "^1.0"
}
}"#;
write_composer_json(dir.path(), composer_json);
let lock = minimal_lock(vec![make_locked_package("psr/log", "1.1.4")], vec![]);
write_lock_with_hash(dir.path(), lock, composer_json);
let args = BumpArgs {
packages: vec![],
dev_only: false,
no_dev_only: false,
dry_run: true,
};
let cli = make_cli(dir.path());
let result = execute(&args, &cli, quiet_io()).await;
// dry-run with changes returns exit code 1 (for CI usage)
let err = result.unwrap_err();
let mozart_err = err
.downcast_ref::<mozart_core::exit_code::MozartError>()
.expect("should be MozartError");
assert_eq!(mozart_err.exit_code, mozart_core::exit_code::GENERAL_ERROR);
// composer.json should be unchanged
let content = std::fs::read_to_string(dir.path().join("composer.json")).unwrap();
let parsed: serde_json::Value = serde_json::from_str(&content).unwrap();
assert_eq!(parsed["require"]["psr/log"], "^1.0");
}
#[tokio::test]
async fn test_no_changes_when_already_bumped() {
let dir = tempdir().unwrap();
let composer_json = r#"{
"name": "test/project",
"type": "project",
"require": {
"psr/log": "^1.1.4"
}
}"#;
write_composer_json(dir.path(), composer_json);
let lock = minimal_lock(vec![make_locked_package("psr/log", "1.1.4")], vec![]);
write_lock_with_hash(dir.path(), lock, composer_json);
let args = BumpArgs {
packages: vec![],
dev_only: false,
no_dev_only: false,
dry_run: false,
};
let cli = make_cli(dir.path());
execute(&args, &cli, quiet_io()).await.unwrap();
// No changes should be made
let content = std::fs::read_to_string(dir.path().join("composer.json")).unwrap();
let parsed: serde_json::Value = serde_json::from_str(&content).unwrap();
assert_eq!(parsed["require"]["psr/log"], "^1.1.4");
}
#[tokio::test]
async fn test_dev_only_flag_only_bumps_require_dev() {
let dir = tempdir().unwrap();
let composer_json = r#"{
"name": "test/project",
"type": "project",
"require": {
"psr/log": "^1.0"
},
"require-dev": {
"phpunit/phpunit": "^9.0"
}
}"#;
write_composer_json(dir.path(), composer_json);
let lock = minimal_lock(
vec![make_locked_package("psr/log", "1.1.4")],
vec![make_locked_package("phpunit/phpunit", "9.5.0")],
);
write_lock_with_hash(dir.path(), lock, composer_json);
let args = BumpArgs {
packages: vec![],
dev_only: true,
no_dev_only: false,
dry_run: false,
};
let cli = make_cli(dir.path());
execute(&args, &cli, quiet_io()).await.unwrap();
let content = std::fs::read_to_string(dir.path().join("composer.json")).unwrap();
let parsed: serde_json::Value = serde_json::from_str(&content).unwrap();
// require should NOT be bumped
assert_eq!(parsed["require"]["psr/log"], "^1.0");
// require-dev should be bumped
assert_eq!(parsed["require-dev"]["phpunit/phpunit"], "^9.5");
}
#[tokio::test]
async fn test_no_dev_only_flag_only_bumps_require() {
let dir = tempdir().unwrap();
let composer_json = r#"{
"name": "test/project",
"type": "project",
"require": {
"psr/log": "^1.0"
},
"require-dev": {
"phpunit/phpunit": "^9.0"
}
}"#;
write_composer_json(dir.path(), composer_json);
let lock = minimal_lock(
vec![make_locked_package("psr/log", "1.1.4")],
vec![make_locked_package("phpunit/phpunit", "9.5.0")],
);
write_lock_with_hash(dir.path(), lock, composer_json);
let args = BumpArgs {
packages: vec![],
dev_only: false,
no_dev_only: true,
dry_run: false,
};
let cli = make_cli(dir.path());
execute(&args, &cli, quiet_io()).await.unwrap();
let content = std::fs::read_to_string(dir.path().join("composer.json")).unwrap();
let parsed: serde_json::Value = serde_json::from_str(&content).unwrap();
// require should be bumped
assert_eq!(parsed["require"]["psr/log"], "^1.1.4");
// require-dev should NOT be bumped
assert_eq!(parsed["require-dev"]["phpunit/phpunit"], "^9.0");
}
#[tokio::test]
async fn test_stale_lock_file_produces_exit_code_2() {
let dir = tempdir().unwrap();
let composer_json = r#"{
"name": "test/project",
"require": {
"psr/log": "^1.0"
}
}"#;
write_composer_json(dir.path(), composer_json);
// Write lock with a wrong hash (stale)
let mut lock = minimal_lock(vec![make_locked_package("psr/log", "1.1.4")], vec![]);
lock.content_hash = "wrong_hash_here".to_string();
lock.write_to_file(&dir.path().join("composer.lock"))
.unwrap();
let args = BumpArgs {
packages: vec![],
dev_only: false,
no_dev_only: false,
dry_run: false,
};
let cli = make_cli(dir.path());
let result = execute(&args, &cli, quiet_io()).await;
// stale lock file should return exit code 2 (ERROR_LOCK_OUTDATED)
let err = result.unwrap_err();
let mozart_err = err
.downcast_ref::<mozart_core::exit_code::MozartError>()
.expect("should be MozartError");
assert_eq!(mozart_err.exit_code, ERROR_LOCK_OUTDATED);
}
#[tokio::test]
async fn test_lock_file_hash_updated_after_bump() {
let dir = tempdir().unwrap();
let composer_json = r#"{
"name": "test/project",
"type": "project",
"require": {
"psr/log": "^1.0"
}
}"#;
write_composer_json(dir.path(), composer_json);
let lock = minimal_lock(vec![make_locked_package("psr/log", "1.1.4")], vec![]);
write_lock_with_hash(dir.path(), lock, composer_json);
let args = BumpArgs {
packages: vec![],
dev_only: false,
no_dev_only: false,
dry_run: false,
};
let cli = make_cli(dir.path());
execute(&args, &cli, quiet_io()).await.unwrap();
// The lock file content-hash should now match the updated composer.json
let updated_composer = std::fs::read_to_string(dir.path().join("composer.json")).unwrap();
let updated_lock = LockFile::read_from_file(&dir.path().join("composer.lock")).unwrap();
assert!(
updated_lock.is_fresh(&updated_composer),
"Lock file hash should be updated to match new composer.json"
);
}
#[tokio::test]
async fn test_no_lock_falls_back_to_local_repository() {
let dir = tempdir().unwrap();
let composer_json = r#"{
"name": "test/project",
"type": "project",
"require": {
"psr/log": "^1.0"
}
}"#;
write_composer_json(dir.path(), composer_json);
// No composer.lock — instead populate vendor/composer/installed.json.
let installed_dir = dir.path().join("vendor/composer");
std::fs::create_dir_all(&installed_dir).unwrap();
let installed = serde_json::json!({
"packages": [
{
"name": "psr/log",
"version": "1.1.4",
"version_normalized": "1.1.4.0",
}
],
"dev": false,
});
std::fs::write(
installed_dir.join("installed.json"),
serde_json::to_string_pretty(&installed).unwrap(),
)
.unwrap();
let args = BumpArgs {
packages: vec![],
dev_only: false,
no_dev_only: false,
dry_run: false,
};
let cli = make_cli(dir.path());
execute(&args, &cli, quiet_io()).await.unwrap();
let content = std::fs::read_to_string(dir.path().join("composer.json")).unwrap();
let parsed: serde_json::Value = serde_json::from_str(&content).unwrap();
assert_eq!(parsed["require"]["psr/log"], "^1.1.4");
}
#[test]
fn test_strip_inline_constraint_colon() {
assert_eq!(strip_inline_constraint("vendor/pkg:^2.0"), "vendor/pkg");
}
#[test]
fn test_strip_inline_constraint_equals() {
assert_eq!(strip_inline_constraint("vendor/pkg=2.0.0"), "vendor/pkg");
}
#[test]
fn test_strip_inline_constraint_space() {
assert_eq!(strip_inline_constraint("vendor/pkg ^2.0"), "vendor/pkg");
}
#[test]
fn test_strip_inline_constraint_no_suffix() {
assert_eq!(strip_inline_constraint("vendor/pkg"), "vendor/pkg");
assert_eq!(strip_inline_constraint("psr/log"), "psr/log");
}
#[tokio::test]
async fn test_package_filter_only_bumps_specified_packages() {
let dir = tempdir().unwrap();
let composer_json = r#"{
"name": "test/project",
"type": "project",
"require": {
"psr/log": "^1.0",
"psr/http-message": "^1.0"
}
}"#;
write_composer_json(dir.path(), composer_json);
let lock = minimal_lock(
vec![
make_locked_package("psr/log", "1.1.4"),
make_locked_package("psr/http-message", "1.2.0"),
],
vec![],
);
write_lock_with_hash(dir.path(), lock, composer_json);
let args = BumpArgs {
packages: vec!["psr/log".to_string()],
dev_only: false,
no_dev_only: false,
dry_run: false,
};
let cli = make_cli(dir.path());
execute(&args, &cli, quiet_io()).await.unwrap();
let content = std::fs::read_to_string(dir.path().join("composer.json")).unwrap();
let parsed: serde_json::Value = serde_json::from_str(&content).unwrap();
assert_eq!(parsed["require"]["psr/log"], "^1.1.4");
// psr/http-message should NOT be bumped
assert_eq!(parsed["require"]["psr/http-message"], "^1.0");
}
#[tokio::test]
async fn test_package_filter_glob_wildcard() {
let dir = tempdir().unwrap();
let composer_json = r#"{
"name": "test/project",
"type": "project",
"require": {
"psr/log": "^1.0",
"psr/container": "^1.0",
"monolog/monolog": "^2.0"
}
}"#;
write_composer_json(dir.path(), composer_json);
let lock = minimal_lock(
vec![
make_locked_package("psr/log", "1.1.4"),
make_locked_package("psr/container", "1.1.1"),
make_locked_package("monolog/monolog", "2.9.0"),
],
vec![],
);
write_lock_with_hash(dir.path(), lock, composer_json);
// Filter using a wildcard: only bump psr/* packages
let args = BumpArgs {
packages: vec!["psr/*".to_string()],
dev_only: false,
no_dev_only: false,
dry_run: false,
};
let cli = make_cli(dir.path());
execute(&args, &cli, quiet_io()).await.unwrap();
let content = std::fs::read_to_string(dir.path().join("composer.json")).unwrap();
let parsed: serde_json::Value = serde_json::from_str(&content).unwrap();
// Both psr/* packages should be bumped
assert_eq!(parsed["require"]["psr/log"], "^1.1.4");
assert_eq!(parsed["require"]["psr/container"], "^1.1.1");
// monolog/monolog should NOT be bumped
assert_eq!(parsed["require"]["monolog/monolog"], "^2.0");
}
#[tokio::test]
async fn test_package_filter_with_inline_constraint() {
let dir = tempdir().unwrap();
let composer_json = r#"{
"name": "test/project",
"type": "project",
"require": {
"psr/log": "^1.0",
"monolog/monolog": "^2.0"
}
}"#;
write_composer_json(dir.path(), composer_json);
let lock = minimal_lock(
vec![
make_locked_package("psr/log", "1.1.4"),
make_locked_package("monolog/monolog", "2.9.0"),
],
vec![],
);
write_lock_with_hash(dir.path(), lock, composer_json);
// Specify filter with an inline constraint suffix (Composer-style: "psr/log:^1.0")
let args = BumpArgs {
packages: vec!["psr/log:^1.0".to_string()],
dev_only: false,
no_dev_only: false,
dry_run: false,
};
let cli = make_cli(dir.path());
execute(&args, &cli, quiet_io()).await.unwrap();
let content = std::fs::read_to_string(dir.path().join("composer.json")).unwrap();
let parsed: serde_json::Value = serde_json::from_str(&content).unwrap();
// psr/log should be bumped (constraint suffix stripped from filter arg)
assert_eq!(parsed["require"]["psr/log"], "^1.1.4");
// monolog/monolog should NOT be bumped
assert_eq!(parsed["require"]["monolog/monolog"], "^2.0");
}
}
|