1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
|
use clap::Args;
use mozart_core::console_format;
use std::collections::HashMap;
use std::path::PathBuf;
#[derive(Args)]
pub struct BumpArgs {
/// Package(s) to bump
pub packages: Vec<String>,
/// Only bump packages in require-dev
#[arg(short = 'D', long)]
pub dev_only: bool,
/// Only bump packages in require
#[arg(short = 'R', long)]
pub no_dev_only: bool,
/// Only output what would be changed, do not modify files
#[arg(long)]
pub dry_run: bool,
}
// ─── Main entry point ─────────────────────────────────────────────────────────
pub async fn execute(
args: &BumpArgs,
cli: &super::Cli,
console: &mozart_core::console::Console,
) -> anyhow::Result<()> {
let working_dir = match &cli.working_dir {
Some(dir) => PathBuf::from(dir),
None => std::env::current_dir()?,
};
let composer_json_path = working_dir.join("composer.json");
let lock_path = working_dir.join("composer.lock");
// Ensure composer.json exists
if !composer_json_path.exists() {
anyhow::bail!("No composer.json found in {}", working_dir.display());
}
// Read composer.json content (raw string for hash computation)
let composer_json_content = std::fs::read_to_string(&composer_json_path)?;
// Parse composer.json
let mut root: mozart_core::package::RawPackageData =
serde_json::from_str(&composer_json_content)?;
// Warn if package is not a project (libraries shouldn't bump)
match root.package_type.as_deref() {
Some("project") => {}
Some(pkg_type) => {
console.info(&console_format!("<warning>Warning: Bumping constraints for a non-project package (type=\"{pkg_type}\"). Libraries should not pin their dependencies.</warning>"));
}
None if !args.dev_only => {
console.info(&console_format!("<warning>Warning: Bumping constraints for a non-project package. No type was set so it defaults to \"library\". Libraries should not pin their dependencies. Consider using --dev-only or setting the type to \"project\".</warning>"));
}
None => {}
}
// Check lock file existence
if !lock_path.exists() {
anyhow::bail!("No composer.lock found. Run `mozart install` first.");
}
// Read and parse lock file
let lock = mozart_registry::lockfile::LockFile::read_from_file(&lock_path)?;
// Check lock file freshness
if !lock.is_fresh(&composer_json_content) {
return Err(mozart_core::exit_code::bail(
mozart_core::exit_code::LOCK_FILE_INVALID,
"composer.lock is not up to date with composer.json. \
Run `mozart install` or `mozart update` to refresh it.",
));
}
// Build map: package name (lowercase) → (pretty_version, version_normalized)
let locked_versions = build_locked_versions_map(&lock);
// Determine which sections to process
let bump_require = !args.dev_only;
let bump_require_dev = !args.no_dev_only;
// Package filter (if specified)
let package_filter: Option<Vec<String>> = if args.packages.is_empty() {
None
} else {
Some(args.packages.iter().map(|p| p.to_lowercase()).collect())
};
// Collect changes
let mut require_changes: Vec<(String, String, String)> = Vec::new(); // (name, old, new)
let mut require_dev_changes: Vec<(String, String, String)> = Vec::new();
// Process require
if bump_require {
for (pkg_name, constraint) in &root.require {
if is_platform_package(pkg_name) {
continue;
}
if let Some(ref filter) = package_filter
&& !filter.contains(&pkg_name.to_lowercase())
{
continue;
}
if let Some((pretty_version, version_normalized)) =
locked_versions.get(&pkg_name.to_lowercase())
&& let Some(new_constraint) = mozart_core::version_bumper::bump_requirement(
constraint,
pretty_version,
version_normalized.as_deref(),
)
{
require_changes.push((pkg_name.clone(), constraint.clone(), new_constraint));
}
}
}
// Process require-dev
if bump_require_dev {
for (pkg_name, constraint) in &root.require_dev {
if is_platform_package(pkg_name) {
continue;
}
if let Some(ref filter) = package_filter
&& !filter.contains(&pkg_name.to_lowercase())
{
continue;
}
if let Some((pretty_version, version_normalized)) =
locked_versions.get(&pkg_name.to_lowercase())
&& let Some(new_constraint) = mozart_core::version_bumper::bump_requirement(
constraint,
pretty_version,
version_normalized.as_deref(),
)
{
require_dev_changes.push((pkg_name.clone(), constraint.clone(), new_constraint));
}
}
}
let total_changes = require_changes.len() + require_dev_changes.len();
if total_changes == 0 {
println!(
"{}",
console_format!(
"<info>No requirements to update in {}.</info>",
composer_json_path.display()
)
);
return Ok(());
}
if args.dry_run {
println!(
"{}",
console_format!(
"<info>{} would be updated with:</info>",
composer_json_path.display()
)
);
for (name, _old, new) in &require_changes {
println!(
"{}",
console_format!("<info> - require.{name}: {new}</info>")
);
}
for (name, _old, new) in &require_dev_changes {
println!(
"{}",
console_format!("<info> - require-dev.{name}: {new}</info>")
);
}
// Return exit code 1 when dry-run detects changes (useful for CI to detect un-bumped constraints)
return Err(mozart_core::exit_code::bail_silent(
mozart_core::exit_code::GENERAL_ERROR,
));
}
// Apply changes to root package
for (name, _old, new) in &require_changes {
root.require.insert(name.clone(), new.clone());
}
for (name, _old, new) in &require_dev_changes {
root.require_dev.insert(name.clone(), new.clone());
}
// Write updated composer.json
mozart_core::package::write_to_file(&root, &composer_json_path)?;
// Update the lock file content-hash to match the new composer.json
let new_composer_json_content = std::fs::read_to_string(&composer_json_path)?;
let new_hash =
mozart_registry::lockfile::LockFile::compute_content_hash(&new_composer_json_content)?;
let mut updated_lock = lock;
updated_lock.content_hash = new_hash;
updated_lock.write_to_file(&lock_path)?;
println!(
"{}",
console_format!(
"<info>{} has been updated ({total_changes} changes).</info>",
composer_json_path.display()
)
);
Ok(())
}
// ─── Helpers ──────────────────────────────────────────────────────────────────
/// Build a map of lowercase package names to (pretty_version, version_normalized) from composer.lock.
fn build_locked_versions_map(
lock: &mozart_registry::lockfile::LockFile,
) -> HashMap<String, (String, Option<String>)> {
let mut map: HashMap<String, (String, Option<String>)> = HashMap::new();
let all_packages = lock
.packages
.iter()
.chain(lock.packages_dev.as_deref().unwrap_or(&[]));
for pkg in all_packages {
map.insert(
pkg.name.to_lowercase(),
(pkg.version.clone(), pkg.version_normalized.clone()),
);
}
map
}
/// Returns true if the package name is a platform requirement (php, ext-*, lib-*, etc.).
fn is_platform_package(name: &str) -> bool {
let lower = name.to_lowercase();
lower == "php"
|| lower.starts_with("ext-")
|| lower.starts_with("lib-")
|| lower == "php-64bit"
|| lower == "php-ipv6"
|| lower == "php-zts"
|| lower == "php-debug"
}
// ─── Tests ───────────────────────────────────────────────────────────────────
#[cfg(test)]
mod tests {
use super::*;
use mozart_registry::lockfile::{LockFile, LockedPackage};
use std::collections::BTreeMap;
use tempfile::tempdir;
fn minimal_lock(packages: Vec<LockedPackage>, packages_dev: Vec<LockedPackage>) -> LockFile {
LockFile {
readme: LockFile::default_readme(),
content_hash: "placeholder".to_string(),
packages,
packages_dev: Some(packages_dev),
aliases: vec![],
minimum_stability: "stable".to_string(),
stability_flags: serde_json::json!({}),
prefer_stable: false,
prefer_lowest: false,
platform: serde_json::json!({}),
platform_dev: serde_json::json!({}),
plugin_api_version: Some("2.6.0".to_string()),
}
}
fn make_locked_package(name: &str, version: &str) -> LockedPackage {
LockedPackage {
name: name.to_string(),
version: version.to_string(),
version_normalized: Some(format!("{version}.0")),
source: None,
dist: None,
require: BTreeMap::new(),
require_dev: BTreeMap::new(),
conflict: BTreeMap::new(),
suggest: None,
package_type: None,
autoload: None,
autoload_dev: None,
license: None,
description: None,
homepage: None,
keywords: None,
authors: None,
support: None,
funding: None,
time: None,
extra_fields: BTreeMap::new(),
}
}
fn write_composer_json(dir: &std::path::Path, content: &str) {
std::fs::write(dir.join("composer.json"), content).unwrap();
}
fn write_lock_with_hash(dir: &std::path::Path, mut lock: LockFile, composer_json: &str) {
let hash = LockFile::compute_content_hash(composer_json).unwrap();
lock.content_hash = hash;
lock.write_to_file(&dir.join("composer.lock")).unwrap();
}
fn make_cli(working_dir: &std::path::Path) -> super::super::Cli {
super::super::Cli {
command: super::super::Commands::Bump(BumpArgs {
packages: vec![],
dev_only: false,
no_dev_only: false,
dry_run: false,
}),
verbose: 0,
profile: false,
no_plugins: false,
no_scripts: false,
working_dir: Some(working_dir.to_str().unwrap().to_string()),
no_cache: false,
no_interaction: false,
quiet: false,
ansi: false,
no_ansi: false,
}
}
// ── Basic bump ─────────────────────────────────────────────────────────
#[tokio::test]
async fn test_basic_bump_modifies_composer_json() {
let dir = tempdir().unwrap();
let composer_json = r#"{
"name": "test/project",
"type": "project",
"require": {
"psr/log": "^1.0"
}
}"#;
write_composer_json(dir.path(), composer_json);
let lock = minimal_lock(vec![make_locked_package("psr/log", "1.1.4")], vec![]);
write_lock_with_hash(dir.path(), lock, composer_json);
let args = BumpArgs {
packages: vec![],
dev_only: false,
no_dev_only: false,
dry_run: false,
};
let cli = make_cli(dir.path());
let console = mozart_core::console::Console {
interactive: false,
verbosity: mozart_core::console::Verbosity::Normal,
decorated: false,
};
execute(&args, &cli, &console).await.unwrap();
let updated = std::fs::read_to_string(dir.path().join("composer.json")).unwrap();
let parsed: serde_json::Value = serde_json::from_str(&updated).unwrap();
assert_eq!(parsed["require"]["psr/log"], "^1.1.4");
}
// ── Dry run ────────────────────────────────────────────────────────────
#[tokio::test]
async fn test_dry_run_does_not_modify_files() {
let dir = tempdir().unwrap();
let composer_json = r#"{
"name": "test/project",
"type": "project",
"require": {
"psr/log": "^1.0"
}
}"#;
write_composer_json(dir.path(), composer_json);
let lock = minimal_lock(vec![make_locked_package("psr/log", "1.1.4")], vec![]);
write_lock_with_hash(dir.path(), lock, composer_json);
let args = BumpArgs {
packages: vec![],
dev_only: false,
no_dev_only: false,
dry_run: true,
};
let cli = make_cli(dir.path());
let console = mozart_core::console::Console {
interactive: false,
verbosity: mozart_core::console::Verbosity::Normal,
decorated: false,
};
let result = execute(&args, &cli, &console).await;
// dry-run with changes returns exit code 1 (for CI usage)
let err = result.unwrap_err();
let mozart_err = err
.downcast_ref::<mozart_core::exit_code::MozartError>()
.expect("should be MozartError");
assert_eq!(mozart_err.exit_code, mozart_core::exit_code::GENERAL_ERROR);
// composer.json should be unchanged
let content = std::fs::read_to_string(dir.path().join("composer.json")).unwrap();
let parsed: serde_json::Value = serde_json::from_str(&content).unwrap();
assert_eq!(parsed["require"]["psr/log"], "^1.0");
}
// ── No changes ─────────────────────────────────────────────────────────
#[tokio::test]
async fn test_no_changes_when_already_bumped() {
let dir = tempdir().unwrap();
let composer_json = r#"{
"name": "test/project",
"type": "project",
"require": {
"psr/log": "^1.1.4"
}
}"#;
write_composer_json(dir.path(), composer_json);
let lock = minimal_lock(vec![make_locked_package("psr/log", "1.1.4")], vec![]);
write_lock_with_hash(dir.path(), lock, composer_json);
let args = BumpArgs {
packages: vec![],
dev_only: false,
no_dev_only: false,
dry_run: false,
};
let cli = make_cli(dir.path());
let console = mozart_core::console::Console {
interactive: false,
verbosity: mozart_core::console::Verbosity::Normal,
decorated: false,
};
execute(&args, &cli, &console).await.unwrap();
// No changes should be made
let content = std::fs::read_to_string(dir.path().join("composer.json")).unwrap();
let parsed: serde_json::Value = serde_json::from_str(&content).unwrap();
assert_eq!(parsed["require"]["psr/log"], "^1.1.4");
}
// ── Dev-only flag ──────────────────────────────────────────────────────
#[tokio::test]
async fn test_dev_only_flag_only_bumps_require_dev() {
let dir = tempdir().unwrap();
let composer_json = r#"{
"name": "test/project",
"type": "project",
"require": {
"psr/log": "^1.0"
},
"require-dev": {
"phpunit/phpunit": "^9.0"
}
}"#;
write_composer_json(dir.path(), composer_json);
let lock = minimal_lock(
vec![make_locked_package("psr/log", "1.1.4")],
vec![make_locked_package("phpunit/phpunit", "9.5.0")],
);
write_lock_with_hash(dir.path(), lock, composer_json);
let args = BumpArgs {
packages: vec![],
dev_only: true,
no_dev_only: false,
dry_run: false,
};
let cli = make_cli(dir.path());
let console = mozart_core::console::Console {
interactive: false,
verbosity: mozart_core::console::Verbosity::Normal,
decorated: false,
};
execute(&args, &cli, &console).await.unwrap();
let content = std::fs::read_to_string(dir.path().join("composer.json")).unwrap();
let parsed: serde_json::Value = serde_json::from_str(&content).unwrap();
// require should NOT be bumped
assert_eq!(parsed["require"]["psr/log"], "^1.0");
// require-dev should be bumped
assert_eq!(parsed["require-dev"]["phpunit/phpunit"], "^9.5");
}
// ── No-dev-only flag ───────────────────────────────────────────────────
#[tokio::test]
async fn test_no_dev_only_flag_only_bumps_require() {
let dir = tempdir().unwrap();
let composer_json = r#"{
"name": "test/project",
"type": "project",
"require": {
"psr/log": "^1.0"
},
"require-dev": {
"phpunit/phpunit": "^9.0"
}
}"#;
write_composer_json(dir.path(), composer_json);
let lock = minimal_lock(
vec![make_locked_package("psr/log", "1.1.4")],
vec![make_locked_package("phpunit/phpunit", "9.5.0")],
);
write_lock_with_hash(dir.path(), lock, composer_json);
let args = BumpArgs {
packages: vec![],
dev_only: false,
no_dev_only: true,
dry_run: false,
};
let cli = make_cli(dir.path());
let console = mozart_core::console::Console {
interactive: false,
verbosity: mozart_core::console::Verbosity::Normal,
decorated: false,
};
execute(&args, &cli, &console).await.unwrap();
let content = std::fs::read_to_string(dir.path().join("composer.json")).unwrap();
let parsed: serde_json::Value = serde_json::from_str(&content).unwrap();
// require should be bumped
assert_eq!(parsed["require"]["psr/log"], "^1.1.4");
// require-dev should NOT be bumped
assert_eq!(parsed["require-dev"]["phpunit/phpunit"], "^9.0");
}
// ── Stale lock file ────────────────────────────────────────────────────
#[test]
fn test_stale_lock_file_produces_exit_code_2() {
let dir = tempdir().unwrap();
let composer_json = r#"{
"name": "test/project",
"require": {
"psr/log": "^1.0"
}
}"#;
write_composer_json(dir.path(), composer_json);
// Write lock with a wrong hash (stale)
let mut lock = minimal_lock(vec![make_locked_package("psr/log", "1.1.4")], vec![]);
lock.content_hash = "wrong_hash_here".to_string();
lock.write_to_file(&dir.path().join("composer.lock"))
.unwrap();
let _args = BumpArgs {
packages: vec![],
dev_only: false,
no_dev_only: false,
dry_run: false,
};
let _cli = make_cli(dir.path());
// The execute function returns Err(MozartError) with LOCK_FILE_INVALID for stale lock.
// We verify the lock IS stale here as a prerequisite check.
let lock_loaded = LockFile::read_from_file(&dir.path().join("composer.lock")).unwrap();
assert!(!lock_loaded.is_fresh(composer_json));
}
// ── Platform packages skipped ──────────────────────────────────────────
#[test]
fn test_platform_packages_are_skipped() {
assert!(is_platform_package("php"));
assert!(is_platform_package("ext-json"));
assert!(is_platform_package("ext-mbstring"));
assert!(is_platform_package("lib-pcre"));
assert!(!is_platform_package("psr/log"));
assert!(!is_platform_package("monolog/monolog"));
}
// ── Lock file hash updated ─────────────────────────────────────────────
#[tokio::test]
async fn test_lock_file_hash_updated_after_bump() {
let dir = tempdir().unwrap();
let composer_json = r#"{
"name": "test/project",
"type": "project",
"require": {
"psr/log": "^1.0"
}
}"#;
write_composer_json(dir.path(), composer_json);
let lock = minimal_lock(vec![make_locked_package("psr/log", "1.1.4")], vec![]);
write_lock_with_hash(dir.path(), lock, composer_json);
let args = BumpArgs {
packages: vec![],
dev_only: false,
no_dev_only: false,
dry_run: false,
};
let cli = make_cli(dir.path());
let console = mozart_core::console::Console {
interactive: false,
verbosity: mozart_core::console::Verbosity::Normal,
decorated: false,
};
execute(&args, &cli, &console).await.unwrap();
// The lock file content-hash should now match the updated composer.json
let updated_composer = std::fs::read_to_string(dir.path().join("composer.json")).unwrap();
let updated_lock = LockFile::read_from_file(&dir.path().join("composer.lock")).unwrap();
assert!(
updated_lock.is_fresh(&updated_composer),
"Lock file hash should be updated to match new composer.json"
);
}
// ── Package filter ─────────────────────────────────────────────────────
#[tokio::test]
async fn test_package_filter_only_bumps_specified_packages() {
let dir = tempdir().unwrap();
let composer_json = r#"{
"name": "test/project",
"type": "project",
"require": {
"psr/log": "^1.0",
"psr/http-message": "^1.0"
}
}"#;
write_composer_json(dir.path(), composer_json);
let lock = minimal_lock(
vec![
make_locked_package("psr/log", "1.1.4"),
make_locked_package("psr/http-message", "1.2.0"),
],
vec![],
);
write_lock_with_hash(dir.path(), lock, composer_json);
let args = BumpArgs {
packages: vec!["psr/log".to_string()],
dev_only: false,
no_dev_only: false,
dry_run: false,
};
let cli = make_cli(dir.path());
let console = mozart_core::console::Console {
interactive: false,
verbosity: mozart_core::console::Verbosity::Normal,
decorated: false,
};
execute(&args, &cli, &console).await.unwrap();
let content = std::fs::read_to_string(dir.path().join("composer.json")).unwrap();
let parsed: serde_json::Value = serde_json::from_str(&content).unwrap();
assert_eq!(parsed["require"]["psr/log"], "^1.1.4");
// psr/http-message should NOT be bumped
assert_eq!(parsed["require"]["psr/http-message"], "^1.0");
}
}
|