diff options
| author | nsfisis <nsfisis@gmail.com> | 2026-07-19 14:18:07 +0900 |
|---|---|---|
| committer | nsfisis <nsfisis@gmail.com> | 2026-07-19 14:19:14 +0900 |
| commit | 15c54ec439d0e718ae4aa81cc96c66b69ddfa4d1 (patch) | |
| tree | 08f1e3e6d038e2d215d6b6cf03fb9cb6b3f86c55 | |
| parent | 134acc52c0f339dd8bf96d4ffc508cdebe66b7d2 (diff) | |
| download | php-shirabe-15c54ec439d0e718ae4aa81cc96c66b69ddfa4d1.tar.gz php-shirabe-15c54ec439d0e718ae4aa81cc96c66b69ddfa4d1.tar.zst php-shirabe-15c54ec439d0e718ae4aa81cc96c66b69ddfa4d1.zip | |
fix(check-platform-reqs): restore raw Link column in text table
PHP's printTable builds a 5-column row for text output, with the raw
Link object (cast via __toString) as its own column separate from the
formatted description string. The port had collapsed both into one
column, dropping an empty column for successful checks and throwing
off the rendered column widths/spacing versus real Composer output.
| -rw-r--r-- | crates/shirabe/src/command/check_platform_reqs_command.rs | 4 | ||||
| -rw-r--r-- | crates/shirabe/tests/command/check_platform_reqs_command_test.rs | 1 |
2 files changed, 4 insertions, 1 deletions
diff --git a/crates/shirabe/src/command/check_platform_reqs_command.rs b/crates/shirabe/src/command/check_platform_reqs_command.rs index 0f310ea4..5852050e 100644 --- a/crates/shirabe/src/command/check_platform_reqs_command.rs +++ b/crates/shirabe/src/command/check_platform_reqs_command.rs @@ -119,6 +119,10 @@ impl CheckPlatformReqsCommand { PhpMixed::List(vec![ PhpMixed::String(result.platform_package.clone()), PhpMixed::String(result.version.clone()), + match &result.link { + Some(link) => PhpMixed::String(link.to_string()), + None => PhpMixed::String(String::new()), + }, if let Some(link) = &result.link { PhpMixed::String(format!( "{} {} {} ({})", diff --git a/crates/shirabe/tests/command/check_platform_reqs_command_test.rs b/crates/shirabe/tests/command/check_platform_reqs_command_test.rs index 903d867a..f01f9062 100644 --- a/crates/shirabe/tests/command/check_platform_reqs_command_test.rs +++ b/crates/shirabe/tests/command/check_platform_reqs_command_test.rs @@ -48,7 +48,6 @@ fn run_platform_reqs_are_satisfied_case( #[test] #[serial] -#[ignore = "reaches a RefCell re-entrancy panic at crates/shirabe/src/downloader/file_downloader.rs:136 (\"RefCell already borrowed\") on the platform-package resolution path; src borrow bug, not fixable from the test"] fn test_platform_reqs_are_satisfied() { // 'Disables checking of require-dev packages requirements.' run_platform_reqs_are_satisfied_case( |